Feature #5602
open
Copy full path only copies partial
0%
Description
When viewing a file (example: https://XXXX/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs) and clicking on the button to "copy full path", it only copies "Program.cs" instead of the full url.
Version: RhodeCode Enterprise 4.18.2 Community Edition
Files
Updated by Luke Mauldin over 4 years ago
Would expect the "copy full path" to be https://xxxx/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs?fireglass_rsn=true
Updated by Marcin Kuzminski [CTO] over 4 years ago
This is by design. We made this feature as a result of similar feature available in GitHub, i.e you copy the path to a file path. Maybe the tooltip should be changed to copy file path instead of full which indeed could be confusing.
What do you think?
p.s Thanks for all the Tickets and feedback!
Updated by Luke Mauldin over 4 years ago
Our team does not have experience with Github and so the behavior of the button was unexpected to us. I think that changing the tooltip would help. It would also be nice to have a button that would copy the full URL address of the file to the clipboard instead of having to go to the browser address bar but I do not know how to present that from a UI perspective.
Updated by Marcin Kuzminski [CTO] over 4 years ago
- Assignee changed from Marcin Lulek to Daniel D
Updated by Daniel D over 4 years ago
- File CopyPath.png CopyPath.png added
Looking at this i think we can do better here:
Since the Path is copy&clickable (see screenshot) it would be good to remove the spaces between the /so users can easily copy the file path and make the tooltip copy the full url instead which is harder to copy imho.
Updated by Marcin Kuzminski [CTO] over 4 years ago
I think this is not intuitive, also changes existing behaviour which we should just now change. I think it makes sense to change the label, and maybe add copy url action next to copy content (there is some space)
Will check with UX and make a final call on this.
Updated by Redmine Integration over 4 years ago
- Status changed from New to Resolved
Commit 347fefc5eea6 by Daniel Dourvaris daniel@rhodecode.com on default branch changed this issue.
https://code.rhodecode.com/rhodecode-enterprise-ce/changeset/347fefc5eea6ae58e758e5fd827e650712c77b1a
Updated by Luke Mauldin over 4 years ago
Reviewed commit and manually appied the fix to the local instance. Update worked as expected. Thank you!