Project

General

Profile

Actions
Copy link

Feature #1131

open

Implement default reviewers for code review

Added by Anderson Santos almost 10 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Daniel D
Category:
-
Target version:
v4.5
Start date:
06.09.2016
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Sorting:
Commit Number:

Description

Currently it puts as a reviewer the owner of the repo. I don't know if there's an alternate way, but in case of RCE is Johannes, so every time we create a new PR, he will be selected even though most of the cases it will be some other member who will review it.

I propose we use this behavior only as a fallback and add an option to the repo to select the default reviewers. That way, we could even let the field blank and it will force the user to select a reviewer or something like that. The consequences still must be discussed.

Subtasks 1 (1 open — 0 closed)

Feature #4219: [ce, ee] Add mandatory reviewers for pull requestsResolvedMarcin Kuzminski [CTO]06.09.2016

Actions
Actions
Copy link
 #1

Updated by Johannes Bornhold over 9 years ago

  • Target version set to 76
Actions
Copy link
 #2

Updated by Marcin Kuzminski [CTO] almost 9 years ago

  • Private changed from No to Yes
Actions
Copy link
 #3

Updated by Marcin Kuzminski [CTO] over 8 years ago

  • Target version changed from 76 to v4.3
Actions
Copy link
 #4

Updated by Marcin Kuzminski [CTO] over 8 years ago

  • Private changed from Yes to No

This feature is about creating a special default reviewers implementation for repositories. It should replace the hacky rcextensiosn default reviewers module. Some specs:

  • ability to define groups/users that are added as default reviewers to each PR of particular repo
  • ability to mark that creator of PR cannot be the reviewer (common criteria requirement)
  • ability to specify random pool of reviewers and pick N to review
  • ability to propose reviewers based on annotation of code changes (similar to how https://github.com/facebook/mention-bot works)
  • ideally it could be great to define "patterns" to reviewers. If i specify file pattern, then a change file matching the patterns would pick X users. There could be file, target-branch patterns at the beginnig.
Actions
Copy link
 #5

Updated by Marcin Kuzminski [CTO] over 8 years ago

  • Subject changed from Remove default reviewer and add a per-repo default reviewers to Implement default reviewers for code review
Actions
Copy link
 #6

Updated by Marcin Kuzminski [CTO] over 8 years ago

  • Target version changed from v4.3 to v4.4
Actions
Copy link
 #7

Updated by Marcin Kuzminski [CTO] over 8 years ago

  • Assignee set to Daniel D

I want you Dan to pick this up after current topics

Actions
Copy link
 #11

Updated by Daniel D over 8 years ago

  • Status changed from New to In Progress
  • Target version changed from v4.4 to v4.5
Actions
Copy link
 #12

Updated by Redmine Integration over 8 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF