Project

General

Profile

Bug #5596

Pull Request duplicated after description edit

Added by Olivier Renaud almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
27.02.2020
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

One of my users created a pull request, then immediately edited the description and saved. This resulted in the pull request being stuck in the "merging" state (with the message "Cannot show diff when pull request state is changing. Current progress state: merging"), and with a new pull request being created (first PR is !69 and second is !70). Only the second PR contains the edit of the description. Interrestingly, only the rccextension hooks of the second PR ran.

#1

Updated by Marcin Kuzminski [CTO] almost 2 years ago

Could it be that he hit the create button twice? and created two PRs ?

Are there some automation for creating merges outside?

#2

Updated by Olivier Renaud almost 2 years ago

I cannot rule out he clicked the button twice. He spotted a mistake in the description just after clicking the create button, and he tried to fix it in a hurry. He says it's possible he used the "back" button of his browser. From there, it's possible he clicked the "submit pull request" button a second time. He remembers editing the description using the "edit" link next to the description field, though.

There is no automation to initiate a merge, no.

#3

Updated by Daniel D almost 2 years ago

  • Status changed from New to Resolved

In 4.18.3 we've added an additional way to unlock PRs stuck in such way. The double click we'll investigate more soon, but i think we should resolve this one for now.

Also available in: Atom PDF