Project

General

Profile

Feature #5581

expose `send_email` option in the HTTP API, for `comment_commit` and `comment_pull_request`

Added by Olivier Renaud about 1 month ago. Updated 27 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
14.01.2020
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:

Description

In the Python API, CommentsModel.create has a send_email argument, that controls whether mail notifications is sent to users.
In the HTTP API (comment_commit and comment_pull_request), there is no such option. It is possible to add CC mails, but not to mute the notifications.

I am writing a bot that will act as a pull request reviewer. As each change of a PR status requires a comment (under review, approved, rejected), I would like to send mail notifications only for important events (rejection). I know my users, they will definitely complain if they receive too much emails from this bot!

The request is to add a send_email parameter to these two HTTP API methods. It is not clear how this new argument should play with the existing extra_recipients argument, though.

History

#1 Updated by Marcin Kuzminski [staff] about 1 month ago

  • Assignee set to Daniel D

#2 Updated by Marcin Kuzminski [staff] about 1 month ago

  • Status changed from New to In Progress

#3 Updated by Redmine Integration about 1 month ago

  • Status changed from In Progress to Resolved

Commit 8dec0424a60a by Bartlomiej Wolynczyk nartek@rhodecode.com on stable branch changed this issue.
https://code.rhodecode.com/rhodecode-enterprise-ce/changeset/8dec0424a60ae498b46818be6b2ee5495bae2764

#4 Updated by Redmine Integration 27 days ago

Commit bb0e450ff9c4 by Bartlomiej Wolynczyk bartek@rhodecode.com on stable branch changed this issue.
https://code.rhodecode.com/rhodecode-enterprise-ce/changeset/bb0e450ff9c422f8dcea6e9582c669ab3e0532f5

Also available in: Atom PDF