Project

General

Profile

Bug #5630

Inline comments do not follow the line of code

Added by Olivier Renaud 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
20.07.2020
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

It seems to me that inline comments are attached to a specific line number, instead of a specific line of code. I commented inline on a PR, and the PR was updated in the meantime with insertions/deletions in other parts of the file. Now, my inline comment is 10 lines below the line of code the comment was about. I have a bunch of comments that don't make sense anymore, because they are not in the expected location.

This considerably reduces the usefulness of inline comments.

History

#1 Updated by Olivier Renaud 3 months ago

On a related note, I have an inline comment on a line that was later removed by a PR update. The comment is still there on an unrelated line, making things confusing. The comment was "please remove the slashes here".

#2 Updated by Daniel D 3 months ago

Hi,

Do you have enabled the Invalidate and relocate inline comments during update option ?

#3 Updated by Olivier Renaud 3 months ago

Oh right, I remember I changed this setting a long time ago. I remember I was not happy with its behavior, but I forgot the reason. I'll enable it again and see how it behaves. You can close this issue, thanks.

Also available in: Atom PDF