Project

General

Profile

Feature #5583

rcextensions hook for pull request comment

Added by Olivier Renaud 3 months ago. Updated 16 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
18.01.2020
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:

Description

There is no hook in rcextensions for when a comment is added on a pull request. I need that hook, because I am writing a bot and I would like users to be able to send commands to this bot using comments. For example, a user would add a comment "@buildbot trigger", and the rcextensions hook would send a request to our CI server.

The closest hook available is _review_pull_request_hook, but it's only when a comment of a reviewer changes the status through a comment.

Interestingly, webhooks can already react on new comments when the box "pullrequest commented" is checked. I don't see a way to reference the content of the comment though, so it does not seems very useful.

History

#1 Updated by Olivier Renaud 16 days ago

I found a workaround. It relies on adding a sqlalchemy hook in rcextensions.

from rhodecode.model.db import ChangesetComment
import sqlalchemy

@sqlalchemy.event.listens_for(ChangesetComment, 'after_insert')
def react_on_comment(_mapper, _connection, comment):
    text = comment.text
    author = comment.author.username
    pr = comment.pull_request
    # do cool things here

Also available in: Atom PDF