Project

General

Profile

Bug #5567

Error after PR was updated

Added by Sebastian Elsner about 1 month ago. Updated 1 day ago.

Status:
In Progress
Priority:
High
Assignee:
-
Category:
-
Target version:
-
Start date:
19.09.2019
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

RhodeCode CE 4.17.3, hg repository

I had a PR of a hg branch targeting "default". finished work on it, merged into default, closed the branch, updated the PR commit range and got the following error:

Traceback (most recent call last):
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/tweens.py", line 41, in excview_tween
    response = handler(request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/router.py", line 148, in handle_request
    registry, request, context, context_iface, view_name
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/view.py", line 667, in _call_view
    response = view_callable(context, request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/config/views.py", line 188, in attr_view
    return view(context, request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/config/views.py", line 214, in predicate_wrapper
    return view(context, request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/viewderivers.py", line 460, in rendered_view
    request, result, view_inst, context
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/renderers.py", line 451, in render_view
    return self.render_to_response(response, system, request=request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/renderers.py", line 474, in render_to_response
    result = self.render(value, system_values, request=request)
  File "/opt/rhodecode/store/p3adn3yl7ni8wg3d1556z2wrqw1mfbxb-python2.7-pyramid-1.10.4/lib/python2.7/site-packages/pyramid/renderers.py", line 470, in render
    result = renderer(value, system_values)
  File "/opt/rhodecode/store/cpi0ypxgs1d17grz8yhdx68d0agkx8zx-python2.7-pyramid-mako-1.0.2/lib/python2.7/site-packages/pyramid_mako/__init__.py", line 156, in __call__
    reraise(MakoRenderingException(errtext), None, exc_info[2])
  File "/opt/rhodecode/store/cpi0ypxgs1d17grz8yhdx68d0agkx8zx-python2.7-pyramid-mako-1.0.2/lib/python2.7/site-packages/pyramid_mako/__init__.py", line 148, in __call__
    result = template.render_unicode(**system)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/template.py", line 471, in render_unicode
    as_unicode=True)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 838, in _render
    **_kwargs_for_callable(callable_, data))
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 873, in _render_context
    _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 899, in _exec_template
    callable_(context, *args, **kwargs)
  File "_base_root_mako", line 108, in render_body
  File "_base_base_mako", line 58, in render_body
  File "rhodecode_templates_pullrequests_pullrequest_show_mako", line 598, in render_main
  File "_codeblocks_diffs_mako", line 823, in render_render_diffset
MakoRenderingException: 

Traceback (most recent call last):
  File "/opt/rhodecode/store/cpi0ypxgs1d17grz8yhdx68d0agkx8zx-python2.7-pyramid-mako-1.0.2/lib/python2.7/site-packages/pyramid_mako/__init__.py", line 148, in __call__
    result = template.render_unicode(**system)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/template.py", line 471, in render_unicode
    as_unicode=True)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 838, in _render
    **_kwargs_for_callable(callable_, data))
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 873, in _render_context
    _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
  File "/opt/rhodecode/store/nzp9vgf0x4h9z8djvgi6zm9y486klwq0-python2.7-mako-1.0.7/lib/python2.7/site-packages/mako/runtime.py", line 899, in _exec_template
    callable_(context, *args, **kwargs)
  File "/opt/rhodecode/store/wrn4w4gzarahd4k877nxa8cz1a5ifz91-python2.7-rhodecode-enterprise-ce-4.17.3/lib/python2.7/site-packages/rhodecode/templates/base/root.mako", line 153, in render_body
    ${next.body()}
  File "/opt/rhodecode/store/wrn4w4gzarahd4k877nxa8cz1a5ifz91-python2.7-rhodecode-enterprise-ce-4.17.3/lib/python2.7/site-packages/rhodecode/templates/base/base.mako", line 34, in render_body
    ${next.main()}
  File "/opt/rhodecode/store/wrn4w4gzarahd4k877nxa8cz1a5ifz91-python2.7-rhodecode-enterprise-ce-4.17.3/lib/python2.7/site-packages/rhodecode/templates/pullrequests/pullrequest_show.mako", line 551, in render_main
    ${cbdiffs.render_diffset(
  File "/opt/rhodecode/store/wrn4w4gzarahd4k877nxa8cz1a5ifz91-python2.7-rhodecode-enterprise-ce-4.17.3/lib/python2.7/site-packages/rhodecode/templates/codeblocks/diffs.mako", line 296, in render_render_diffset
    <div class="filediff" data-f-path="${filename}"  id="a_${h.FID(filediff.raw_id, filename)}">
UnboundLocalError: local variable 'filediff' referenced before assignment

History

#1 Updated by Marcin Kuzminski [staff] about 1 month ago

  • Target version deleted (v4.13)
  • Priority changed from Normal to High
  • Status changed from New to In Progress

Hi Sebastian,

Thanks for reporting this we'll fix that in the next release, it's an edge case for outdated files that had comments, and were removed during update of pull-request.

#2 Updated by Sebastian Elsner 1 day ago

Until you release a new version, is there some other way to close the PRs? They are starting to clutter the UI and kill overview.

#3 Updated by Marcin Kuzminski [staff] 1 day ago

We're going to release a bugfix release this week that along other things will address this issue, if you can wait a bit that would allow you to cleanup those normally.

Also available in: Atom PDF