Bug #5515
open
PR default reviewer is incorrect
0%
Description
Raising a PR to a main repo should use the owner of the main repo as the default reviewer. However it is currently using the owner of the forked repo as the default reviewer of the PR.
Updated by Daniel D about 6 years ago
Are you sure that during your test you didn't use the same account?
e.g if owner of REPO1 is 'admin1' and owner of REPO1_FORK is 'admin2' it means if 'admin1' starts the review he will not be added as reviewer, but a fallback will be used. It's because the same person shouldn't review its own code.
Please provide more details of who was the owner, and who started the review/pull request.
Updated by Arun Chandrasekaran about 6 years ago
Yes, I'm sure. Please look at the image below. Here the owner of the fork is Mahesh. He forked my repository and I pushed one of my test changeset to his fork and I asked him to raise a PR to my repo. The screen was captured when he raised the PR.
- His user name is
mahesh - The fork is in his personal repo.
- Author of the PR is shown as
mahesh - PR reviewer should've been me, as I'm the owner of the main repo or target repo. But that section contains
mahesh- which is a bug.
Does this explanation help?
Updated by Daniel D about 6 years ago
- Status changed from New to In Progress
Ok, confirmed that we use the "current" user instead of target repo owner. Actually in EE edition it's fine, it's a misconfiguration of CE edition. We'll add a fix into the next bugfix release, thanks for posting this !!
Updated by Redmine Integration almost 6 years ago
- Status changed from In Progress to Resolved
Commit 3c9caf8ef3a6 by Marcin Kuzminski marcin@rhodecode.com on default branch changed this issue.
https://code.rhodecode.com/rhodecode-enterprise-ce/changeset/3c9caf8ef3a6c4d71c194e6059bd33240b72021d