Bug #5412
open
Webhook for "pullrequest commented" event returns incomplete data
0%
Description
If there is a new pull request comment along with a status change, webhook returns the status as null instead of the actual status with the comment.
Here is the part of data returned:
comment: {
permalink_url: "https://rhodecode/_admin/pull-request/999#comment-6666",
line: null,
type: "note",
status: null,
text: "test test",
file: null,
url: "https://rhodecode/_admin/pull-request/999#comment-6666"
},
Updated by Rishipuri Bharatpuri almost 7 years ago
Is this an expected behaviour?
Updated by Marcin Kuzminski [CTO] almost 7 years ago
Not expected, what version are you using?
Updated by Marcin Kuzminski [CTO] almost 7 years ago
Hi,
We can confirm that. It's an issue related to database transaction isolation. We'll add a small fix to make sure the data is read properly in this case. The change is trivial, and we can send you a patch to fix this.
Updated by Redmine Integration almost 7 years ago
- Status changed from New to Resolved
Commit 4400cfcf1c11 by Marcin Kuzminski marcin@rhodecode.com on default branch changed this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/4400cfcf1c119c67aa48dacc0001f046541828ea
Updated by Rishipuri Bharatpuri almost 7 years ago
Hi,
Was this fix released? If yes, which version of rhodecode has it?
Updated by Marcin Kuzminski [CTO] almost 7 years ago
Yes, 4.11 series has this fix.