Bug #5412: Webhook for "pullrequest commented" event returns incomplete data - RhodeCode CE/EE - RhodeCode - issues

Bug #5412

Webhook for "pullrequest commented" event returns incomplete data

Added by Rishipuri Bharatpuri almost 2 years ago. Updated almost 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Target version:

Start date:

04.01.2018

Due date:

% Done:

Estimated time:

Sorting:

Commit Number:

Affected Version:

Description

If there is a new pull request comment along with a status change, webhook returns the status as null instead of the actual status with the comment.

Here is the part of data returned:

   comment: {
      permalink_url: "https://rhodecode/_admin/pull-request/999#comment-6666",
      line: null,
      type: "note",
      status: null,
      text: "test test",
      file: null,
      url: "https://rhodecode/_admin/pull-request/999#comment-6666"
    },

History

#1 Updated by Rishipuri Bharatpuri almost 2 years ago

Is this an expected behaviour?

#2 Updated by Marcin Kuzminski [staff] almost 2 years ago

Not expected, what version are you using?

#3 Updated by Rishipuri Bharatpuri almost 2 years ago

Currently on 4.10.6

#4 Updated by Marcin Kuzminski [staff] almost 2 years ago

ok, we'll check that then.

#5 Updated by Marcin Kuzminski [staff] almost 2 years ago

Hi,

We can confirm that. It's an issue related to database transaction isolation. We'll add a small fix to make sure the data is read properly in this case. The change is trivial, and we can send you a patch to fix this.