Project

General

Profile

Actions

Bug #5412

open

Webhook for "pullrequest commented" event returns incomplete data

Added by Rishipuri Bharatpuri about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04.01.2018
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

If there is a new pull request comment along with a status change, webhook returns the status as null instead of the actual status with the comment.

Here is the part of data returned:

   comment: {
      permalink_url: "https://rhodecode/_admin/pull-request/999#comment-6666",
      line: null,
      type: "note",
      status: null,
      text: "test test",
      file: null,
      url: "https://rhodecode/_admin/pull-request/999#comment-6666"
    },
Actions #1

Updated by Rishipuri Bharatpuri about 5 years ago

Is this an expected behaviour?

Actions #2

Updated by Marcin Kuzminski [CTO] about 5 years ago

Not expected, what version are you using?

Actions #3

Updated by Rishipuri Bharatpuri about 5 years ago

Currently on 4.10.6

Actions #4

Updated by Marcin Kuzminski [CTO] about 5 years ago

ok, we'll check that then.

Actions #5

Updated by Marcin Kuzminski [CTO] about 5 years ago

Hi,

We can confirm that. It's an issue related to database transaction isolation. We'll add a small fix to make sure the data is read properly in this case. The change is trivial, and we can send you a patch to fix this.

Actions #6

Updated by Redmine Integration about 5 years ago

  • Status changed from New to Resolved
Actions #7

Updated by Rishipuri Bharatpuri almost 5 years ago

Hi,

Was this fix released? If yes, which version of rhodecode has it?

Actions #8

Updated by Marcin Kuzminski [CTO] almost 5 years ago

Yes, 4.11 series has this fix.

Actions #9

Updated by Rishipuri Bharatpuri almost 5 years ago

Thank you.

Actions

Also available in: Atom PDF