Project

General

Profile

Actions

Task #4288

open

Feature #4232: [ce, ee, pr, compare] redo diffs, support side by side diffs, html diffs

[ce, ee] unify controllers that use diffs

Added by Daniel D over 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
19.10.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:

Description

Currently diffs are being used in these controllers:

  1. files controller: eg /repo/diff/somefile?diff1=commit1&diff2=commit2
  2. compare controller: eg. /repo/compare/tag@v4.2.1...tag@v4.2.0
  3. changeset controller: eg. /repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f
  4. pullrequest controller: eg. /repo/pull-request/332

These controllers use about 80% duplicate code which can be moved to a common base

Also some controller have options such as increase/decrease context which are not implemented in other controllers.

Actions #1

Updated by Marcin Kuzminski [CTO] about 6 years ago

  • Target version changed from v4.5 to v4.6
Actions #2

Updated by Marcin Kuzminski [CTO] about 6 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Marcin Kuzminski [CTO] about 6 years ago

  • Target version changed from v4.6 to v4.7
Actions #4

Updated by Marcin Kuzminski [CTO] almost 6 years ago

  • Target version changed from v4.7 to v4.8
Actions #5

Updated by Marcin Kuzminski [CTO] over 5 years ago

  • Target version changed from v4.8 to v4.10
Actions #6

Updated by Marcin Kuzminski [CTO] over 5 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF