Project

General

Profile

Task #4288

Feature #4232: [ce, ee, pr, compare] redo diffs, support side by side diffs, html diffs

[ce, ee] unify controllers that use diffs

Added by Daniel D almost 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
19.10.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:

Description

Currently diffs are being used in these controllers:

  1. files controller: eg /repo/diff/somefile?diff1=commit1&diff2=commit2
  2. compare controller: eg. /repo/compare/tag@v4.2.1...tag@v4.2.0
  3. changeset controller: eg. /repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f
  4. pullrequest controller: eg. /repo/pull-request/332

These controllers use about 80% duplicate code which can be moved to a common base

Also some controller have options such as increase/decrease context which are not implemented in other controllers.

History

#1 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.5 to v4.6

#2 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Status changed from New to In Progress

#3 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.6 to v4.7

#4 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.7 to v4.8

#5 Updated by Marcin Kuzminski [staff] about 2 years ago

  • Target version changed from v4.8 to v4.10

#6 Updated by Marcin Kuzminski [staff] about 2 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF