Description¶

If i click the save buttton on the issue tracker settings page without having any pattern added and no pattern already in the list it leads to an exception.
If i add a pattern or if there is at least one pattern already present it works fine.

Steps to reproduce¶

1. Open the page http://localhost:5000/_admin/settings/issue-tracker (adapt to your host)
2. Make sure that no pattern is in the list and don't add one.
3. Click the save button
4. Exception happens

Traceback¶

2016-10-14 12:01:34.209 ERROR [rhodecode.lib.middleware.error_handling] 'NoneType' object has no attribute 'getitem'
Traceback (most recent call last):
File "/Users/mb/work/ce/rhodecode/lib/middleware/error_handling.py", line 72, in handle_request
response = request.get_response(self.app)
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1320, in send
application, catch_exc_info=False)
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1284, in call_application
app_iter = application(self.environ, start_response)
File "/nix/store/nsdj1vmp0ir7hbgwb7sjb27cr8d8kplv-python2.7-Paste-2.0.2/lib/python2.7/site-packages/paste/registry.py", line 379, in call
app_iter = self.application(environ, start_response)
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 103, in call
response = self.dispatch(controller, environ, start_response)
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 313, in dispatch
return controller(environ, start_response)
File "/Users/mb/work/ce/rhodecode/lib/base.py", line 502, in call
return WSGIController.call(self, environ, start_response)
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 214, in call
response = self.dispatch_call()
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 164, in _dispatch_call
response = self._inspect_call(func)
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 107, in _inspect_call
result = self._perform_call(func, args)
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 57, in _perform_call
return func(**args)
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper
return wrapper(func, *args, **kwds)
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1334, in __wrapper
return func(*fargs, **fkwargs)
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper
return wrapper(func, *args, **kwds)
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1143, in __wrapper
return func(*fargs, **fkwargs)
File "/Users/mb/work/ce/rhodecode/controllers/admin/settings.py", line 400, in settings_issuetracker_save
for uid in form['delete_patterns']:
TypeError: 'NoneType' object has no attribute 'getitem_'