Support #4244
open
mod_dav_svn template error when using auth_realm with spaces in it
0%
Description
[tenderapp] report: https://rhodecode.tenderapp.com/help/discussions/problems/9626 reported by user: gildas.fargeas@nerd.nintendo.com
Hi,
i've noticed this small bug in the template you use for mod_dav_svn.conf. When the HTTP[S] authentication realm (set up in global settings page) is using multiple words separated with a space, the mod_dav_svn.conf file does not quote the name in the configuration resulting in an apache crash.
Additionnally, when using special characters there, these are converted to html so you should make sure the resulting string is not causing a potential error (or forbid special characters in the text input :) ).
I've quick-fixed it by quoting the ${rhodecode_realm} in the mako template located in /opt/rhodecode/store/bc6w8dzvdcs6dixi83cs32rbaj5zyz67-python2.7-rhodecode-enterprise-ce-4.4.0/lib/python2.7/site-packages/rhodecode/svn_support/templates/mod-dav-svn.conf.mako
That's it.
Updated by Marcin Kuzminski [CTO] about 8 years ago
- Target version set to v4.5
- Private changed from Yes to No
Updated by Marcin Kuzminski [CTO] about 8 years ago
- Status changed from In Progress to New
Updated by Martin Bornhold about 8 years ago
- Status changed from New to In Progress
- Assignee set to Martin Bornhold
Updated by Redmine Integration about 8 years ago
pullrequest created by martinb (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2728
Updated by Redmine Integration about 8 years ago
Commit 2c5a0bce3c08 by Martin Bornhold martin@rhodecode.com on default branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/2c5a0bce3c08c6419b8825f25601dc89d03a609e
Commit caf5ea418435 by Martin Bornhold martin@rhodecode.com on default branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/caf5ea418435b52bd53a3e1d053d7d32a4e6f2e8
Updated by Redmine Integration about 8 years ago
pullrequest merged by marcink (status: approved). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2728
Updated by Redmine Integration about 8 years ago
Commit f8eb995c50e4 by Martin Bornhold martin@rhodecode.com on stable branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/f8eb995c50e42a5c21da3f097d2fc07428e16042
Commit 8e79f249c9a9 by Martin Bornhold martin@rhodecode.com on stable branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/8e79f249c9a908100314ae3ea761163e971e8574
Updated by Martin Bornhold about 8 years ago
- Status changed from In Progress to Resolved