Project

General

Profile

Support #4244

mod_dav_svn template error when using auth_realm with spaces in it

Added by Marcin Kuzminski [staff] almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
Start date:
26.09.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

[tenderapp] report: https://rhodecode.tenderapp.com/help/discussions/problems/9626 reported by user: gildas.fargeas@nerd.nintendo.com

Hi,
i've noticed this small bug in the template you use for mod_dav_svn.conf. When the HTTP[S] authentication realm (set up in global settings page) is using multiple words separated with a space, the mod_dav_svn.conf file does not quote the name in the configuration resulting in an apache crash.

Additionnally, when using special characters there, these are converted to html so you should make sure the resulting string is not causing a potential error (or forbid special characters in the text input :) ).

I've quick-fixed it by quoting the ${rhodecode_realm} in the mako template located in /opt/rhodecode/store/bc6w8dzvdcs6dixi83cs32rbaj5zyz67-python2.7-rhodecode-enterprise-ce-4.4.0/lib/python2.7/site-packages/rhodecode/svn_support/templates/mod-dav-svn.conf.mako

That's it.

History

#1 Updated by Marcin Kuzminski [staff] almost 3 years ago

  • Private changed from Yes to No
  • Target version set to v4.5

#2 Updated by Marcin Kuzminski [staff] almost 3 years ago

  • Status changed from In Progress to New

#3 Updated by Martin Bornhold almost 3 years ago

  • Assignee set to Martin Bornhold
  • Status changed from New to In Progress

#4 Updated by Redmine Integration almost 3 years ago

pullrequest created by martinb (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2728

#8 Updated by Martin Bornhold almost 3 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF