default reviewers updates
Some of my notes
- it would be good to SAVE the reasons for a reviewer, so it's clear to outsiders which roles other members have. It's good to know "WHO" is the author, who is form the team etc
- it'd be good to have "exclude" author option so it's not a possibility that author gets picked to review his own PR
#1 Updated by Redmine Integration about 4 years ago
pullrequest created by dan (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2727
#2 Updated by Redmine Integration about 4 years ago
pullrequest created by dan (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ee/pull-request/2737
#3 Updated by Daniel D about 4 years ago
After some thought on second option (exclude pr author from reviewers)
How does this work for when the only person available for review is the pr author (ie. he is repo owner too), this can happen in eg. single user rhodecode instance
exclude author should be disabled when owner/author is only one available for the review process
Extending this, is there a reason to make this a toggle at all? Why not just exclude pr authors by default (which is what a multi user instance would want) and turn it off in the case of single user?
I guess the main question is: Why would a pull request author want to review his own pr?
#4 Updated by Marcin Kuzminski [CTO] about 4 years ago
Main reason to put an author of PR into a review is to "block" the approval. So i often put myself in order to make the PR not mergable.
So maybe the only thing we want is:
- in case there's only SINGLE reviewer it cannot be the author (the checkbox controls this actually)
- Author is never picked automatically
- If you want you can always add yourself to already existing pool of reviewers
I think in case of single instance then you have the author thing unchecked and system will/can pick YOU as reviewer, else it will not pick automatically, it will NOT allow you to create a PR with yourself as a reviewer.
This should imho cover all the cases, for Gemalto, for us, for a single-user-mode.
#5 Updated by Redmine Integration about 4 years ago
- Status changed from New to Resolved
Commit 930d1a1fb9e7 by Daniel Dourvaris firstname.lastname@example.org on default branch changed this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/930d1a1fb9e73ca8dc5e1a0cb831f54d57d00e08
#6 Updated by Redmine Integration about 4 years ago
pullrequest merged by marcink (status: approved). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2727
#7 Updated by Redmine Integration about 4 years ago
Commit 64eeaa9ee083 by Daniel Dourvaris email@example.com on default branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ee/changeset/64eeaa9ee083ca98471dd2094dd60ab198c3748b
#8 Updated by Redmine Integration almost 4 years ago
pullrequest created by dan (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ee/pull-request/2770
#9 Updated by Redmine Integration almost 4 years ago
pullrequest created by dan (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ee/pull-request/2771