Task #4185: [pyramid] switch routing to be fully pyramid only - RhodeCode CE/EE - RhodeCode - issues

Actions

Copy link

Task #4185

closed

[pyramid] switch routing to be fully pyramid only

Added by Marcin Kuzminski [CTO] over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

v5.0

Start date:

05.09.2016

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Sorting:

Commit Number:

Description

We need to start moving the code back to pyramid. We should start with making routes work only in PYRAMID, if that's possible.

need to investigate if we can make it work
we should have a one common place to define those like we had before
can we support pylons DELETE/PUT fake request mapping, or should we re-do all the routes not to use them (it's really a POST faked by special parameter to mimic DELETE/PUT)

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Daniel D over 8 years ago

One issue with moving urls to pyramid is that generating urls for tests can't use the url generator.

You can't use request.route_path('someroute') unless there is a request context - which means the tests would have to be done as:

url = ADMIN_PREFIX + '/some/route/' + str(id)

vs

url = request.route_path('someroute', id=id)

Although this might be good in actually finding route changing mistakes.

Actions

Copy link

Updated by Daniel D about 8 years ago

We can add middleware to support the fake _method arg, but it's a better idea to use POST/GET's for everything, since web browsers only support that and the endpoints are not actually REST in the end.

Actions

Copy link