Project

General

Profile

Feature #4183

Different roles for PR reviewers

Added by Tomoyuki Harada about 3 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
18.08.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:

Description

Currently we can set one or more reviewers for PR, but to complete review all reviewers must approve it.
This workflow is natural but sometimes we just want someone check modification as observer but not need to mandatory to complete the review.

History

#1 Updated by Marcin Kuzminski [staff] about 3 years ago

  • Target version set to v4.5

I like the idea. Few things that we need to put attention to:

  • voting needs to be calculated only on voting reviewer type
  • adding a reviewer with with different types should trigger different notifications
  • it should be possible to change the role of reviewer on already created PR

#2 Updated by Marcin Kuzminski [staff] about 3 years ago

  • Assignee set to Daniel D

#3 Updated by Marcin Kuzminski [staff] about 3 years ago

I think would come along with enforced reviewers logic. We'd add a special markers into reviewers (store roles inside the reviewers table)

Roles could be:

  • reviewer
  • observer
  • tester
  • linter

IN addition there should be an enforced bool type so added reviewer is not removable.

Based on those we could make strict/loose rules how things are reviewed and also how voting goes. Several times we had situation when the logic that picks reviewers based on code annotation picks a lot of guys.
Let's imagine someone is on vacation. Unless he's enforced reviewer. I'd be great to NOT remove that person in order for a merge, but change his type into observer.

It would be very usefull addition.

#4 Updated by Marcin Kuzminski [staff] almost 3 years ago

  • Target version changed from v4.5 to v4.6

#5 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.6 to v4.7

#6 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Subject changed from Observer role for PR reviewer to Different roles for PR reviewers

#7 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.7 to v4.8

#8 Updated by Marcin Kuzminski [staff] over 2 years ago

  • Target version changed from v4.8 to v4.10

#9 Updated by Marcin Kuzminski [staff] about 2 years ago

  • Target version changed from v4.10 to v4.11

Also available in: Atom PDF