Project

General

Profile

Feature #2882

Updated by Marcin Kuzminski [CTO] almost 5 years ago

When user is reviewing the code, each inline comment is submitted and notification sent to users, this might be annoying. Phabricator has really nice sollution for that. See attached gif

Some specs:
- users should see their UNSUBMITTED comments in a summary view, comments, and have ability to submit then (see second screenshot)
- Page should worn users before leaving that there are unsubmitted comments
- Unsubmitted comments should be stored inside DB, but they should not trigger notifications
- UN-submitted comments should be only visible to the creator (and super-admins)
- UN-submitted comments submit preview pane should be only visible to author, and super-admin. Both of them could submit the comments
-
Email should be re-formatted with bulk comments, not to spawn multi-emails
- UN-submitted comments should be marked with a tag, and show text:
- "this comment is private until you submit it" <submit it should be a link to the preview pane that allows submit


- The preview pane payne should allow to delete comments, and re-create them (Edit them) ?
- I think we Do Need EDIT functionality before this feature

Phabricator has this, and it's considered very nice option, also Kallithea has this ! Which we cannot be worse :)

Back