Bug #5510
AssertionError: unexpected parameters: user_agent & hook_type
Start date:
05.11.2018
Due date:
% Done:
0%
Estimated time:
Sorting:
Commit Number:
Affected Version:
Description
Most vcsserver actions result in exceptions after upgrade to 4.14.0. Rolled back to 4.13.2.
Eg:
Traceback (most recent call last):
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/router.py", line 276, in default_execution_policy
return router.invoke_request(request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/router.py", line 249, in invoke_request
response = handle_request(request)
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/tweens.py", line 45, in __call__
response = self.handler(request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/tweens.py", line 41, in excview_tween
response = _error_handler(request, exc)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/tweens.py", line 12, in _error_handler
response = request.invoke_exception_view(exc_info)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/view.py", line 744, in invoke_exception_view
request_iface=request_iface.combined,
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/view.py", line 642, in _call_view
response = view_callable(context, request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/viewderivers.py", line 410, in viewresult_to_response
result = view(context, request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/viewderivers.py", line 107, in mapped_view
return _mapped_view(context, request)
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/http_main.py", line 577, in handle_vcs_exception
raise exception
Exception: Got remote exception "AssertionError" with args "["Missing parameters: set([]), unexpected parameters: set(['user_agent', 'hook_type'])"]"
Traceback (most recent call last):
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/tweens.py", line 39, in excview_tween
response = handler(request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/router.py", line 156, in handle_request
view_name
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/view.py", line 642, in _call_view
response = view_callable(context, request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/viewderivers.py", line 410, in viewresult_to_response
result = view(context, request)
File "/opt/rhodecode/store/vipsx3nr7395jq0s9qrk1lhzalyg6nna-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/wsgi.py", line 37, in decorator
return request.get_response(wrapped)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1327, in send
application, catch_exc_info=False)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
app_iter = application(self.environ, start_response)
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/http_main.py", line 492, in _hg_stream
return app(environ, ResponseFilter(start_response))
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/scm_app.py", line 84, in __call__
data = gen.next()
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hgweb/hgweb_mod.py", line 308, in run_wsgi
for r in self._runwsgi(req, res, repo):
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/scm_app.py", line 106, in _runwsgi
return super(HgWeb, self)._runwsgi(req, res, repo)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hgweb/hgweb_mod.py", line 334, in _runwsgi
rctx, req, res, self.check_perm)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/wireprotoserver.py", line 224, in handlewsgirequest
_callhttp(repo, req, res, proto, cmd)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/wireprotoserver.py", line 439, in _callhttp
rsp = wireprotov1server.dispatch(repo, proto, cmd)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/wireprotov1server.py", line 75, in dispatch
return func(repo, proto, *args)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/wireprotov1server.py", line 593, in unbundle
proto.client())
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/exchange.py", line 2138, in unbundle
op = bundle2.processbundle(repo, cg, op=op)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/bundle2.py", line 460, in processbundle
processparts(repo, op, unbundler)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/bundle2.py", line 467, in processparts
_processpart(op, part)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/bundle2.py", line 534, in _processpart
handler(op, part)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/bundle2.py", line 1804, in handlechangegroup
expectedtotal=nbchangesets, **extrakwargs)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/bundle2.py", line 470, in _processchangegroup
ret = cg.apply(op.repo, tr, source, url, **kwargs)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/changegroup.py", line 285, in apply
throw=True, **pycompat.strkwargs(tr.hookargs))
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/localrepo.py", line 922, in hook
return hook.hook(self.ui, self, name, throw, **args)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hook.py", line 210, in hook
res = runhooks(ui, repo, htype, hooks, throw=throw, **args)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hook.py", line 262, in runhooks
throw)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hook.py", line 98, in _pythonhook
r = obj(ui=ui, repo=repo, hooktype=htype, **pycompat.strkwargs(args))
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/hooks.py", line 308, in pre_push
return _call_hook('pre_push', extras, HgMessageWriter(ui))
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/hooks.py", line 147, in _call_hook
_handle_exception(result)
File "/opt/rhodecode/store/cw4j97nfzhx1ldcqnpv94yllqmvmfpsh-python2.7-rhodecode-vcsserver-4.14.0/lib/python2.7/site-packages/vcsserver/hooks.py", line 130, in _handle_exception
(exception_class, result['exception_args']))
Exception: Got remote exception "AssertionError" with args "["Missing parameters: set([]), unexpected parameters: set(['user_agent', 'hook_type'])"]"
History
#1
Updated by Daniel D 7 months ago
Updated by Hi,
Yes this is expected. We updated rcextensions, please note on major upgrades form 4.13 -> 4.14 we always post upgrade notes: e.g https://docs.rhodecode.com/RhodeCode-Enterprise/release-notes/release-notes-4.14.0.html#upgrade-notes
An upgrade to rcextensions is required for 4.14, we tend to avoid as much as possible such breaking changes but this time we had to change few things in rcextensions.
Best,
#2
Updated by Peter Colledge 7 months ago
Updated by Thanks, and apologies. I did read the upgrade notes, but presumed the upgrade would break the extensions not the whole system! Upgrade now successful.
#3
Updated by Daniel D 7 months ago
Thanks !
We're sorry too. We should have been more explicit with the implications of the rcextensions update (as it runs as hooks low level) we'll update the docs so nobody misses is.
Btw, on a side note we have a confirmation that supervisord problems with older kernel don't affect anything else then startup (which 4.14 now patches to handle) So we believe that all will be fine with RHEL6 with the current changes!