Project

General

Profile

Support #5491

Upgrade RhodeCode Community + VCSSERVER from 4.10.4 to 4.12.4, pull request stop working with reviewers

Added by Igor Pinotti 6 months ago. Updated 5 months ago.

Status:
New
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
Start date:
18.07.2018
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

Hello,
Updated my RC from 4.10.1 to 4.12.4, and now, when doing pull-request, and adding the reviewers, so clicking on pull-request, I get this:

“Error creating pull request: review_members: Errors: rules: Missing value”

Obs:seems like there is no rule for reviewer, but I cannot change due to community version

What do I do?!

Thanks

2018-07-18 16:30:46.164 INFO [rhodecode.lib.auth] user authenticating with:RHODECODE_AUTH IS authenticated on func RepoPullRequestsView:pull_request_create
2018-07-18 16:30:46.244 ERROR [rhodecode.apps.repository.views.repo_pull_requests] Error creating pull request: review_members: Errors:
rules: Missing value
Traceback (most recent call last):
File “/opt/rhodecode/store/p9vr3b65srfrkr4gbag23mpcdkk0xy6w-python2.7-rhodecode-enterprise-ce-4.12.4/lib/python2.7/site-packages/rhodecode/apps/repository/views/repo_pull_requests.py”, line 799, in pull_request_create
_form = form.to_python(controls)
File “/opt/rhodecode/store/kvwhp79i5dck97jpdgwcglv6xbjbza90-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py”, line 419, in to_python
value = tp(value, state)
File “/opt/rhodecode/store/kvwhp79i5dck97jpdgwcglv6xbjbza90-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py”, line 196, in _to_python
value_dict, state, error_dict=errors)
Invalid: review_members: Errors:
rules: Missing value

History

#1 Updated by Marcin Kuzminski [staff] 6 months ago

Hi,

Did you somehow migrated/switched from EE into CE edition?

We're not sure how you got to this state, however, maybe try clearing out following DB tables:

repo_review_rules_users
repo_review_rules_users_groups
repo_review_rules

#2 Updated by Igor Pinotti 6 months ago

Hello Marcin,

I downloaded the windows version (VM ready), installed and switched to COMMUNITY. After using for a little while with repositories and branches, updated to 4.12.4, and the problem arises!

Can you describe how do I clean those tables?

Thank you

Marcin Kuzminski [staff] wrote:

Hi,

Did you somehow migrated/switched from EE into CE edition?

We're not sure how you got to this state, however, maybe try clearing out following DB tables:

repo_review_rules_users
repo_review_rules_users_groups
repo_review_rules

#3 Updated by Marcin Kuzminski [staff] 6 months ago

Please try this:

rccontrol ishell community-1

(or other instance-id if it's called e.g community-2)

In the Ishell run following commands:

RepoReviewRuleUserGroup.query().delete()
RepoReviewRuleUser.query().delete()
RepoReviewRule.query().delete()
Session().commit()

#4 Updated by Igor Pinotti 6 months ago

Did the following commands, but nothing happened!

Each delete command returned 0!

Marcin Kuzminski [staff] wrote:

Please try this:

rccontrol ishell community-1

(or other instance-id if it's called e.g community-2)

In the Ishell run following commands:

RepoReviewRuleUserGroup.query().delete()
RepoReviewRuleUser.query().delete()
RepoReviewRule.query().delete()
Session().commit()

#5 Updated by Igor Pinotti 6 months ago

And the behavior about the pull-request is the same

#6 Updated by Marcin Kuzminski [staff] 6 months ago

can you describe exactly what you do on this PR? in terms of reviewers ?

#7 Updated by Igor Pinotti 6 months ago

Just regular procedure! I have a main repository, and every developer forks from this repository! So they commit work to their own forked repository and do a pull request to merge into the main repository! Open the PR, select the branch to merge, add the reviewers, and simply click on PULL REQUEST! After that, a flash message appear on the top of the screen saying: “Error creating pull request: review_members: Errors: rules: Missing value”.

Did a test just clicking on pull request, without any reviewer added, and the PR is created! Don't know why!

Never worked with the enterprise version before on this machine! As soon as I had installed the VM, first thing I did was change to COMMUNITY! Worked on this version for a while, and then upgraded to 4.12.4! So the problem arise!

Marcin Kuzminski [staff] wrote:

can you describe exactly what you do on this PR? in terms of reviewers ?

#8 Updated by Igor Pinotti 6 months ago

Any news about this?

Igor Pinotti wrote:

Just regular procedure! I have a main repository, and every developer forks from this repository! So they commit work to their own forked repository and do a pull request to merge into the main repository! Open the PR, select the branch to merge, add the reviewers, and simply click on PULL REQUEST! After that, a flash message appear on the top of the screen saying: “Error creating pull request: review_members: Errors: rules: Missing value”.

Did a test just clicking on pull request, without any reviewer added, and the PR is created! Don't know why!

Never worked with the enterprise version before on this machine! As soon as I had installed the VM, first thing I did was change to COMMUNITY! Worked on this version for a while, and then upgraded to 4.12.4! So the problem arise!

Marcin Kuzminski [staff] wrote:

can you describe exactly what you do on this PR? in terms of reviewers ?

Marcin Kuzminski [staff] wrote:

can you describe exactly what you do on this PR? in terms of reviewers ?

#9 Updated by Marcin Kuzminski [staff] 6 months ago

Hi,

I'm sorry we don't know what could be the problem. This wasn't reported by anyway else, and we don't have the capacity to dig into this problem right now. Maybe try a fresh installation instead?

Best,

#10 Updated by Igor Pinotti 6 months ago

I see! And there is a way to migrate everything to a new instalation easily, or maybe create a new instance community-2 with the SW updated?

Another problem that I have, that maybe on the newer version is correct, is the timezone, I´ve just setted the corret time on Linux, but the rhodecode uses another stuff and there is no option to correct! I am on timezone -3!

Thank you

Marcin Kuzminski [staff] wrote:

Hi,

I'm sorry we don't know what could be the problem. This wasn't reported by anyway else, and we don't have the capacity to dig into this problem right now. Maybe try a fresh installation instead?

Best,

#11 Updated by Marcin Kuzminski [staff] 5 months ago

  • Target version changed from v4.12 to v4.14

Also available in: Atom PDF