Project

General

Profile

Bug #5371

Comment times in Pull Requests are off by 1 day

Added by Evan Ward about 2 years ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
11.08.2017
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

On a comment I just submitted I see:

note ward | 1 day ago | pull request #28

I would expect to see something like

note ward | 5 minutes ago | pull request #28

since I just submitted it.

I'm using RhodeCode Enterprise 4.8.0

timezone_patchfile.diff (1.34 KB) timezone_patchfile.diff Marcin Kuzminski [staff], 09.04.2018 16:33

History

#1 Updated by Marcin Kuzminski [staff] about 2 years ago

Hi Evan,

THis might be related to different timezone set on the server and Database, can you check if those are the same ?

Best

#2 Updated by Evan Ward about 2 years ago

OK, how do I check that? The database and web server are on the same machine.

#3 Updated by Marcin Kuzminski [staff] over 1 year ago

Hi Evan,

Sorry it took us so long, but we finally manage to look at this issue, and find potential solution. Because of nature of this task, we'd like to test this on your enviroment. Is it possible we could offer you a patch to test on your instance ?

#4 Updated by Evan Ward over 1 year ago

I can test a patch as long as it is easy to revert and won't cause a large disruption.

#5 Updated by Marcin Kuzminski [staff] over 1 year ago

Hi Evan,

The changes require are simple, and can be very easily reverted. Before i send you the patch and instructions, can you tell me what is your timezone on the server ?
e.g 'US/Central' ?

#6 Updated by Evan Ward over 1 year ago

US/Eastern same as New York.

#7 Updated by Marcin Kuzminski [staff] over 1 year ago

Evan,

Here are the instructions:

cd .rccontrol/enterprise-1/profile/etc/rhodecode_enterprise_ce_source/lib/python2.7/site-packages
copy over the example_patchfile.diff into that location
check if patch applies correctly
patch -p1 --dry-run -i example_patchfile.diff

# there should be no failed hunks.
# if that is true, proceed with execution.
patch -p1 -i patchfile.diff
# finally all the files that matched
# patching file <some_path>
# needs their .pyc cached files removed.

e.g 

patching file rhodecode/lib/vcs/backends/base.py
...

so we need to remove

rm rhodecode/lib/vcs/backends/base.pyc


# in case of any problems, patches can be removed by doing.
# rccontrol upgrade --force --version=X.Y.Z <name of instance>
# e.g rccontrol upgrade --force --version 4.10.6 enterprise-1
# where X.Y.Z is your RhodeCode Version, e.g 4.10.6

After that please restart rhodecode by doing:

rccontrol restart '*'

#8 Updated by Evan Ward over 1 year ago

That worked! Comment times now appear to be correct.

#9 Updated by Marcin Kuzminski [staff] over 1 year ago

Hi Evan,

Thanks for checking and sending us your confirmation. We'll include this fix in the next release. You can keep the patch applied it will be automatically overwritten by next version when you do an upgrade.

Best,

Also available in: Atom PDF