Support #4227
open
VBScript files detected as text/plain - no syntax highlighting
0%
Description
[tenderapp] report: https://rhodecode.tenderapp.com/help/discussions/problems/9610 reported
I have a project with VBScript files that are detected by RhodeCode as text/plain MIME types. CodeMirror is supposed to support this. The files are named *.vbs.
Other file types so far are detected correctly and show syntax highlighting.
Updated by Marcin Kuzminski [CTO] over 8 years ago
Hi,
What version are you using ? We just checked at 4.3.1 and .vbs files got correctly mapped to VBScript type in code-mirror.
Best,
Updated by Marcin Kuzminski [CTO] over 8 years ago
It is the latest version 4.3.1 downloaded and installed yesterday.
Updated by Marcin Kuzminski [CTO] over 8 years ago
Ok i see the problem, the CodeMirror editor supports it, but when you show the file it doesn't show the syntax.
We use Pygments for syntax HL on file, and i can see it doesn't support *.vbs files, only *.vb
http://pygments.org/docs/lexers/#pygments.lexers.dotnet.VbNetLexer
Updated by Marcin Kuzminski [CTO] over 8 years ago
Thanks for the information.
If the same lexer is handling VB.Net and VBA it should be able to handle
VBScript as well. I wouldn't know if that is something that can be
overridden.
Updated by Marcin Kuzminski [CTO] over 8 years ago
Hi,
Yes that's possible. We actually have an extension mechanism inside rcextensions when you can specify additional extensions => lexer mapping.
But we're going to make this a standard, that's an easy fix. It'll be in the next release.
Updated by Marcin Kuzminski [CTO] over 8 years ago
- Target version set to v4.4
- Private changed from Yes to No
Updated by Redmine Integration over 8 years ago
pullrequest created by marcink (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2681
Updated by Redmine Integration over 8 years ago
- Status changed from In Progress to Resolved
Commit 76d12e4e3f30 by Marcin Kuzminski marcin@rhodecode.com on default branch changed this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/76d12e4e3f30e0bac7415c9da530ea94f067c609
Updated by Redmine Integration over 8 years ago
pullrequest merged by marcink (status: approved). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2681