Project

General

Profile

Support #4227

VBScript files detected as text/plain - no syntax highlighting

Added by Marcin Kuzminski [staff] almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
14.09.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

[tenderapp] report: https://rhodecode.tenderapp.com/help/discussions/problems/9610 reported

I have a project with VBScript files that are detected by RhodeCode as text/plain MIME types. CodeMirror is supposed to support this. The files are named *.vbs.

Other file types so far are detected correctly and show syntax highlighting.

History

#1 Updated by Marcin Kuzminski [staff] almost 3 years ago

Hi,

What version are you using ? We just checked at 4.3.1 and .vbs files got correctly mapped to VBScript type in code-mirror.

Best,

#2 Updated by Marcin Kuzminski [staff] almost 3 years ago

It is the latest version 4.3.1 downloaded and installed yesterday.

#3 Updated by Marcin Kuzminski [staff] almost 3 years ago

Ok i see the problem, the CodeMirror editor supports it, but when you show the file it doesn't show the syntax.

We use Pygments for syntax HL on file, and i can see it doesn't support *.vbs files, only *.vb

http://pygments.org/docs/lexers/#pygments.lexers.dotnet.VbNetLexer

#4 Updated by Marcin Kuzminski [staff] almost 3 years ago

Thanks for the information.

If the same lexer is handling VB.Net and VBA it should be able to handle
VBScript as well. I wouldn't know if that is something that can be
overridden.

#5 Updated by Marcin Kuzminski [staff] almost 3 years ago

Hi,

Yes that's possible. We actually have an extension mechanism inside rcextensions when you can specify additional extensions => lexer mapping.

But we're going to make this a standard, that's an easy fix. It'll be in the next release.

#6 Updated by Marcin Kuzminski [staff] almost 3 years ago

  • Private changed from Yes to No
  • Target version set to v4.4

#7 Updated by Marcin Kuzminski [staff] almost 3 years ago

  • Description updated (diff)

#8 Updated by Redmine Integration almost 3 years ago

pullrequest created by marcink (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2681

#9 Updated by Redmine Integration almost 3 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF