Project

General

Profile

Bug #4161

anchor links open new comments

Added by Marcin Kuzminski [staff] over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
10.08.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

It's a regressions, when you open an URL like: https://internal-code.rhodecode.com/rhodecode-automation/pull-request/2546#tasks_api_docspy_n27

Instead of highlitinh the line in addition we end up with comment window open. We're suspecting chat additions does that ?

History

#1 Updated by Marcin Lulek over 3 years ago

Can you still replicate this?

https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2532#rhodecodeforms__init__py_n5

Im getting highlight AND comments/chat window. This also works on the URL pasted in the ticket.

#2 Updated by Marcin Kuzminski [staff] over 3 years ago

Yes that's the BUG, you should only get highlighted line, chat/comment window shouldn't be open on anchor links that points to a line number

#3 Updated by Marcin Lulek over 3 years ago

should be fixed in https://internal-code.rhodecode.com/rhodecode-enterprise-ee/pull-request/2549

the line in question was clicked by default - and i think it should not happen unless we have the "remainder" informing about chat.

#4 Updated by Marcin Kuzminski [staff] over 3 years ago

  • Status changed from New to Resolved

#5 Updated by Marcin Kuzminski [staff] over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF