Project

General

Profile

Actions

Bug #4048

closed

saving form with wrong values on LDAP raises 500 error

Added by Marcin Kuzminski [CTO] over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Category:
-
Target version:
Start date:
27.06.2016
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

Basically failing test is: test_ldap_error_form_wrong_port_number, we should fix it it's a release blocker

Actions #1

Updated by Martin Bornhold over 6 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Martin Bornhold over 6 years ago

  • Target version set to v4.2

The serialization of default values is not correct here. It leads to trouble if a validation error occures and also serializes python values like False to a string "false" which lead to a checked checkbox when displaying it. Fixed it by removing colanders serialize method and instead pass the schema defaults as default to self.plugin.get_setting_by_name()

Actions #3

Updated by Martin Bornhold over 6 years ago

  • Status changed from In Progress to Resolved
Actions #4

Updated by Martin Bornhold over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF