Bug #1709
closed
[styling, regression, release] pull requests breaking in IE8
0%
Description
There's something wrong with the pull requests, particularly with the diffs, which is causing them to bust far far out of the screen in IE8.
I've pinpointed at least part of the problem to some extra divs introduced here:
https://code.rhodecode.com/rhodecode-momentum/changeset/1d1d8e3c8b9ba6adc922b505e4e52cb59574b0f8#rhodecodetemplatespullrequestspullrequest_showhtml_n200
I am going to fix those as part of #1706, but it seems that this is not solving the problem entirely and requires further investigation.
Files
Updated by Lisa Quatmann over 9 years ago
- Subject changed from [styling] pull requests breaking in IE8 to [styling, regression] pull requests breaking in IE8
- Priority changed from Normal to High
- Target version set to v3.4 - Sprint #12
- Parent task set to #1689
I suggest that we fix this for the release!
Updated by Lisa Quatmann over 9 years ago
- Status changed from New to In Progress
- Assignee set to Lisa Quatmann
Updated by Johannes Bornhold over 9 years ago
- Subject changed from [styling, regression] pull requests breaking in IE8 to [styling, regression, release] pull requests breaking in IE8
Updated by Lisa Quatmann over 9 years ago
- Status changed from In Progress to Feedback
Stopping work on this for the moment. It is a known bug; appears as early as v 3.1.0.
Findings thus far:
- Aside from the above mentioned divs, which will get fixed anyway, the problem seems to be that @diffblock@ just does not want to behave and stay in its box. It pushes the table to some ridiculous width, and the whole thing centers somewhere far off to the right on the screen. Boo.
- Adding this seems to help: @.diff-container .diffblock { max-width: 1124px !important}@
- The above doesn't stop the td which surrounds @compare_view_filepath@ from expanding all over the place, though. Consequently, the table is still too wide, and the little changes graph is hanging out in the ether somewhere.
- johbo has suggested that this is not the only place where the @diff_block.diff_block_simple@ is making a mess of things.
Updated by Johannes Bornhold over 9 years ago
- Target version changed from v3.4 - Sprint #12 to 28
Decision: This is a known issue since a few releases and we failed to provide a fast enough fix. Will drop this into refinement, so that we decide within the team about how to handle this one.
Updated by Johannes Bornhold over 9 years ago
- Parent task set to #1827
We identified this as being related to the diff area and decided to group it together with that.
Updated by Mikhail Chernykh over 9 years ago
- Target version changed from 28 to Backlog
Decided during the refinement on 23.06.2015 to move it to backlog until Martina can take a look.
Updated by Johannes Bornhold over 9 years ago
- Priority changed from High to Normal
Normal priority, all items sit in the backlog.
Updated by Marcin Kuzminski [CTO] almost 9 years ago
- Private changed from No to Yes
Updated by Marcin Kuzminski [CTO] over 8 years ago
- Status changed from Feedback to Rejected
- Private changed from Yes to No
we no longer support ie8