Project

General

Profile

Bug #5218

500 when forking repository, when using special chars in password.

Added by Bartłomiej Wołyńczyk over 2 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
17.02.2017
Due date:
% Done:

0%

Estimated time:
Sorting:
Commit Number:
Affected Version:

Description

When some one clone repository and in his password contains chars "]","[" urlobject throw exception .
Reproduced:
1) Create new repository( import from existing). With "[" or "]" in yours password
example: https://wuboo:password[@internal-code.rhodecode.com/u/wuboo/rhodecode-enterprise-ce-fork-2
2) Open new repository
3) Go to options fork.
Or

from urlobject import URLObject
URLObject('https://wuboo:password[@internal-code.rhodecode.com/u/wuboo/rhodecode-enterprise-ce-fork-2').password

https://github.com/zacharyvoase/urlobject/issues/38

History

#2 Updated by Bartłomiej Wołyńczyk over 2 years ago

  • Description updated (diff)

#3 Updated by Bartłomiej Wołyńczyk over 2 years ago

Acoording to RFC
https://www.ietf.org/rfc/rfc3986.txt
pharagraf 2.2, characters below are reseved.

      reserved    = gen-delims / sub-delims
      gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
      sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

Also available in: Atom PDF