Bug #5218
open
500 when forking repository, when using special chars in password.
0%
Description
When some one clone repository and in his password contains chars "]","[" urlobject throw exception .
Reproduced:
1) Create new repository( import from existing). With "[" or "]" in yours password
example: https://wuboo:password[@internal-code.rhodecode.com/u/wuboo/rhodecode-enterprise-ce-fork-2
2) Open new repository
3) Go to options fork.
Or
from urlobject import URLObject
URLObject('https://wuboo:password[@internal-code.rhodecode.com/u/wuboo/rhodecode-enterprise-ce-fork-2').password
Updated by Bartłomiej Wołyńczyk almost 8 years ago
Acoording to RFC
https://www.ietf.org/rfc/rfc3986.txt
pharagraf 2.2, characters below are reseved.
reserved = gen-delims / sub-delims
gen-delims = ":" / "/" / "?" / "#" / "[" / "]" / "@"
sub-delims = "!" / "$" / "&" / "'" / "(" / ")"
/ "*" / "+" / "," / ";" / "="
Updated by Redmine Integration almost 8 years ago
pullrequest created by wuboo (status: under_review). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2867
Updated by Redmine Integration almost 8 years ago
Commit 6a7b20042c46 by Bartłomiej Wołyńczyk bartlomiej.wolynczyk@gmail.com on default branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/6a7b20042c46a7594010537e4771923c052c3cc4
Updated by Redmine Integration almost 8 years ago
pullrequest merged by marcink (status: approved). https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2867
Updated by Redmine Integration almost 8 years ago
Commit 7515faca2fdc by Bartłomiej Wołyńczyk bartlomiej.wolynczyk@gmail.com on default branch references this issue. https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/7515faca2fdc0e5487238eef19cd16a3526ca01d