https://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042016-06-10T18:14:12ZRhodeCode - issuesRhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=225822016-06-10T18:14:12ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<ul><li><strong>Target version</strong> changed from <i>v4.1</i> to <i>v4.2</i></li></ul> RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226062016-06-15T12:35:17ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li></ul><p>Bumping priority for that as it might be really problematic regressions for some cases when you don't do http -> https redirect, and it's a regressions actually.</p>
RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226072016-06-15T13:07:02ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<ul></ul><p>One important note:</p>
<ul>
<li>enabling proxy-prefix middleware actually solves the problem. We believe that we should always enable this as it's a good default with an empty prefix. </li>
</ul>
<p>We should check what custom logic is inside the SSL wrapper, and if we still need-it or things can be actually fixed by using proxy-prefix.</p>
RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226222016-06-16T09:35:35ZJohannes Bornholdjohannes@rhodecode.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Johannes Bornhold</i></li></ul> RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226232016-06-16T09:36:36ZJohannes Bornholdjohannes@rhodecode.com
<ul></ul><p>Ok, here we go:</p>
<ul>
<li>First investigations to understand what we have here</li>
<li>Maybe only proxy prefix middleware</li>
<li>Otherwise plain fix</li>
</ul>
RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226242016-06-16T09:47:42ZJohannes Bornholdjohannes@rhodecode.com
<ul></ul><p>Investigation details</p>
<ul>
<li> It is included in <code>make_app</code> which is producing the pylons app, this means it
is for sure not active for the pyramid app.</li>
<li> Moving it up in the stack could already restore the old behavior.</li>
<li> Inspection of the implementation
<ul>
<li> <code>rhodecode/lib/middleware/https_fixup.py</code></li>
<li> It appends htsts headers</li>
<li> It applies changes to the environ if it detects SSL</li>
<li> Conclusion:
<ul>
<li> Moving it up should restore the old behavior, then we are fixed.</li>
<li> Improving things can be done in a later step.</li>
</ul></li>
</ul></li>
</ul>
RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226252016-06-16T12:06:30ZJohannes Bornholdjohannes@rhodecode.com
<ul></ul><p><a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2346" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/pull-request/2346</a></p>
RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226262016-06-16T12:31:21ZJohannes Bornholdjohannes@rhodecode.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> RhodeCode CE/EE - Bug #4010: [ce] Check that HTTPS fixup middleware wraps also pyramid views.https://issues.rhodecode.com/issues/4010?journal_id=226972016-06-21T18:08:49ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>