RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042017-05-30T16:11:23ZRhodeCode - issues
Redmine RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Task #4311 (Resolved): Diffs feedbackhttps://issues.rhodecode.com/issues/43112016-11-24T15:48:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Below some feedback items that i made</p>
RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Task #4288 (Resolved): [ce, ee] unify controllers that use diffshttps://issues.rhodecode.com/issues/42882016-10-19T08:19:57ZDaniel Ddaniel@rhodecode.com
<p>Currently diffs are being used in these controllers:</p>
<ol>
<li>files controller: eg <code>/repo/diff/somefile?diff1=commit1&diff2=commit2</code></li>
<li>compare controller: eg. <code>/repo/compare/tag@v4.2.1...tag@v4.2.0</code></li>
<li>changeset controller: eg. <code>/repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f</code></li>
<li>pullrequest controller: eg. <code>/repo/pull-request/332</code></li>
</ol>
<p>These controllers use about 80% duplicate code which can be moved to a common base</p>
<p>Also some controller have options such as increase/decrease context which are not implemented in other controllers.</p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Task #4246 (New): [ce, ee, vcs, git] add tests for annotated git tagshttps://issues.rhodecode.com/issues/42462016-09-27T15:46:51ZDaniel Ddaniel@rhodecode.com
<p>Need to add a test that makes sure annotated git tags are correctly dereferenced / peeled to the actual commit they point to.</p>
RhodeCode CE/EE - Task #4238 (Resolved): default reviewers updateshttps://issues.rhodecode.com/issues/42382016-09-22T12:45:15ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Some of my notes</p>
<ul>
<li>it would be good to SAVE the reasons for a reviewer, so it's clear to outsiders which roles other members have. It's good to know "WHO" is the author, who is form the team etc</li>
<li>it'd be good to have "exclude" author option so it's not a possibility that author gets picked to review his own PR</li>
</ul>
RhodeCode CE/EE - Task #4202 (Resolved): Polish the 503.html pagehttps://issues.rhodecode.com/issues/42022016-08-29T16:56:27ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>We have a custom page for NGINX if RhodeCode is down, under: <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html</a></p>
<p>It is shown via such NGINX entry:</p>
<pre><code> ## custom 502 error page
error_page 502 /502.html;
location = /502.html {
root /path/to/.rccontrol/enterprise-1/static;
}
</code></pre>
<p>It looks very ugly, we should make it look nice and have some more usefull information.</p>
<p>We CANNOT use any variables, images etc. It needs to be PURE html (similar to email templates) but without variables.</p>
RhodeCode CE/EE - Task #4197 (New): [ce, ee] get list of users with their permissions to a reposi...https://issues.rhodecode.com/issues/41972016-08-24T14:31:24ZDaniel Ddaniel@rhodecode.com
<p>Related to <a href="https://issues.rhodecode.com/issues/4150" class="external">https://issues.rhodecode.com/issues/4150</a></p>
<p>Need a way to get all users from a repository along with their permissions for that repo.</p>
<p>At the moment permissions are generated via a complex python object in rhodecode.lib.auth:AuthUser which calculates the tree for a single user, taking into account default user, repo settings (overriding globals or not), and usergroups.</p>
<p>Iterating over the entire list of users is much too slow, some preliminary benchmarks show that it will take 10seconds / 100users.</p>
<p>In order to do this quickly instead, we would have to generate permissions via sql - A simplish (not completely correct results) query shows it will take about 50ms on internal rhodecode db.</p>
<pre><code>
SELECT
users.username,
repositories.repo_name,
MIN(origin_sort || '-' || permission_name) as perm
FROM (
SELECT
'' as ug,
permissions.permission_name,
user_id,
repository_id,
'1-user' as origin_sort
FROM
repo_to_perm
JOIN
permissions ON
permissions.permission_id = repo_to_perm.permission_id
-- WHERE repository_id = 190
UNION ALL
SELECT
users_groups.users_group_name,
permissions.permission_name,
users_groups_members.user_id,
repository_id,
'2-usergroup-' || users_groups.users_group_name as origin_sort
FROM
users_group_repo_to_perm
JOIN
permissions ON
permissions.permission_id = users_group_repo_to_perm.permission_id
JOIN
users_groups_members
ON
users_groups_members.users_group_id = users_group_repo_to_perm.users_group_id
JOIN
users_groups
ON
users_group_repo_to_perm.users_group_id = users_groups.users_group_id
-- WHERE repository_id = 190
) tmp_user_and_usergroup_perms
JOIN users ON users.user_id = tmp_user_and_usergroup_perms.user_id
JOIN repositories ON repositories.repo_id = tmp_user_and_usergroup_perms.repository_id
GROUP BY users.username, repositories.repo_name
ORDER BY username, perm
;
</code></pre> RhodeCode CE/EE - Task #4181 (Resolved): Integrations: allow root repos only integrationshttps://issues.rhodecode.com/issues/41812016-08-18T16:09:31ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I realized that repo groups already allow to have really good control over integrations. I think last missing bit would be a flag that sets the global integrations to work for root level projects only. This would allow to create global catch all for all root level projects, + possible combinations of integrations on repo group level.</p>
<p>THen i could:</p>
<ul>
<li>set global slack integration for all our root projects which are the main ones</li>
<li>set slack integration for <code>u</code> usergroup which is our namespace for forks</li>
<li>skip <code>release</code> group which produces a lot of noise</li>
<li>add any other repo group that we have if we need to.</li>
</ul>
<p>THoughts ?</p>
RhodeCode CE/EE - Task #4180 (Resolved): integrations: possible limit the updates senthttps://issues.rhodecode.com/issues/41802016-08-17T09:42:46ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>based on the amount of comments in this ticket: <a href="https://issues.rhodecode.com/issues/4172" class="external">https://issues.rhodecode.com/issues/4172</a></p>
<p>I wonder, if maybe it's better to aggregate those, and send a list of referenced tickets instead of updating ticket on each commit pushed. In case of large pushes it would almost spam the issue tracker server. After i merged 5-6 commits i got 5-6 emails from redmine.</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>