RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-04-02T14:34:35ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #5610 (Resolved): Files navigation looses the at=<name> markerhttps://issues.rhodecode.com/issues/56102020-04-02T14:34:35ZDaniel Ddaniel@rhodecode.com
<p>During investigation of <a class="issue tracker-1 status-3 priority-2 priority-default" title="Bug: SVN navigation to trunk fails (Resolved)" href="https://issues.rhodecode.com/issues/5599">#5599</a> we also discovered that the ?at= GET marker that indicates current reference we're browsing is getting lost when navigating via tree/files. We'd need to fix this to preserve that marker especially for SVN</p>
RhodeCode CE/EE - Bug #5604 (Resolved): Search error on second result pagehttps://issues.rhodecode.com/issues/56042020-03-27T19:55:33ZLuke Mauldin
<p>Encountered error when using a smultiple search terms and navigating to the second page.<br><br>
Scenario:</p>
<ol>
<li>Search for: FromError AND extension:go --- the url generated is: httpsXXXXcom/_admin/search?q=FromError+AND+extension%3Ago&type=content&max_lines</li>
<li>Navigate to the second page of the results. =10The search query is changed in the search box to be: FromError%20AND%20extension%3Ago and the generated url is: httpsXXXXXcom/_admin/search?q=FromError%2520AND%2520extension%253Ago&max_lines=10&sort=desc%3Adate&type=content&pag</li>
</ol>
<p>It looks like the application is trying to encode the spaces in the URL but it is not working as expected.e=2</p>
RhodeCode CE/EE - Bug #5599 (Resolved): SVN navigation to trunk failshttps://issues.rhodecode.com/issues/55992020-03-27T16:23:49ZLuke Mauldin
<p>In an SVN repository navigation fails when trying to navigate to the version of the file on the trunk.</p>
<p>Scenario:</p>
<ul>
<li>Setup SVN repository with normal layout: branches, tags, trunk</li>
<li>Create a file trunk/test_4.txt and commit multiple changes to it</li>
<li>Navigate to view a non-HEAD revision (assume HEAD is revision 20, but view revision 18) - example: <a href="https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt" class="external">https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt</a></li>
<li>In the left hand side from the revision list choose 'trunk' and the URL generated link is wrong - <a href="https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt" class="external">https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt</a></li>
<li>If I manually edit the address to the following then it workshttps://etsgit.gvl.is.l-3com.com/playground/testrepo/files/20/trunk/test_4.txt: </li>
</ul>
<p>I have not been able to reproduce this with a Git repository.</p>
<p>Version: RhodeCode Enterprise 4.18.2 Community Edition </p>
RhodeCode CE/EE - Bug #5579 (Resolved): JS bug when a commit message can be parsed as a numberhttps://issues.rhodecode.com/issues/55792019-12-29T21:40:15ZOlivier Renaud
<p>Steps to reproduce:</p>
<ul>
<li>Push a commit in a feature branch, with the message "123"</li>
<li>Go to the Pull Request creation page, and select the branch in the "source" drop down.</li>
</ul>
<p>Javascript fails with "TypeError: rawMessage.split is not a function" in getTitleAndDescription (script.js:55503).<br>
The debugger shows that rawMessage is a number at this point, and not a string.</p>
RhodeCode CE/EE - Bug #4296 (Resolved): [ee] Can not create pull requests with reviewers.https://issues.rhodecode.com/issues/42962016-10-24T17:20:47ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i create a PR in CE it works but in EE it fails. I also get no error message.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Create a pr as admin user</li>
<li>Leave the default reviewer (admin itself) in place</li>
<li>Try to submit the PR</li>
<li>Error happens without error message.</li>
</ol>
<a name="Investigations-so-far"></a>
<h1 >Investigations so far<a href="#Investigations-so-far" class="wiki-anchor">¶</a></h1>
<p>The difference is in the data which is posted to the controller. In CE it works and the POST data looks like this:</p>
<pre><code>{u'review_members': [{u'reasons': [], 'user_id': u'2'}], 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', u'revisions': [u'7fecd3f02a2cc73ac03d267ab234cabbfbb5bf31', u'06c48b467036bba03305640d1fb7854632dce351'], 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<p>In EE it fails and the POST data looks like this:</p>
<pre><code>{'review_members': u'2', 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', 'revisions': u'06c48b467036bba03305640d1fb7854632dce351', 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<pre><code>2016-10-24 16:56:06.533 ERROR [rhodecode.controllers.pullrequests] Error creating pull request: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
Traceback (most recent call last):
File "/nix/store/l1rdgp35mnr58w3hww23l3h8q5zbcld7-python2.7-rhodecode-enterprise-ce-4.5.0/lib/python2.7/site-packages/rhodecode/controllers/pullrequests.py", line 411, in create
_form = PullRequestForm(repo.repo_id)().to_python(controls)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py", line 419, in to_python
value = tp(value, state)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py", line 153, in _to_python
new[name] = validator.to_python(value, state)
Invalid: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
</code></pre> RhodeCode CE/EE - Bug #4278 (Resolved): [admin] Clicking the save button in admin -> settings -> ...https://issues.rhodecode.com/issues/42782016-10-14T12:08:32ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i click the save buttton on the issue tracker settings page without having any pattern added and no pattern already in the list it leads to an exception.<br>
If i add a pattern or if there is at least one pattern already present it works fine.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Open the page <a href="http://localhost:5000/_admin/settings/issue-tracker" class="external">http://localhost:5000/_admin/settings/issue-tracker</a> (adapt to your host)</li>
<li>Make sure that no pattern is in the list and don't add one.</li>
<li>Click the save button</li>
<li>Exception happens</li>
</ol>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<p>2016-10-14 12:01:34.209 ERROR [rhodecode.lib.middleware.error_handling] 'NoneType' object has no attribute '<strong>getitem</strong>'<br>
Traceback (most recent call last):<br>
File "/Users/mb/work/ce/rhodecode/lib/middleware/error_handling.py", line 72, in handle_request<br>
response = request.get_response(self.app)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1320, in send<br>
application, catch_exc_info=False)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1284, in call_application<br>
app_iter = application(self.environ, start_response)<br>
File "/nix/store/nsdj1vmp0ir7hbgwb7sjb27cr8d8kplv-python2.7-Paste-2.0.2/lib/python2.7/site-packages/paste/registry.py", line 379, in <strong>call</strong><br>
app_iter = self.application(environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 103, in <strong>call</strong><br>
response = self.dispatch(controller, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 313, in dispatch<br>
return controller(environ, start_response)<br>
File "/Users/mb/work/ce/rhodecode/lib/base.py", line 502, in <strong>call</strong><br>
return WSGIController.<strong>call</strong>(self, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 214, in <strong>call</strong><br>
response = self.<u>dispatch_call()<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 164, in _dispatch_call<br>
response = self._inspect_call(func)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 107, in _inspect_call<br>
result = self._perform_call(func, args)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 57, in _perform_call<br>
return func(**args)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1334, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1143, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/controllers/admin/settings.py", line 400, in settings_issuetracker_save<br>
for uid in form['delete_patterns']:<br>
TypeError: 'NoneType' object has no attribute '</u><u>getitem</u>_'</p>
RhodeCode CE/EE - Bug #4268 (Resolved): [ee] default reviewers from changed lines is returning wr...https://issues.rhodecode.com/issues/42682016-10-06T14:18:07ZDaniel Ddaniel@rhodecode.com
<p>When getting default reviewers from authors of changed lines, not all the hunks are being processed, just the first one, meaning the changed lines are wrong (too low)</p>
RhodeCode CE/EE - Bug #4256 (New): [ce, ee, ux] Source code highlight colors conflict with red/gr...https://issues.rhodecode.com/issues/42562016-10-03T05:00:14ZDaniel Ddaniel@rhodecode.com
<p>The CSS for pygments uses some green and red text which conflict with green/red blocks we use in diffs - have to change these to something else. </p>
RhodeCode CE/EE - Bug #4233 (Resolved): slack, git push problemhttps://issues.rhodecode.com/issues/42332016-09-19T13:24:56ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>got this while pushing to the website project:</p>
<pre><code>2016-09-19 10:52:04.619 CRITI [rhodecode.integrations.types.slack] {'author': u'Marcin Kuzminski <marcin@rhodecode.com>', 'branch': None, 'mentions': [], 'issues': [], 'url': 'https://internal-code.rhodecode.com/rhodecode-website/changeset/50586183192a283ea3dfbb2347174ec67a70574e', 'date': datetime.datetime(2016, 9, 19, 10, 51, 5), 'raw_id': '50586183192a283ea3dfbb2347174ec67a70574e', 'revision': 1879, 'short_id': '50586183192a', 'message_html': literal(u'settings: updated with latest changes\n'), 'reviewers': [], 'parents': [{'raw_id': 'ab5b2b1ad9c3058f374aba0434f71f987eaee3b7'}], 'message': u'settings: updated with latest changes\n'}
2016-09-19 10:52:04.619 ERROR [rhodecode.integrations] failure occured when sending event <rhodecode.events.repo.RepoPushEvent object at 0x7f8d29d05410> to integration <Integration(u'slack', 'root_repos')>
Traceback (most recent call last):
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/__init__.py", line 54, in integrations_event_handler
integration_model.send_event(integration, event)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/model/integration.py", line 108, in send_event
handler.send_event(event)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/types/slack.py", line 139, in send_event
text = self.format_repo_push_event(data)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/types/slack.py", line 227, in format_repo_push_event
branch_commits = {'branch': branch_data[commit['branch']],
KeyError: None
</code></pre> RhodeCode CE/EE - Bug #4223 (Resolved): [git, tags] annotated tags not appearing in UIhttps://issues.rhodecode.com/issues/42232016-09-09T11:51:31ZLisa Quatmannlisa@rhodecode.com
<p>When I have an annotated tag in a git repo, and I push this tag, I do not see it listed in the changelog, the repo summary, the repo tag summary, or the commit detail page.</p>
<p>As reported in the community slack: <a href="https://rhodecode-community.slack.com/archives/general/p1473412004000013" class="external">https://rhodecode-community.slack.com/archives/general/p1473412004000013</a></p>
RhodeCode CE/EE - Bug #4208 (New): [ce, ee] test errors get hidden by error pagehttps://issues.rhodecode.com/issues/42082016-08-30T18:42:32ZDaniel Ddaniel@rhodecode.com
<p>When running tests the traceback is excepted away by the error handler page, this makes it difficult to debug since eg</p>
<pre><code>app.get('/page_that_errors')
</code></pre>
<p>will return a 500 error page instead of a traceback.</p>
<p>OTOH making tests always raise errors will then break the page that checks if the pretty error page is working as it should.</p>
<p>Need to add a dynamic setting, eg settings['use_error_document'] = False - that can be turned on/off at will and will disable the pretty error page handler for running tests.</p>
RhodeCode CE/EE - Bug #4173 (Resolved): [ce, ee] mysql recycle pool timeout not workinghttps://issues.rhodecode.com/issues/41732016-08-12T16:41:27ZDaniel Ddaniel@rhodecode.com
<p>Replication:</p>
<ul>
<li>new config using mysql database</li>
<li>set mysql's wait_timeout to 6</li>
<li><code>threads = 1</code> in ini</li>
<li><code>sqlalchemy.db1.pool_recycle = 3</code> in ini</li>
<li>git push a repo (no changes need, just a push)</li>
<li>wait 7 seconds</li>
<li>git push again</li>
<li>get - <code>OperationalError: (OperationalError) (2006, 'MySQL server has gone away)</code></li>
</ul>
<p>This will also break subsequent requests with <code>StatementError: Can't reconnect until invalid transaction is rolled back</code></p>
RhodeCode CE/EE - Bug #4110 (In Progress): [ce, ee] repos can be named _admin, _statichttps://issues.rhodecode.com/issues/41102016-07-20T13:34:37ZDaniel Ddaniel@rhodecode.com
<p>There is a bug where repo name can have the name '_admin' this is because ADMIN_PREFIX which is used for checking the repo name had a slash prefixed to it making the check not work.</p>
<p>Must fix the bug and make this check more robust.</p>
RhodeCode CE/EE - Bug #4092 (Feedback): [ce, ee] Redmine/JIRA integrations - smart commitshttps://issues.rhodecode.com/issues/40922016-07-15T12:29:44ZDaniel Ddaniel@rhodecode.com
<p>For the redmine case there are 5 states for a ticket:</p>
<ul>
<li>new</li>
<li>in progress</li>
<li>resolved</li>
<li>feedback</li>
<li>closed'</li>
</ul>
<p>Commit messages should be able to auto close/resolve tickets using keywords such as <code>fixes #42</code></p>
<p>The thing to think about is that the user may want 'fixes #20' to set the redmine issue to any of 'resolved', 'feedback' or 'closed' - this should be set in the integration options.</p>
<p>Allowing custom multiple regex => state mappers per integration is the most powerful but might be overkill- making standard keywords might be better eg:</p>
<p>fixes => resolved<br>
closes => closed</p>
<p>Then again this might be no good for international users.</p>
RhodeCode CE/EE - Bug #4091 (Resolved): [ce, ee] Redmine integration blocks for 30 seconds if red...https://issues.rhodecode.com/issues/40912016-07-15T08:59:15ZDaniel Ddaniel@rhodecode.com
<p>This is a problem when not running celery - ie. sync mode, should lower the timeout to something smaller.</p>