RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042017-04-05T12:39:52ZRhodeCode - issues
Redmine RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Bug #4256 (New): [ce, ee, ux] Source code highlight colors conflict with red/gr...https://issues.rhodecode.com/issues/42562016-10-03T05:00:14ZDaniel Ddaniel@rhodecode.com
<p>The CSS for pygments uses some green and red text which conflict with green/red blocks we use in diffs - have to change these to something else. </p>
RhodeCode CE/EE - Task #4246 (New): [ce, ee, vcs, git] add tests for annotated git tagshttps://issues.rhodecode.com/issues/42462016-09-27T15:46:51ZDaniel Ddaniel@rhodecode.com
<p>Need to add a test that makes sure annotated git tags are correctly dereferenced / peeled to the actual commit they point to.</p>
RhodeCode CE/EE - Feature #4232 (New): [ce, ee, pr, compare] redo diffs, support side by side dif...https://issues.rhodecode.com/issues/42322016-09-18T16:40:43ZDaniel Ddaniel@rhodecode.com
<p>One of the most requested features is side by side diffs for multiple files at the same time (eg. pull request & compare pages).</p>
<p>Currently we have side by side diffs implemented for a single files only using the javascript library mergely. This doesn't include inline comments and uses different syntax highlighting to the rest of Rhodecode. Copy paste of code also works differently between the pr page and the side/side view.</p>
<p>There is another javascript diff library: <a href="https://diff2html.xyz/demo" class="external">https://diff2html.xyz/demo</a>, which gives very good results, however integrating inline comments and context loading into this proved to be a lot of trouble, also the syntax highlighting doesn't support partial code blocks very well, eg:</p>
<pre><code>51 this is the end of a doc string
52 """
53 return True
</code></pre>
<p>will mark the <code>return True</code> part as a string.</p>
<p>Therefore the things we need in diffs are:</p>
<ul>
<li>Syntax highlighting based on the entire file, rather than the partial diff</li>
<li>Inline comments + all relevant functionality</li>
<li>Ajax file context loading (eg. click to load more lines of a file before/after the changed lines)</li>
<li>In the browser conversion between raw/unified/side diffs - using JS</li>
</ul>
<p>This will be exposed as a reusuable widget that can be used anywhere in Rhodecode, taking a diff reference as a sole argument.</p>
<p>The steps to create the diff are:</p>
<ol>
<li>Generate the diff chunks for each file</li>
<li>Get the old and new versions of the files, highlight using pygments</li>
<li>Use custom pygments renderer to generate the diff context:
<ol>
<li>Using the original highlighted file lines which will have proper syntax highlighting colors</li>
<li>Support both unified/sideside without modification</li>
<li>Use a table that is copypaste friendly</li>
<li>Add inline comments + functionality </li>
<li>Expose load more file lines context functionality markers</li>
</ol></li>
<li>Render this in the template</li>
<li>Apply javascript events lazily to avoid the overheads of adding events to every single element</li>
</ol>
<p>This will also require an endpoint to get the partial N-M lines context of a file @ revision via ajax</p>
RhodeCode CE/EE - Task #4197 (New): [ce, ee] get list of users with their permissions to a reposi...https://issues.rhodecode.com/issues/41972016-08-24T14:31:24ZDaniel Ddaniel@rhodecode.com
<p>Related to <a href="https://issues.rhodecode.com/issues/4150" class="external">https://issues.rhodecode.com/issues/4150</a></p>
<p>Need a way to get all users from a repository along with their permissions for that repo.</p>
<p>At the moment permissions are generated via a complex python object in rhodecode.lib.auth:AuthUser which calculates the tree for a single user, taking into account default user, repo settings (overriding globals or not), and usergroups.</p>
<p>Iterating over the entire list of users is much too slow, some preliminary benchmarks show that it will take 10seconds / 100users.</p>
<p>In order to do this quickly instead, we would have to generate permissions via sql - A simplish (not completely correct results) query shows it will take about 50ms on internal rhodecode db.</p>
<pre><code>
SELECT
users.username,
repositories.repo_name,
MIN(origin_sort || '-' || permission_name) as perm
FROM (
SELECT
'' as ug,
permissions.permission_name,
user_id,
repository_id,
'1-user' as origin_sort
FROM
repo_to_perm
JOIN
permissions ON
permissions.permission_id = repo_to_perm.permission_id
-- WHERE repository_id = 190
UNION ALL
SELECT
users_groups.users_group_name,
permissions.permission_name,
users_groups_members.user_id,
repository_id,
'2-usergroup-' || users_groups.users_group_name as origin_sort
FROM
users_group_repo_to_perm
JOIN
permissions ON
permissions.permission_id = users_group_repo_to_perm.permission_id
JOIN
users_groups_members
ON
users_groups_members.users_group_id = users_group_repo_to_perm.users_group_id
JOIN
users_groups
ON
users_group_repo_to_perm.users_group_id = users_groups.users_group_id
-- WHERE repository_id = 190
) tmp_user_and_usergroup_perms
JOIN users ON users.user_id = tmp_user_and_usergroup_perms.user_id
JOIN repositories ON repositories.repo_id = tmp_user_and_usergroup_perms.repository_id
GROUP BY users.username, repositories.repo_name
ORDER BY username, perm
;
</code></pre> RhodeCode CE/EE - Task #4179 (New): [ce, ee] refine perms summary listhttps://issues.rhodecode.com/issues/41792016-08-17T02:16:51ZDaniel Ddaniel@rhodecode.com
<p>Sort by name, otherwise it's hard to find repos when list is large.</p>
RhodeCode CE/EE - Task #4120 (New): [ce] replace get_repo_nodes apihttps://issues.rhodecode.com/issues/41202016-07-24T20:55:21ZDaniel Ddaniel@rhodecode.com
<p>The current get_repo_nodes api loads the entire repo in one go, for a large repo (gbs) this will result in an output at least the size of the repo, which can cause memory issues, currently issue #4114 adds a max_file_bytes to work around this issue for the full text search indexer but a more long term solution is required:</p>
<p>Splitting get_repo_nodes into 2 actions, one to get the nodes, another to get node data should solve this, also since getting node content one by one would be slow it would be a good idea to allow batch node retrieval.</p>
<p>The methods required would go along the lines of:</p>
<pre><code>get_repo_nodes(repo_name, version, node_paths)
=>[
{'path': '/README', 'size': 434},
{'path': '.gitconfig', 'size': 53},
{'path': '/some/file', 'size': 5223},
{'path': '/another/file', 'size': 6433}
]
get_node_content('somerepo', 'tip', ['/README', '/some/file']) => contents of those 2 files only
</code></pre> RhodeCode CE/EE - Feature #4074 (New): Edit review commenthttps://issues.rhodecode.com/issues/40742016-07-06T16:50:33ZTamas Gemes
<p>Currently you can only create and delete your comments during a review.<br>
This is the same for in-code comments and global (commit or pull request) comments.</p>
<p>It would be nice to have an edit feature too.</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Feature #687 (New): [Integraton ]- Elastic search integrationhttps://issues.rhodecode.com/issues/6872015-01-12T11:07:47ZBrian Butlerbrian@rhodecode.comDocumentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>
Documentation - Feature #659 (New): Peer to Peer Failoverhttps://issues.rhodecode.com/issues/6592015-01-08T15:47:01ZBrian Butlerbrian@rhodecode.com
<p>doc this if we have</p>
Documentation - Feature #317 (New): Stylinghttps://issues.rhodecode.com/issues/3172014-11-12T09:44:42ZBrian Butlerbrian@rhodecode.com
<p>Create a Sphinx style for RhodeCode docs</p>