RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-12-02T10:36:16ZRhodeCode - issues
Redmine RhodeCode CE/EE - Feature #5643 (Resolved): jump to bottom of reviewhttps://issues.rhodecode.com/issues/56432020-12-02T10:36:16ZSebastian Elsner
<p>As a reviewer I often find myself with a large PR with many files changed, resulting in long PR pages. I scroll to the bottom, approve the PR. Something needs fixing, PR is updated, I reopen the page, approve scrolling down the PR page, PR may be updated, ....</p>
<p>A small improvement for this would be that you place a "Jump to bottom" link at the top. I know, I can press the "end" key on the keyboard, but my right hand is with the mouse and the left with the coffee mug ;)</p>
<p>Maybe like this:</p>
<p><img src="https://issues.rhodecode.com/attachments/download/3086/Selection_021.png" alt="" loading="lazy" /></p>
<p>From Phabricator code review I was used to have the "toolbar" for "Close" and "Merge" and "Add Comment" at the top AND at the bottom. That would be a solution too, but I guess way to over engineered for the problem.</p>
RhodeCode CE/EE - Bug #5612 (New): CPU cores getting maxed out by VCSServer on Repository Size re...https://issues.rhodecode.com/issues/56122020-04-08T18:57:58ZRenaud Lepage
<p>Please note that this happens on a RhodeCode CE instance, running the latest RhodeCode code, but running on a Virtual Private Server machine with fairly "restricted" specs (one virtual CPU, 2gb RAM). Weak by any metrics.</p>
<p>Condition: Using a freshly imported SVN repository that's not indexed or anything</p>
<p>Hitting "Show Repository Size" starts some kind of "runaway process", or possibly a "go through each commit in historical order", from the RhodeCode "Main Service" (community-1) to the VCS Server. This makes the two VCSServer workers max out the one virtual CPU my VPS instance has for some reason - likely because VCSServer does some big processing on each commit to get the size, but I can't be sure.</p>
<p>Setting prio to Low because I'm not a paying client.</p>
Documentation - Bug #5598 (New): Typo in force delete commandhttps://issues.rhodecode.com/issues/55982020-03-19T20:10:07ZJoseph Sible
<p>Running the command at the bottom of <a href="https://docs.rhodecode.com/RhodeCode-Enterprise/admin/repo_admin/repo-admin-tasks.html" class="external">https://docs.rhodecode.com/RhodeCode-Enterprise/admin/repo_admin/repo-admin-tasks.html</a> will fail with the message "No matching instances found to run the iShell." The problem is that it contains a typo: it uses "Enterprise-1" with an uppercase E instead of "enterprise-1" with a lowercase e.</p>
RhodeCode CE/EE - Bug #5575 (Resolved): Filtering username containing '-' does not work in Admin ...https://issues.rhodecode.com/issues/55752019-12-12T17:39:46ZBoris Basic
<p>Usernames containing '-' such as 'user-name' can't be filtered with the "usernale:" filter command.</p>
RhodeCode CE/EE - Bug #5558 (Resolved): Commit compare window covers texthttps://issues.rhodecode.com/issues/55582019-07-07T21:53:10ZCatalin Salgau
<p>Commit compare window covers text<br>
Seen on pre-pull-request commit or when hitting "compare origin on a fork repository" (and reaching this url, for example)<br>
<a href="https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1" class="external">https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1</a></p>
RhodeCode CE/EE - Bug #5522 (Resolved): vcsserver fails when url contains extra "/"https://issues.rhodecode.com/issues/55222018-12-23T14:18:27ZPaul Brand
<p>We use bitbake to build software for our products. Bitbake fetches the latest sourcecode from various repositories before it start to build software.<br>
Bitbake uses a receipes which tell bitbake what repository to use and how to build the url to access that repository.</p>
<p>Part of a receipe below:</p>
<pre><code>HGNAME = "repogroup/reponame"
SRC_URI = "hg://kvmech.kvernelandgroup.com/rhodecode/;protocol=http;scmdata=keep;module=${HGNAME}"
</code></pre>
<p>This would work with our previous rhodecode version (4.12.4)</p>
<p>Last week I updated to rhodecode 4.15 and the fetching of repositories did not work anymore. Bitbake reported:</p>
<pre><code>ERROR: Fetcher failure: Fetch command failed with exit code 255, output:
abort: HTTP Error 500: Internal Server Error
ERROR: Function failed: Fetcher failure for URL: 'hg://kvmech.kvernelandgroup.com/rhodecode/;protocol=http;scmdata=keep;module=repogroup/reponame'. Unable to fetch URL from any source.
</code></pre>
<p>The following error is from the vcssserver.log:</p>
<pre><code>2018-12-23 12:37:49.733 DEBUG [vcsserver.http_main] method called:localrepository with kwargs:{} context_uid: 7d80d0bf-d5c0-49a9-a104-3ef33f73fa5d
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] NeedRegenerationException
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] no value, waiting for create lock
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] value creation lock <dogpile.cache.region._LockWrapper object at 0x7f3b1f84bc10> acquired
2018-12-23 12:37:49.734 DEBUG [dogpile.lock] Calling creation function for not-yet-present value
2018-12-23 12:37:49.736 DEBUG [dogpile.lock] Released creation lock
2018-12-23 12:37:49.736 INFO [vcsserver.tweens] IP: 127.0.0.1 Request to path: `/hg` time: 0.003s
2018-12-23 12:37:49.755 DEBUG [vcsserver.http_main] http-app: handling hg stream
2018-12-23 12:37:49.755 DEBUG [vcsserver.scm_app] Creating Mercurial WSGI application
2018-12-23 12:37:49.757 DEBUG [vcsserver.scm_app] hgrc file is not present at /repos/repogroup/reponame/.hg/hgrc, skipping...
2018-12-23 12:37:49.759 DEBUG [vcsserver.http_main] http-app: starting app handler with <vcsserver.scm_app.HgWeb object at 0x7f3b1cdd70d0> and process request
2018-12-23 12:37:49.790 DEBUG [vcsserver.lib.exc_tracking] Stored generated exception 139891865038592 as: /tmp/rc_exception_store_v1/139891865038592_vcsserver_1545565069.767842
2018-12-23 12:37:49.791 ERROR [vcsserver.http_main] error occurred handling this request for path: //repogroup/reponame,
tb: Traceback (most recent call last):
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/tweens.py", line 39, in excview_tween
response = handler(request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/router.py", line 156, in handle_request
view_name
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/view.py", line 642, in _call_view
response = view_callable(context, request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/viewderivers.py", line 410, in viewresult_to_response
result = view(context, request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/wsgi.py", line 37, in decorator
return request.get_response(wrapped)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1327, in send
application, catch_exc_info=False)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
app_iter = application(self.environ, start_response)
File "/opt/rhodecode/store/hsq37yg96ril6xlifrvb030v290zbm6k-python2.7-rhodecode-vcsserver-4.15.0/lib/python2.7/site-packages/vcsserver/http_main.py", line 509, in _hg_stream
return app(environ, ResponseFilter(start_response))
File "/opt/rhodecode/store/hsq37yg96ril6xlifrvb030v290zbm6k-python2.7-rhodecode-vcsserver-4.15.0/lib/python2.7/site-packages/vcsserver/scm_app.py", line 77, in __call__
req = requestmod.parserequestfromenv(environ)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hgweb/request.py", line 260, in parserequestfromenv
reponame))
ProgrammingError: PATH_INFO does not begin with repo name: //repogroup/reponame (repogroup/reponame)
</code></pre>
<p>It seems like bitbake generates an url with an extra "/" > "//repogroup/reponame"</p>
<p>I removed the trailing "/" from the bitbake receipe and everythong worked fine again:</p>
<pre><code>HGNAME = "repogroup/reponame"
SRC_URI = "hg://kvmech.kvernelandgroup.com/rhodecode;protocol=http;scmdata=keep;module=${HGNAME}"
</code></pre>
<p>It looks like rhodecode became more strict with url formatting. <br>
The problem is resolved with the change to the bitbake receipe but the behaviour of rhodecode definitely changed between 4.12 and 4.15.<br>
And i think a 404 error would be more appropriate instead of a 500 server error.</p>
RhodeCode CE/EE - Bug #5460 (New): Repo creation stuck when remote clone returns partial http cod...https://issues.rhodecode.com/issues/54602018-04-10T15:45:27ZPeter Colledge
<p>UI stuck on 'Creating repository myrepo Repository "myrepo" is being created, you will be redirected when this process is finished.'</p>
<p>Steps to reproduce:</p>
<ol>
<li>Create a hg repo with open permissions except one file, eg. <code>.hg/store/data/foo.txt</code>, which hgweb service does not have access to. This will cause <code>getbundle</code> to fail.</li>
<li>Publish the repo with hgweb.</li>
<li>Create new repo in RhodeCode and 'Clone from:' the hgweb url.</li>
<li>Save. Observe stuck UI.</li>
<li>Observe hgweb <code>accesslog</code> returning http code 200 for <code>cmd=lookup</code>, <code>cmd=capabilities</code>, <code>cmd=listkeys</code>, etc, but 500 on <code>cmd=getbundle</code></li>
<li>Observe backend http exceptions, attached.</li>
</ol>
<p>Note: Celery feature enabled.</p>
Documentation - Bug #5439 (New): JIRA Integration description: Wrong sample linkhttps://issues.rhodecode.com/issues/54392018-02-14T14:25:34ZMalte Onnen
<p>The sample link described <a href="https://docs.rhodecode.com/RhodeCode-Enterprise/issue-trackers/issue-trackers.html#jira-integration" class="external">here</a> should rather be <br>
<a href="https://myissueserver.com/browse/${id}" class="external">https://myissueserver.com/browse/${id}</a><br>
than<br>
<a href="https://myissueserver.com/issue/${id}" class="external">https://myissueserver.com/issue/${id}</a></p>
RhodeCode Appenlight - Bug #5342 (New): Broken link [Applications Modify application]https://issues.rhodecode.com/issues/53422017-06-21T21:21:50ZBartłomiej Wołyńczyk
<p>Description:<br>
Link in applications setting is leading to main application page instead documentation.</p>
<p>"How to connect your application?<br>
Visit our developer documentation for step-by-step integration instructions."<br>
developer documentation ->> <a href="https://appenlight.rhodecode.com/" class="external">https://appenlight.rhodecode.com/</a><br>
instead ->> <a href="https://getappenlight.com/page/api/main.html" class="external">https://getappenlight.com/page/api/main.html</a> ??</p>
<p>Steps to reproduce:</p>
<ol>
<li>Go to Applications </li>
<li>Chosen Application -> Update</li>
<li>On Right Top there is link leading to developer documentation. </li>
</ol>
RhodeCode Appenlight - Feature #4220 (New): Search params allow sorting of result.https://issues.rhodecode.com/issues/42202016-09-06T16:33:29ZTomek Banasiak
<p>Hi,</p>
<p>Ability for sorting asc, desc by search result for example by avg duration, location etc would be cool.</p>
RhodeCode CE/EE - Bug #4155 (Resolved): Date of Last Change is not displayed correctlyhttps://issues.rhodecode.com/issues/41552016-08-07T11:17:09ZDmitry Konchalenkov [staff]dmitry@rhodecode.com
<p>Expected: <em>Last Change</em> should be the date of the latest commit. See screenshot.<br>
Actual: </p>
<ul>
<li>either <em>Last Change</em> doesn't use the date of the latest commit</li>
<li>or <em>Last Change</em> uses the time zone incorrectly</li>
</ul>
RhodeCode CE/EE - Bug #4154 (New): [ce, ee] user register via github captchahttps://issues.rhodecode.com/issues/41542016-08-05T22:51:47ZDaniel Ddaniel@rhodecode.com
<p>Found on code.rhodecode.com - sign up using github account - captcha is asked but not verified.</p>
RhodeCode CE/EE - Bug #4040 (New): [ce, ee] logout when logged out causes 403 Cross-site request ...https://issues.rhodecode.com/issues/40402016-06-22T21:09:03ZDaniel Ddaniel@rhodecode.com
<p>Reproduce:</p>
<ul>
<li>Login to rhodecode</li>
<li>Logout in another tab</li>
<li>Click logout in original tab</li>
</ul>
RhodeCode Appenlight - Feature #4017 (New): application logos need helphttps://issues.rhodecode.com/issues/40172016-06-14T11:52:12ZLisa Quatmannlisa@rhodecode.com
<p>see attached</p>
<p>surely we can make this prettier</p>
RhodeCode CE/EE - Bug #3615 (New): (OperationalError) too many SQL variables on admin journal pagehttps://issues.rhodecode.com/issues/36152016-05-06T11:44:17ZDaniel Ddaniel@rhodecode.com
<p>Steps to reproduce:</p>
<ul>
<li>use sqlite database</li>
<li>add over 1000 repos</li>
<li>open /_admin/journal</li>
</ul>
<p>OperationalError: (OperationalError) too many SQL variables u'SELECT count(*) AS count_1 \nFROM (SELECT user_logs.user_log_id AS user_logs_user_log_id, user_logs.user_id AS user_logs_user_id, user_logs.username AS user_logs_username, user_logs.repository_id AS user_logs_repository_id, user_logs.repository_name AS user_logs_repository_name, user_logs.user_ip AS user_logs_user_ip, user_logs.action AS user_logs_action, user_logs.action_date AS user_logs_action_date \nFROM user_logs \nWHERE user_logs.repository_id IN (?, ?, ?, ?, ?, ?, ?......) ORDER BY user_logs.action_date DESC) AS anon_1' (1,2,....1001 ids)</p>
<pre><code>File "/Users/dan/Projects/rc/rhodecode-enterprise-ce-dan/rhodecode/controllers/journal.py", line 262, in public_journal
c.journal_pager = Page(journal, page=p, items_per_page=20)
File "/nix/store/08jg8cv3mdsjdqa367b9gmilcmif46s3-python2.7-WebHelpers-1.3/lib/python2.7/site-packages/webhelpers/paginate.py", line 413, in __init__
self.item_count = len(self.collection)
</code></pre>
<p>The problem is in <code>rhodecode.controllers.journal.JournalController:_get_journal_data()</code></p>
<p>The query it generates has an IN which can fill up to the max limit for sqlite</p>
<p>Possible solutions:</p>
<ul>
<li>use a for loop</li>
<li>rewrite query to use joins instead</li>
</ul>
<p>Current workarounds:</p>
<ul>
<li>use mysql/postgresql</li>
</ul>