RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-03-31T17:04:34ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #5608 (Resolved): svn+ssh user set incorrectlyhttps://issues.rhodecode.com/issues/56082020-03-31T17:04:34ZLuke Mauldin
<p>Scenario:</p>
<ol>
<li>Create a repository <code>teststructure</code></li>
<li>Checkout the repository via svn+ssh</li>
<li>Add a file commit it</li>
<li>Edit the file and commit it</li>
</ol>
<p>Expected: the author of the SVN commit should be the user performing the commit. Actual: <code>rhodecode</code> is set as the author of the commit.<br>
If I checkout the repository using https + svn, then the author is set correctly in the commit.</p>
<p>See the below debugging information.</p>
<pre><code>vim trunk/foo/test_b.sql
svn commit -m "Updating file again"
2020-03-31 09:55:19.903 [71611] DEBUG [rhodecode.config.middleware] DEBUG MODE ON | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.903 [71611] DEBUG [rhodecode.config.middleware] Using the following Mako template directories: ['rhodecode:templates'] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.904 [71611] DEBUG [rhodecode.config.middleware] Using the following pyramid.includes: [] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.938 [71611] INFO [rhodecode.model] RhodeCode 4.18.2 initializing db for postgresql://rhodecode:XXXXX@127.0.0.1:5432/rhodecode | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.939 [71611] INFO [rhodecode.config.environment] Enabled VCS backends: ['svn', 'git'] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.942 [71611] DEBUG [rhodecode.config.middleware] Initializing main includeme from middleware.pyc | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.967 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: found following cache regions: set(['cache_perms', 'cache_repo_longterm', 'sql_cache_short', 'cache_license', 'cache_repo']) | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.971 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: registering a new region cache_perms[{'async_creation_runner': None, 'name': 'cache_perms', 'function_key_generator': <function wrapper at 0x7fbe2f4678c0>, 'region_invalidator': <dogpile.cache.region.DefaultInvalidationStrategy object at 0x7fbe2f4542d0>, '_actual_backend': <rhodecode.lib.rc_cache.backends.RedisPickleBackend object at 0x7fbe2f454f10>, 'function_multi_key_generator': <function function_multi_key_generator at 0x7fbe39988de8>, '_lock_registry': <dogpile.util.nameregistry.NameRegistry object at 0x7fbe3a788c50>, 'key_mangler': None, 'expiration_time': 300, '_user_defined_key_mangler': None, 'backend': <rhodecode.lib.rc_cache.backends.RedisPickleBackend object at 0x7fbe2f454f10>}] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.971 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: registering a new region cache_repo_longterm[{'async_creation_runner': None, 'name': 'cache_repo_longterm', 'function_key_generator': <function wrapper at 0x7fbe2f46e6e0>, 'region_invalidator': <dogpile.cache.region.DefaultInvalidationStrategy object at 0x7fbe3a788d50>, '_actual_backend': <rhodecode.lib.rc_cache.backends.LRUMemoryBackend object at 0x7fbe3a788e50>, 'function_multi_key_generator': <function function_multi_key_generator at 0x7fbe39988de8>, '_lock_registry': <dogpile.util.nameregistry.NameRegistry object at 0x7fbe2f470110>, 'key_mangler': None, 'expiration_time': 2592000, '_user_defined_key_mangler': None, 'backend': <rhodecode.lib.rc_cache.backends.LRUMemoryBackend object at 0x7fbe3a788e50>}] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.972 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: registering a new region sql_cache_short[{'async_creation_runner': None, 'name': 'sql_cache_short', 'function_key_generator': <function wrapper at 0x7fbe2f46e7d0>, 'region_invalidator': <dogpile.cache.region.DefaultInvalidationStrategy object at 0x7fbe2f4701d0>, '_actual_backend': <rhodecode.lib.rc_cache.backends.LRUMemoryBackend object at 0x7fbe2f470210>, 'function_multi_key_generator': <function function_multi_key_generator at 0x7fbe39988de8>, '_lock_registry': <dogpile.util.nameregistry.NameRegistry object at 0x7fbe2f4702d0>, 'key_mangler': None, 'expiration_time': 30, '_user_defined_key_mangler': None, 'backend': <rhodecode.lib.rc_cache.backends.LRUMemoryBackend object at 0x7fbe2f470210>}] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.972 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: registering a new region cache_license[{'async_creation_runner': None, 'name': 'cache_license', 'function_key_generator': <function wrapper at 0x7fbe2f46e938>, 'region_invalidator': <dogpile.cache.region.DefaultInvalidationStrategy object at 0x7fbe2f470350>, '_actual_backend': <class 'rhodecode.lib.rc_cache.backends.FileNamespaceBackend'> `/home/rhodecode/.rccontrol/community-1/data/rc_cache_3`, 'function_multi_key_generator': <function function_multi_key_generator at 0x7fbe39988de8>, '_lock_registry': <dogpile.util.nameregistry.NameRegistry object at 0x7fbe2f470490>, 'key_mangler': None, 'expiration_time': 300, '_user_defined_key_mangler': None, 'backend': <class 'rhodecode.lib.rc_cache.backends.FileNamespaceBackend'> `/home/rhodecode/.rccontrol/community-1/data/rc_cache_3`}] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:19.973 [71611] DEBUG [rhodecode.lib.rc_cache] dogpile: registering a new region cache_repo[{'async_creation_runner': None, 'name': 'cache_repo', 'function_key_generator': <function wrapper at 0x7fbe2f46ea28>, 'region_invalidator': <dogpile.cache.region.DefaultInvalidationStrategy object at 0x7fbe2f470510>, '_actual_backend': <rhodecode.lib.rc_cache.backends.RedisPickleBackend object at 0x7fbe2f4705d0>, 'function_multi_key_generator': <function function_multi_key_generator at 0x7fbe39988de8>, '_lock_registry': <dogpile.util.nameregistry.NameRegistry object at 0x7fbe2f470550>, 'key_mangler': None, 'expiration_time': 2592000, '_user_defined_key_mangler': None, 'backend': <rhodecode.lib.rc_cache.backends.RedisPickleBackend object at 0x7fbe2f4705d0>}] | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:20.145 [71611] INFO [celery.rhodecode.loader] Configuring celery based on `/home/rhodecode/.rccontrol/community-1/rhodecode.ini` file | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:20.151 [71611] DEBUG [celery.rhodecode.loader] Got custom celery conf: {u'task_always_eager': False, u'broker_url': u'redis://localhost:6379/8', u'max_tasks_per_child': 100} | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:20.151 [71611] INFO [rhodecode.config.middleware] Pyramid app `pyramid_app_with_cleanup` created and configured in 0.25s | req_id:00000000-0000-0000-0000-000000000000
2020-03-31 09:55:20.156 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends] Mode: `auto` User: `mauldinl:5` Shell: `False` SSH Command: `"svnserve -t"` SCM_DETECTED: `svn` SCM Mode: `auto` SCM Repo: `None` | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.379 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends] Update key id:`2` fingerprint:`MD5:9e:12:51:5d:00:36:87:79:56:0f:6e:c0:52:1a:0b:8e` access time | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.379 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends] SSH Connection info {'client_port': '50004', 'client_ip': '138.254.18.106', 'server_ip': '138.254.135.35', 'server_port': '22'} | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.381 [71611] DEBUG [rhodecode.lib.auth] AuthUser: starting data propagation for new potential user | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.384 [71611] DEBUG [rhodecode.lib.auth] Trying Auth User lookup by USER ID: `5` | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.384 [71611] DEBUG [rhodecode.model.user] AuthUser: fill data execution based on: user_id:5 api_key:None username:None | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.385 [71611] DEBUG [rhodecode.model.user] AuthUser: filling found user:<User('id:5:mauldinl')> data | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.391 [71611] DEBUG [rhodecode.lib.auth] AuthUser: propagated user is now <AuthUser('id:5[mauldinl] ip:None auth:False')> | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.391 [71611] DEBUG [rhodecode.lib.auth] Computing PERMISSION tree for user <AuthUser('id:5[mauldinl] ip:None auth:False')> scope `None` with caching: True[TTL: 300s] | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.395 [71611] DEBUG [rhodecode.lib.auth] PERMISSION tree for user <AuthUser('id:5[mauldinl] ip:None auth:False')> computed in 0.0035s: [('repositories', 545), ('repositories_groups', 18), ('global', 2), ('repository_branches', 0), ('user_groups', 5)] | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.406 [71611] DEBUG [rhodecode.lib.auth] Computing PERMISSION tree for user <AuthUser('id:5[mauldinl] ip:None auth:False')> scope `OrderedDict([('repo_id', -1), ('user_group_id', -1), ('repo_group_id', -1), ('repo_name', None)])` with caching: True[TTL: 300s] | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.407 [71611] DEBUG [rhodecode.lib.auth] PERMISSION tree for user <AuthUser('id:5[mauldinl] ip:None auth:False')> computed in 0.0003s: [('repositories', 0), ('global', 2), ('repository_branches', 0), ('repositories_groups', 0), ('user_groups', 0)] | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.409 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends] VCS detected:`svn` mode: `auto` repo_name: None, branch_permission_checks:False | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.409 [71611] DEBUG [rhodecode.lib.hooks_daemon] Preparing HTTP callback daemon at `127.0.0.1:37319` and registering hook object | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.409 [71611] DEBUG [rhodecode.lib.hooks_daemon] Prepared a callback daemon: HttpHooksCallbackDaemon at url `127.0.0.1:37319` | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.409 [71611] DEBUG [rhodecode.lib.hooks_daemon] Running `HttpHooksCallbackDaemon` callback daemon | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.409 [71611] DEBUG [rhodecode.lib.hooks_daemon] Running event loop of callback daemon in background thread | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.410 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends.svn] Using svn binaries from path ~/.rccontrol/vcsserver-1/profile/bin/svnserve | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.410 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends.svn] Final CMD: ~/.rccontrol/vcsserver-1/profile/bin/svnserve -t --config-file /tmp/tmpSpzroh -r /srv/rhodecode/repos/ | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
svnserve: warning: cannot set LC_CTYPE locale
svnserve: warning: environment variable LANG is en_US.UTF-8
svnserve: warning: please check that your locale name is correct
2020-03-31 09:55:20.605 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends.svn] Extracting repository name from subdir path playground/teststructure/trunk/foo | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.606 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends.svn] Found prefix playground/teststructure/ match, returning proper repository name | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.606 [71611] DEBUG [rhodecode.apps.ssh_support.lib.backends.base] permission for <User('id:5:mauldinl')> on playground/teststructure are: repository.admin | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
2020-03-31 09:55:20.606 [71611] INFO [rhodecode.apps.ssh_support.lib.backends.base] READ Permissions for User "<User('id:5:mauldinl')>" detected to repo "playground/teststructure"! | req_id:19beac90-52d8-4d06-8981-7bcfa54e68e6
Sending trunk/foo/test_b.sql
Transmitting file data .done
Committing transaction...
Committed revision 19.
</code></pre>
<p>See the svn log output:</p>
<pre><code>svn log -l 3
svnserve: warning: cannot set LC_CTYPE locale
svnserve: warning: environment variable LANG is en_US.UTF-8
svnserve: warning: please check that your locale name is correct
------------------------------------------------------------------------
r17 | rhodecode | 2020-03-31 09:01:50 -0500 (Tue, 31 Mar 2020) | 1 line
Move file
------------------------------------------------------------------------
r16 | mauldinl | 2020-03-19 09:42:40 -0500 (Thu, 19 Mar 2020) | 1 line
Moving file
------------------------------------------------------------------------
r15 | mauldinl | 2020-03-19 09:39:38 -0500 (Thu, 19 Mar 2020) | 1 line
</code></pre>
<p>Revision 17 was commited via svn+ssh (incorrect author), but revisions 15 and 16 were commited via svn+https (which has the correct author).</p>
<p>Rhodecode version: 4.18.2</p>
RhodeCode CE/EE - Bug #5604 (Resolved): Search error on second result pagehttps://issues.rhodecode.com/issues/56042020-03-27T19:55:33ZLuke Mauldin
<p>Encountered error when using a smultiple search terms and navigating to the second page.<br><br>
Scenario:</p>
<ol>
<li>Search for: FromError AND extension:go --- the url generated is: httpsXXXXcom/_admin/search?q=FromError+AND+extension%3Ago&type=content&max_lines</li>
<li>Navigate to the second page of the results. =10The search query is changed in the search box to be: FromError%20AND%20extension%3Ago and the generated url is: httpsXXXXXcom/_admin/search?q=FromError%2520AND%2520extension%253Ago&max_lines=10&sort=desc%3Adate&type=content&pag</li>
</ol>
<p>It looks like the application is trying to encode the spaces in the URL but it is not working as expected.e=2</p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Bug #4268 (Resolved): [ee] default reviewers from changed lines is returning wr...https://issues.rhodecode.com/issues/42682016-10-06T14:18:07ZDaniel Ddaniel@rhodecode.com
<p>When getting default reviewers from authors of changed lines, not all the hunks are being processed, just the first one, meaning the changed lines are wrong (too low)</p>
RhodeCode CE/EE - Bug #4233 (Resolved): slack, git push problemhttps://issues.rhodecode.com/issues/42332016-09-19T13:24:56ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>got this while pushing to the website project:</p>
<pre><code>2016-09-19 10:52:04.619 CRITI [rhodecode.integrations.types.slack] {'author': u'Marcin Kuzminski <marcin@rhodecode.com>', 'branch': None, 'mentions': [], 'issues': [], 'url': 'https://internal-code.rhodecode.com/rhodecode-website/changeset/50586183192a283ea3dfbb2347174ec67a70574e', 'date': datetime.datetime(2016, 9, 19, 10, 51, 5), 'raw_id': '50586183192a283ea3dfbb2347174ec67a70574e', 'revision': 1879, 'short_id': '50586183192a', 'message_html': literal(u'settings: updated with latest changes\n'), 'reviewers': [], 'parents': [{'raw_id': 'ab5b2b1ad9c3058f374aba0434f71f987eaee3b7'}], 'message': u'settings: updated with latest changes\n'}
2016-09-19 10:52:04.619 ERROR [rhodecode.integrations] failure occured when sending event <rhodecode.events.repo.RepoPushEvent object at 0x7f8d29d05410> to integration <Integration(u'slack', 'root_repos')>
Traceback (most recent call last):
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/__init__.py", line 54, in integrations_event_handler
integration_model.send_event(integration, event)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/model/integration.py", line 108, in send_event
handler.send_event(event)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/types/slack.py", line 139, in send_event
text = self.format_repo_push_event(data)
File "/nix/store/xa9k1grs480djz8cq6778cq828x3d6xs-python2.7-rhodecode-enterprise-ce-4.5.0+20160919x085905xb55b9717656ax48ec43f7e442/lib/python2.7/site-packages/rhodecode/integrations/types/slack.py", line 227, in format_repo_push_event
branch_commits = {'branch': branch_data[commit['branch']],
KeyError: None
</code></pre> RhodeCode CE/EE - Bug #4223 (Resolved): [git, tags] annotated tags not appearing in UIhttps://issues.rhodecode.com/issues/42232016-09-09T11:51:31ZLisa Quatmannlisa@rhodecode.com
<p>When I have an annotated tag in a git repo, and I push this tag, I do not see it listed in the changelog, the repo summary, the repo tag summary, or the commit detail page.</p>
<p>As reported in the community slack: <a href="https://rhodecode-community.slack.com/archives/general/p1473412004000013" class="external">https://rhodecode-community.slack.com/archives/general/p1473412004000013</a></p>
RhodeCode CE/EE - Bug #4173 (Resolved): [ce, ee] mysql recycle pool timeout not workinghttps://issues.rhodecode.com/issues/41732016-08-12T16:41:27ZDaniel Ddaniel@rhodecode.com
<p>Replication:</p>
<ul>
<li>new config using mysql database</li>
<li>set mysql's wait_timeout to 6</li>
<li><code>threads = 1</code> in ini</li>
<li><code>sqlalchemy.db1.pool_recycle = 3</code> in ini</li>
<li>git push a repo (no changes need, just a push)</li>
<li>wait 7 seconds</li>
<li>git push again</li>
<li>get - <code>OperationalError: (OperationalError) (2006, 'MySQL server has gone away)</code></li>
</ul>
<p>This will also break subsequent requests with <code>StatementError: Can't reconnect until invalid transaction is rolled back</code></p>
RhodeCode CE/EE - Feature #4074 (New): Edit review commenthttps://issues.rhodecode.com/issues/40742016-07-06T16:50:33ZTamas Gemes
<p>Currently you can only create and delete your comments during a review.<br>
This is the same for in-code comments and global (commit or pull request) comments.</p>
<p>It would be nice to have an edit feature too.</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Feature #687 (New): [Integraton ]- Elastic search integrationhttps://issues.rhodecode.com/issues/6872015-01-12T11:07:47ZBrian Butlerbrian@rhodecode.comDocumentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>
Documentation - Feature #659 (New): Peer to Peer Failoverhttps://issues.rhodecode.com/issues/6592015-01-08T15:47:01ZBrian Butlerbrian@rhodecode.com
<p>doc this if we have</p>
Documentation - Feature #317 (New): Stylinghttps://issues.rhodecode.com/issues/3172014-11-12T09:44:42ZBrian Butlerbrian@rhodecode.com
<p>Create a Sphinx style for RhodeCode docs</p>