RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042017-12-02T16:04:42ZRhodeCode - issues
Redmine Documentation - Task #5408 (Resolved): Upate nginx documentation for non standard SSL porthttps://issues.rhodecode.com/issues/54082017-12-02T16:04:42ZMaurice Müller
<p>I'm currently in an evaluation process for rhodecode. During my test setup it give me a headache that the given nginx example was not working fully in my set up (login and logout were getting a timeout although the user was logged in / out).</p>
<p>After a long search I figured out that the non standard SSL port was the issue. This can easily be fixed by replacng the following in the proxy.conf file (<a href="https://docs.rhodecode.com/RhodeCode-Enterprise/admin/nginx-tuning.html" class="external">https://docs.rhodecode.com/RhodeCode-Enterprise/admin/nginx-tuning.html</a>) :</p>
<p>replace:<br>
proxy_set_header Host $host;<br>
with:<br>
proxy_set_header Host $host:$server_port;</p>
<p>I hope this helps some other guys in the future ;)</p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Task #4311 (Resolved): Diffs feedbackhttps://issues.rhodecode.com/issues/43112016-11-24T15:48:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Below some feedback items that i made</p>
RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Task #4288 (Resolved): [ce, ee] unify controllers that use diffshttps://issues.rhodecode.com/issues/42882016-10-19T08:19:57ZDaniel Ddaniel@rhodecode.com
<p>Currently diffs are being used in these controllers:</p>
<ol>
<li>files controller: eg <code>/repo/diff/somefile?diff1=commit1&diff2=commit2</code></li>
<li>compare controller: eg. <code>/repo/compare/tag@v4.2.1...tag@v4.2.0</code></li>
<li>changeset controller: eg. <code>/repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f</code></li>
<li>pullrequest controller: eg. <code>/repo/pull-request/332</code></li>
</ol>
<p>These controllers use about 80% duplicate code which can be moved to a common base</p>
<p>Also some controller have options such as increase/decrease context which are not implemented in other controllers.</p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Task #4246 (New): [ce, ee, vcs, git] add tests for annotated git tagshttps://issues.rhodecode.com/issues/42462016-09-27T15:46:51ZDaniel Ddaniel@rhodecode.com
<p>Need to add a test that makes sure annotated git tags are correctly dereferenced / peeled to the actual commit they point to.</p>
RhodeCode CE/EE - Task #4238 (Resolved): default reviewers updateshttps://issues.rhodecode.com/issues/42382016-09-22T12:45:15ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Some of my notes</p>
<ul>
<li>it would be good to SAVE the reasons for a reviewer, so it's clear to outsiders which roles other members have. It's good to know "WHO" is the author, who is form the team etc</li>
<li>it'd be good to have "exclude" author option so it's not a possibility that author gets picked to review his own PR</li>
</ul>
RhodeCode CE/EE - Task #4202 (Resolved): Polish the 503.html pagehttps://issues.rhodecode.com/issues/42022016-08-29T16:56:27ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>We have a custom page for NGINX if RhodeCode is down, under: <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html</a></p>
<p>It is shown via such NGINX entry:</p>
<pre><code> ## custom 502 error page
error_page 502 /502.html;
location = /502.html {
root /path/to/.rccontrol/enterprise-1/static;
}
</code></pre>
<p>It looks very ugly, we should make it look nice and have some more usefull information.</p>
<p>We CANNOT use any variables, images etc. It needs to be PURE html (similar to email templates) but without variables.</p>
RhodeCode Appenlight - Task #4052 (New): release fixeshttps://issues.rhodecode.com/issues/40522016-06-29T12:14:24ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Items i found:</p>
<p>1) fill/remove inside setup.py the</p>
<pre><code> author='',
author_email='',
url='',
</code></pre>
<p>Similar to how it's in CE/EE</p>
<p>This is nothing urgent</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Task #737 (New): What is an extra field and how do you add it?https://issues.rhodecode.com/issues/7372015-01-14T13:57:54ZLisa Quatmannlisa@rhodecode.com
<p>Ok, I know the answer to the first part but regular users may not. If you don't have any extra fields, then when you go to the page where you would edit them, you get a message which says "Extra fields are disabled". However, it has no information on how to enable them if one is able to do that.</p>
Documentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>