RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-12-02T10:36:16ZRhodeCode - issues
Redmine RhodeCode CE/EE - Feature #5643 (Resolved): jump to bottom of reviewhttps://issues.rhodecode.com/issues/56432020-12-02T10:36:16ZSebastian Elsner
<p>As a reviewer I often find myself with a large PR with many files changed, resulting in long PR pages. I scroll to the bottom, approve the PR. Something needs fixing, PR is updated, I reopen the page, approve scrolling down the PR page, PR may be updated, ....</p>
<p>A small improvement for this would be that you place a "Jump to bottom" link at the top. I know, I can press the "end" key on the keyboard, but my right hand is with the mouse and the left with the coffee mug ;)</p>
<p>Maybe like this:</p>
<p><img src="https://issues.rhodecode.com/attachments/download/3086/Selection_021.png" alt="" loading="lazy" /></p>
<p>From Phabricator code review I was used to have the "toolbar" for "Close" and "Merge" and "Add Comment" at the top AND at the bottom. That would be a solution too, but I guess way to over engineered for the problem.</p>
RhodeCode CE/EE - Bug #5575 (Resolved): Filtering username containing '-' does not work in Admin ...https://issues.rhodecode.com/issues/55752019-12-12T17:39:46ZBoris Basic
<p>Usernames containing '-' such as 'user-name' can't be filtered with the "usernale:" filter command.</p>
RhodeCode CE/EE - Bug #5558 (Resolved): Commit compare window covers texthttps://issues.rhodecode.com/issues/55582019-07-07T21:53:10ZCatalin Salgau
<p>Commit compare window covers text<br>
Seen on pre-pull-request commit or when hitting "compare origin on a fork repository" (and reaching this url, for example)<br>
<a href="https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1" class="external">https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1</a></p>
RhodeCode CE/EE - Feature #5536 (Resolved): Ability to disable server-side SSH key generationhttps://issues.rhodecode.com/issues/55362019-02-11T19:42:50ZCatalin Salgau
<p>Generating a private/public SSH key pair may be user-friendly, but shipping this from the server can pose security concerns.<br>
Please add a way to disable key generation and/or provide client client-side key generation(Web Crypto APIs are available in most modern browsers)<br>
Thanks</p>
RhodeCode CE/EE - Bug #5522 (Resolved): vcsserver fails when url contains extra "/"https://issues.rhodecode.com/issues/55222018-12-23T14:18:27ZPaul Brand
<p>We use bitbake to build software for our products. Bitbake fetches the latest sourcecode from various repositories before it start to build software.<br>
Bitbake uses a receipes which tell bitbake what repository to use and how to build the url to access that repository.</p>
<p>Part of a receipe below:</p>
<pre><code>HGNAME = "repogroup/reponame"
SRC_URI = "hg://kvmech.kvernelandgroup.com/rhodecode/;protocol=http;scmdata=keep;module=${HGNAME}"
</code></pre>
<p>This would work with our previous rhodecode version (4.12.4)</p>
<p>Last week I updated to rhodecode 4.15 and the fetching of repositories did not work anymore. Bitbake reported:</p>
<pre><code>ERROR: Fetcher failure: Fetch command failed with exit code 255, output:
abort: HTTP Error 500: Internal Server Error
ERROR: Function failed: Fetcher failure for URL: 'hg://kvmech.kvernelandgroup.com/rhodecode/;protocol=http;scmdata=keep;module=repogroup/reponame'. Unable to fetch URL from any source.
</code></pre>
<p>The following error is from the vcssserver.log:</p>
<pre><code>2018-12-23 12:37:49.733 DEBUG [vcsserver.http_main] method called:localrepository with kwargs:{} context_uid: 7d80d0bf-d5c0-49a9-a104-3ef33f73fa5d
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] NeedRegenerationException
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] no value, waiting for create lock
2018-12-23 12:37:49.733 DEBUG [dogpile.lock] value creation lock <dogpile.cache.region._LockWrapper object at 0x7f3b1f84bc10> acquired
2018-12-23 12:37:49.734 DEBUG [dogpile.lock] Calling creation function for not-yet-present value
2018-12-23 12:37:49.736 DEBUG [dogpile.lock] Released creation lock
2018-12-23 12:37:49.736 INFO [vcsserver.tweens] IP: 127.0.0.1 Request to path: `/hg` time: 0.003s
2018-12-23 12:37:49.755 DEBUG [vcsserver.http_main] http-app: handling hg stream
2018-12-23 12:37:49.755 DEBUG [vcsserver.scm_app] Creating Mercurial WSGI application
2018-12-23 12:37:49.757 DEBUG [vcsserver.scm_app] hgrc file is not present at /repos/repogroup/reponame/.hg/hgrc, skipping...
2018-12-23 12:37:49.759 DEBUG [vcsserver.http_main] http-app: starting app handler with <vcsserver.scm_app.HgWeb object at 0x7f3b1cdd70d0> and process request
2018-12-23 12:37:49.790 DEBUG [vcsserver.lib.exc_tracking] Stored generated exception 139891865038592 as: /tmp/rc_exception_store_v1/139891865038592_vcsserver_1545565069.767842
2018-12-23 12:37:49.791 ERROR [vcsserver.http_main] error occurred handling this request for path: //repogroup/reponame,
tb: Traceback (most recent call last):
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/tweens.py", line 39, in excview_tween
response = handler(request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/router.py", line 156, in handle_request
view_name
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/view.py", line 642, in _call_view
response = view_callable(context, request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/viewderivers.py", line 410, in viewresult_to_response
result = view(context, request)
File "/opt/rhodecode/store/mcjhzq84p171b42cwjlszbz8611ir1b8-python2.7-pyramid-1.9.2/lib/python2.7/site-packages/pyramid/wsgi.py", line 37, in decorator
return request.get_response(wrapped)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1327, in send
application, catch_exc_info=False)
File "/opt/rhodecode/store/rwjyfikqcf3lbm6gppji4q36fdh83dll-python2.7-webob-1.7.4/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
app_iter = application(self.environ, start_response)
File "/opt/rhodecode/store/hsq37yg96ril6xlifrvb030v290zbm6k-python2.7-rhodecode-vcsserver-4.15.0/lib/python2.7/site-packages/vcsserver/http_main.py", line 509, in _hg_stream
return app(environ, ResponseFilter(start_response))
File "/opt/rhodecode/store/hsq37yg96ril6xlifrvb030v290zbm6k-python2.7-rhodecode-vcsserver-4.15.0/lib/python2.7/site-packages/vcsserver/scm_app.py", line 77, in __call__
req = requestmod.parserequestfromenv(environ)
File "/opt/rhodecode/store/bhipby53csk71p07gsmi6q3p89qn6am3-python2.7-mercurial-4.6.2/lib/python2.7/site-packages/mercurial/hgweb/request.py", line 260, in parserequestfromenv
reponame))
ProgrammingError: PATH_INFO does not begin with repo name: //repogroup/reponame (repogroup/reponame)
</code></pre>
<p>It seems like bitbake generates an url with an extra "/" > "//repogroup/reponame"</p>
<p>I removed the trailing "/" from the bitbake receipe and everythong worked fine again:</p>
<pre><code>HGNAME = "repogroup/reponame"
SRC_URI = "hg://kvmech.kvernelandgroup.com/rhodecode;protocol=http;scmdata=keep;module=${HGNAME}"
</code></pre>
<p>It looks like rhodecode became more strict with url formatting. <br>
The problem is resolved with the change to the bitbake receipe but the behaviour of rhodecode definitely changed between 4.12 and 4.15.<br>
And i think a 404 error would be more appropriate instead of a 500 server error.</p>
RhodeCode CE/EE - Feature #5442 (Resolved): Preview of Jupyter notebookshttps://issues.rhodecode.com/issues/54422018-02-25T11:40:15ZBrahim Djoudi
<p>Both Github and Gitlab have preview capability for Jupyter notebooks (<a href="https://nbformat.readthedocs.io/en/latest/" class="external">https://nbformat.readthedocs.io/en/latest/</a>) that mix Python code (or other language), Markdown cells and plain text fields.<br>
Rhodecode CE or EE should offer a similar feature.</p>
<p>Regards.</p>
Documentation - Support #5423 (Resolved): API-Documentation for Method "create_repo_group" faultyhttps://issues.rhodecode.com/issues/54232018-01-22T13:39:57ZMalte Onnen
<p>Adding the group_description does not work as described in the Docs.</p>
<p>Api-Call from PowerShell:<br>
<code>Invoke-WebRequest https://rhodecode-url/_admin/api -Method Post -Body {"args":{"description":"testDescriptionWithoutBlanks","owner":2,"group_name":"testgrp"},"method":"create_repo_group","auth_token":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","id":1}</code><br>
I also tried: <br>
<code>Invoke-WebRequest https://rhodecode-url/_admin/api -Method Post -Body {"args":{"group_description":"testDescriptionWithoutBlanks","owner":2,"group_name":"testgrp"},"method":"create_repo_group","auth_token":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","id":1}</code></p>
<p>Expected Result: <br>
<code>}<br>
"id": 1,<br>
"result": {<br>
"repo_group": {<br>
"parent_group": null,<br>
"group_name": "testgrp",<br>
"group_description": "testDescriptionWithoutBlanks",<br>
"group_id": 12,<br>
"owner": "SUPERADMIN-USER",<br>
"repositories": []<br>
},<br>
"msg": "Created new repo group</code>testgrp<code>"<br>
},<br>
"error": null<br>
}</code></p>
<p>Actual Result:<br>
<code>{<br>
"id": 1,<br>
"result": {<br>
"repo_group": {<br>
"parent_group": null,<br>
"group_name": "testgrp",<br>
"group_description": "testgrp",<br>
"group_id": 12,<br>
"owner": "SUPERADMIN-USER",<br>
"repositories": []<br>
},<br>
"msg": "Created new repo group</code>testgrp<code>"<br>
},<br>
"error": null<br>
}<br>
</code></p>
Documentation - Task #5408 (Resolved): Upate nginx documentation for non standard SSL porthttps://issues.rhodecode.com/issues/54082017-12-02T16:04:42ZMaurice Müller
<p>I'm currently in an evaluation process for rhodecode. During my test setup it give me a headache that the given nginx example was not working fully in my set up (login and logout were getting a timeout although the user was logged in / out).</p>
<p>After a long search I figured out that the non standard SSL port was the issue. This can easily be fixed by replacng the following in the proxy.conf file (<a href="https://docs.rhodecode.com/RhodeCode-Enterprise/admin/nginx-tuning.html" class="external">https://docs.rhodecode.com/RhodeCode-Enterprise/admin/nginx-tuning.html</a>) :</p>
<p>replace:<br>
proxy_set_header Host $host;<br>
with:<br>
proxy_set_header Host $host:$server_port;</p>
<p>I hope this helps some other guys in the future ;)</p>
RhodeCode CE/EE - Task #5207 (Resolved): Release 4.6.1https://issues.rhodecode.com/issues/52072017-02-10T13:09:33ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Prep tasks for 4.6.1 release</p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Task #4251 (Feedback): [customer] Pull request with subreposhttps://issues.rhodecode.com/issues/42512016-09-29T13:41:00ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>While a lot of time passed since we’ve exchanged emails last time, let me share some details about the way we work at R and what kind of Rhodecode improvements would be useful for us. </p>
<ul>
<li>Most of our iOS/Mac product repositories are Mercurial </li>
<li>We extensively use Mercurial’s subrepositories for internal dependencies: our internal libraries are Mercurial or git repositories, which are added to product repository as a subrepo. </li>
<li>I like github flow: creating feature branches (bookmarks in Mercurial), opening pull request to master (default), code-reviewing this pull request and merging it after review is finished</li>
</ul>
<p>Unfortunately Rhodecode does not allow to create pull request for Mercurial repository in case it contains any subrepo, even if there were no changes in that sub-repositories. </p>
<p>So that’s the main reason why we can’t use github flow with Rhodecode and that’s the reason why we have to Crucible. </p>
<p>I’ve shared these details with team about a year ago : <a href="https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request" class="external">https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request</a></p>
<p>Currently Rhodecode is more like a repository storage for us and while post-commit reviews are possible they are rarely used. That’s why most people at R almost never see Rhodecode web interface. </p>
<p>Let me know if you need any more details or have any workaround that would still allow us to use pull requests. </p>
RhodeCode CE/EE - Bug #4155 (Resolved): Date of Last Change is not displayed correctlyhttps://issues.rhodecode.com/issues/41552016-08-07T11:17:09ZDmitry Konchalenkov [staff]dmitry@rhodecode.com
<p>Expected: <em>Last Change</em> should be the date of the latest commit. See screenshot.<br>
Actual: </p>
<ul>
<li>either <em>Last Change</em> doesn't use the date of the latest commit</li>
<li>or <em>Last Change</em> uses the time zone incorrectly</li>
</ul>
RhodeCode CE/EE - Bug #4092 (Feedback): [ce, ee] Redmine/JIRA integrations - smart commitshttps://issues.rhodecode.com/issues/40922016-07-15T12:29:44ZDaniel Ddaniel@rhodecode.com
<p>For the redmine case there are 5 states for a ticket:</p>
<ul>
<li>new</li>
<li>in progress</li>
<li>resolved</li>
<li>feedback</li>
<li>closed'</li>
</ul>
<p>Commit messages should be able to auto close/resolve tickets using keywords such as <code>fixes #42</code></p>
<p>The thing to think about is that the user may want 'fixes #20' to set the redmine issue to any of 'resolved', 'feedback' or 'closed' - this should be set in the integration options.</p>
<p>Allowing custom multiple regex => state mappers per integration is the most powerful but might be overkill- making standard keywords might be better eg:</p>
<p>fixes => resolved<br>
closes => closed</p>
<p>Then again this might be no good for international users.</p>
RhodeCode CE/EE - Task #3454 (Feedback): [ce/ee] visually differentiate the two editionshttps://issues.rhodecode.com/issues/34542016-04-07T15:38:27ZOliver Strobeloliver@rhodecode.com
<p>Currently we are only changing the footer to include Community vs. Enterprise differentiation.</p>
<p>Purpose: It should be possible to tell the difference in edition quickly when switching between CE/EE tabs.</p>
<p>Potential solutions:<br>
1) Add the edition name into the header after the logo on the top left<br>
2) Change the colour of the header between editions, eg.<br>
CE = dark grey<br>
EE = black</p>
<p>Thoughts?</p>
RhodeCode CE/EE - Feature #2539 (Feedback): Recursive deletion of resourceshttps://issues.rhodecode.com/issues/25392015-08-25T18:11:48ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Ticket from support: <a href="https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db" class="external">https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db</a></p>
<p>Use case:</p>
<ul>
<li>gemalto needs to often delete large repository groups, current system doesn't allow doing it from web interface</li>
<li>users need to delete manually each repo inside repo group and then delete the group itself</li>
</ul>
<p>Currently our system supports this operation in cleanup mode, so you can delete whole directory from the filesystem and run remap-and rescan. This is a workaround and should allow<br>
big cleanup, but it's far from being straightforward to do.</p>
<p>We need a consistent interface for deletion of resource that hold other resources. This should currently include two places</p>
<ul>
<li>user deletion (that hold repo groups/user groups/repositories)</li>
<li>repository group deletion (that hold other repositories)</li>
</ul>
<p>You can delete user or repository group in two ways, goind to admin > users or admin > repo groups and clicking delete.<br>
In case there are dependent objects, we should trigger a warning flash message, and redirect user to advanced settings section of user, or repo group. and allow them to do recursive delete.</p>
<p>There's already an interface for that in users advanced section, when you can select if you want to delete or transfer ownership of repositories or groups that user owns. <br>
We should re-use the logic, and make the same option available to deletion of repository groups. The user advanced section also needs some small improvements.</p>
<p>Recursive delete should have two options.</p>
<ul>
<li>delete resources</li>
<li>transfer ownership of resources to a different user in the system</li>
</ul>
<p>Currently part of that is implemented in user > settings > advanced where we have delete or detach option. <br>
Detach option unfortunetly picks the first super admin in the system which leads to<br>
odd results and you cannot control to whom you need to transfer the ownership.</p>