RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-03-27T16:47:41ZRhodeCode - issues
Redmine RhodeCode CE/EE - Feature #5602 (Resolved): Copy full path only copies partialhttps://issues.rhodecode.com/issues/56022020-03-27T16:47:41ZLuke Mauldin
<p>When viewing a file (example: <a href="https://XXXX/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs" class="external">https://XXXX/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs</a>) and clicking on the button to "copy full path", it only copies "Program.cs" instead of the full url. </p>
<p>Version: RhodeCode Enterprise 4.18.2 Community Edition </p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #4288 (Resolved): [ce, ee] unify controllers that use diffshttps://issues.rhodecode.com/issues/42882016-10-19T08:19:57ZDaniel Ddaniel@rhodecode.com
<p>Currently diffs are being used in these controllers:</p>
<ol>
<li>files controller: eg <code>/repo/diff/somefile?diff1=commit1&diff2=commit2</code></li>
<li>compare controller: eg. <code>/repo/compare/tag@v4.2.1...tag@v4.2.0</code></li>
<li>changeset controller: eg. <code>/repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f</code></li>
<li>pullrequest controller: eg. <code>/repo/pull-request/332</code></li>
</ol>
<p>These controllers use about 80% duplicate code which can be moved to a common base</p>
<p>Also some controller have options such as increase/decrease context which are not implemented in other controllers.</p>
RhodeCode CE/EE - Bug #4278 (Resolved): [admin] Clicking the save button in admin -> settings -> ...https://issues.rhodecode.com/issues/42782016-10-14T12:08:32ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i click the save buttton on the issue tracker settings page without having any pattern added and no pattern already in the list it leads to an exception.<br>
If i add a pattern or if there is at least one pattern already present it works fine.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Open the page <a href="http://localhost:5000/_admin/settings/issue-tracker" class="external">http://localhost:5000/_admin/settings/issue-tracker</a> (adapt to your host)</li>
<li>Make sure that no pattern is in the list and don't add one.</li>
<li>Click the save button</li>
<li>Exception happens</li>
</ol>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<p>2016-10-14 12:01:34.209 ERROR [rhodecode.lib.middleware.error_handling] 'NoneType' object has no attribute '<strong>getitem</strong>'<br>
Traceback (most recent call last):<br>
File "/Users/mb/work/ce/rhodecode/lib/middleware/error_handling.py", line 72, in handle_request<br>
response = request.get_response(self.app)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1320, in send<br>
application, catch_exc_info=False)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1284, in call_application<br>
app_iter = application(self.environ, start_response)<br>
File "/nix/store/nsdj1vmp0ir7hbgwb7sjb27cr8d8kplv-python2.7-Paste-2.0.2/lib/python2.7/site-packages/paste/registry.py", line 379, in <strong>call</strong><br>
app_iter = self.application(environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 103, in <strong>call</strong><br>
response = self.dispatch(controller, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 313, in dispatch<br>
return controller(environ, start_response)<br>
File "/Users/mb/work/ce/rhodecode/lib/base.py", line 502, in <strong>call</strong><br>
return WSGIController.<strong>call</strong>(self, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 214, in <strong>call</strong><br>
response = self.<u>dispatch_call()<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 164, in _dispatch_call<br>
response = self._inspect_call(func)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 107, in _inspect_call<br>
result = self._perform_call(func, args)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 57, in _perform_call<br>
return func(**args)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1334, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1143, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/controllers/admin/settings.py", line 400, in settings_issuetracker_save<br>
for uid in form['delete_patterns']:<br>
TypeError: 'NoneType' object has no attribute '</u><u>getitem</u>_'</p>
RhodeCode CE/EE - Feature #4267 (Resolved): [ce, ee] jira tracker integration wildcard project ke...https://issues.rhodecode.com/issues/42672016-10-06T13:51:41ZDaniel Ddaniel@rhodecode.com
<p>From <a href="https://rhodecode.tenderapp.com/help/discussions/dedicated-support/409-jira-integration-in-441" class="external">https://rhodecode.tenderapp.com/help/discussions/dedicated-support/409-jira-integration-in-441</a></p>
<blockquote>
<p>We have just updated to 4.4.1 and I would like to test the JIRA integration (one of the features I've been wishing for for a long time!). I went to the overall admin settings and the integration tab. I then tried to create a new JIRA integration. I have entered all of the parameters except JIRA Project Key, but it won't let me save without including a JIRA project key.</p>
<p>I want to set up the JIRA integration to work globally. Each repository in RhodeCode may be related to more than one JIRA project and there are some JIRA projects that relate to multiple RhodeCode repositories.<br>
When a JIRA issue is referenced in a commit message it will be referenced by ID, for example "fixes AE-54". The first part of this is the project key (AE in this case) and the second is the ID within that project (54 in this case) - therefore there is no need for the JIRA integration to know in advance the project key as it will be within the commit message (the existing issue tracker integration looks for [A-Z][A-Z0-9_]+-\d+). If the project key is fixed, then this precludes a user working on embedded software from referencing hardware and software issues in commit messages (as we typically keep the hardware and software as separate JIRA projects).</p>
<p>Please can you help me with this configuration?</p>
</blockquote>
RhodeCode CE/EE - Task #4251 (Feedback): [customer] Pull request with subreposhttps://issues.rhodecode.com/issues/42512016-09-29T13:41:00ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>While a lot of time passed since we’ve exchanged emails last time, let me share some details about the way we work at R and what kind of Rhodecode improvements would be useful for us. </p>
<ul>
<li>Most of our iOS/Mac product repositories are Mercurial </li>
<li>We extensively use Mercurial’s subrepositories for internal dependencies: our internal libraries are Mercurial or git repositories, which are added to product repository as a subrepo. </li>
<li>I like github flow: creating feature branches (bookmarks in Mercurial), opening pull request to master (default), code-reviewing this pull request and merging it after review is finished</li>
</ul>
<p>Unfortunately Rhodecode does not allow to create pull request for Mercurial repository in case it contains any subrepo, even if there were no changes in that sub-repositories. </p>
<p>So that’s the main reason why we can’t use github flow with Rhodecode and that’s the reason why we have to Crucible. </p>
<p>I’ve shared these details with team about a year ago : <a href="https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request" class="external">https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request</a></p>
<p>Currently Rhodecode is more like a repository storage for us and while post-commit reviews are possible they are rarely used. That’s why most people at R almost never see Rhodecode web interface. </p>
<p>Let me know if you need any more details or have any workaround that would still allow us to use pull requests. </p>
RhodeCode CE/EE - Task #4238 (Resolved): default reviewers updateshttps://issues.rhodecode.com/issues/42382016-09-22T12:45:15ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Some of my notes</p>
<ul>
<li>it would be good to SAVE the reasons for a reviewer, so it's clear to outsiders which roles other members have. It's good to know "WHO" is the author, who is form the team etc</li>
<li>it'd be good to have "exclude" author option so it's not a possibility that author gets picked to review his own PR</li>
</ul>
RhodeCode CE/EE - Feature #4225 (Resolved): [ce, ee] repo group integrations cascade to child rep...https://issues.rhodecode.com/issues/42252016-09-13T12:35:11ZDaniel Ddaniel@rhodecode.com
<p>At the moment repo group scope integrations apply only to the direct child repositories which means <code>scope:/u</code> does:</p>
<pre><code>/u
/somerepo - applies
/group
/otherrepo - doesn't apply
</code></pre>
<p>Should we add option to let the user allow the integration to cascade to child groups, the choices for the above example would then be:</p>
<ul>
<li>/u/ (any repo)</li>
<li>/u/ (direct child repos only)</li>
<li>/u/somerepo</li>
<li>/group/ (any repo)</li>
<li>/group/ (direct child repos only)</li>
<li>/gorup/otherrepo</li>
</ul>
RhodeCode CE/EE - Feature #4183 (Resolved): Different roles for PR reviewershttps://issues.rhodecode.com/issues/41832016-08-18T17:56:14ZTomoyuki Harada
<p>Currently we can set one or more reviewers for PR, but to complete review all reviewers must approve it.<br>
This workflow is natural but sometimes we just want someone check modification as observer but not need to mandatory to complete the review.</p>
RhodeCode CE/EE - Feature #4175 (Resolved): [ce, ee] repo group integrationshttps://issues.rhodecode.com/issues/41752016-08-15T12:25:12ZDaniel Ddaniel@rhodecode.com
<p>Add a way for integrations to run on a repo group</p>
RhodeCode CE/EE - Bug #4173 (Resolved): [ce, ee] mysql recycle pool timeout not workinghttps://issues.rhodecode.com/issues/41732016-08-12T16:41:27ZDaniel Ddaniel@rhodecode.com
<p>Replication:</p>
<ul>
<li>new config using mysql database</li>
<li>set mysql's wait_timeout to 6</li>
<li><code>threads = 1</code> in ini</li>
<li><code>sqlalchemy.db1.pool_recycle = 3</code> in ini</li>
<li>git push a repo (no changes need, just a push)</li>
<li>wait 7 seconds</li>
<li>git push again</li>
<li>get - <code>OperationalError: (OperationalError) (2006, 'MySQL server has gone away)</code></li>
</ul>
<p>This will also break subsequent requests with <code>StatementError: Can't reconnect until invalid transaction is rolled back</code></p>
RhodeCode CE/EE - Bug #4092 (Feedback): [ce, ee] Redmine/JIRA integrations - smart commitshttps://issues.rhodecode.com/issues/40922016-07-15T12:29:44ZDaniel Ddaniel@rhodecode.com
<p>For the redmine case there are 5 states for a ticket:</p>
<ul>
<li>new</li>
<li>in progress</li>
<li>resolved</li>
<li>feedback</li>
<li>closed'</li>
</ul>
<p>Commit messages should be able to auto close/resolve tickets using keywords such as <code>fixes #42</code></p>
<p>The thing to think about is that the user may want 'fixes #20' to set the redmine issue to any of 'resolved', 'feedback' or 'closed' - this should be set in the integration options.</p>
<p>Allowing custom multiple regex => state mappers per integration is the most powerful but might be overkill- making standard keywords might be better eg:</p>
<p>fixes => resolved<br>
closes => closed</p>
<p>Then again this might be no good for international users.</p>
RhodeCode CE/EE - Bug #4091 (Resolved): [ce, ee] Redmine integration blocks for 30 seconds if red...https://issues.rhodecode.com/issues/40912016-07-15T08:59:15ZDaniel Ddaniel@rhodecode.com
<p>This is a problem when not running celery - ie. sync mode, should lower the timeout to something smaller.</p>
RhodeCode CE/EE - Task #3454 (Feedback): [ce/ee] visually differentiate the two editionshttps://issues.rhodecode.com/issues/34542016-04-07T15:38:27ZOliver Strobeloliver@rhodecode.com
<p>Currently we are only changing the footer to include Community vs. Enterprise differentiation.</p>
<p>Purpose: It should be possible to tell the difference in edition quickly when switching between CE/EE tabs.</p>
<p>Potential solutions:<br>
1) Add the edition name into the header after the logo on the top left<br>
2) Change the colour of the header between editions, eg.<br>
CE = dark grey<br>
EE = black</p>
<p>Thoughts?</p>
RhodeCode CE/EE - Feature #2539 (Feedback): Recursive deletion of resourceshttps://issues.rhodecode.com/issues/25392015-08-25T18:11:48ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Ticket from support: <a href="https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db" class="external">https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db</a></p>
<p>Use case:</p>
<ul>
<li>gemalto needs to often delete large repository groups, current system doesn't allow doing it from web interface</li>
<li>users need to delete manually each repo inside repo group and then delete the group itself</li>
</ul>
<p>Currently our system supports this operation in cleanup mode, so you can delete whole directory from the filesystem and run remap-and rescan. This is a workaround and should allow<br>
big cleanup, but it's far from being straightforward to do.</p>
<p>We need a consistent interface for deletion of resource that hold other resources. This should currently include two places</p>
<ul>
<li>user deletion (that hold repo groups/user groups/repositories)</li>
<li>repository group deletion (that hold other repositories)</li>
</ul>
<p>You can delete user or repository group in two ways, goind to admin > users or admin > repo groups and clicking delete.<br>
In case there are dependent objects, we should trigger a warning flash message, and redirect user to advanced settings section of user, or repo group. and allow them to do recursive delete.</p>
<p>There's already an interface for that in users advanced section, when you can select if you want to delete or transfer ownership of repositories or groups that user owns. <br>
We should re-use the logic, and make the same option available to deletion of repository groups. The user advanced section also needs some small improvements.</p>
<p>Recursive delete should have two options.</p>
<ul>
<li>delete resources</li>
<li>transfer ownership of resources to a different user in the system</li>
</ul>
<p>Currently part of that is implemented in user > settings > advanced where we have delete or detach option. <br>
Detach option unfortunetly picks the first super admin in the system which leads to<br>
odd results and you cannot control to whom you need to transfer the ownership.</p>