RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-12-02T10:36:16ZRhodeCode - issues
Redmine RhodeCode CE/EE - Feature #5643 (Resolved): jump to bottom of reviewhttps://issues.rhodecode.com/issues/56432020-12-02T10:36:16ZSebastian Elsner
<p>As a reviewer I often find myself with a large PR with many files changed, resulting in long PR pages. I scroll to the bottom, approve the PR. Something needs fixing, PR is updated, I reopen the page, approve scrolling down the PR page, PR may be updated, ....</p>
<p>A small improvement for this would be that you place a "Jump to bottom" link at the top. I know, I can press the "end" key on the keyboard, but my right hand is with the mouse and the left with the coffee mug ;)</p>
<p>Maybe like this:</p>
<p><img src="https://issues.rhodecode.com/attachments/download/3086/Selection_021.png" alt="" loading="lazy" /></p>
<p>From Phabricator code review I was used to have the "toolbar" for "Close" and "Merge" and "Add Comment" at the top AND at the bottom. That would be a solution too, but I guess way to over engineered for the problem.</p>
RhodeCode CE/EE - Feature #5613 (New): Feature Request: Issue tracker link in new tab/windowhttps://issues.rhodecode.com/issues/56132020-04-08T23:01:09ZRenaud Lepage
<p>Right now the Issue Tracker auto-links open in the same browser tab/window.</p>
<p>It would be nice to have the option (at the instance level) to have the auto-generated links open in a new tab/window.</p>
<p>This is PURELY a UX optimisation. Extremely low priority.</p>
RhodeCode CE/EE - Bug #5612 (New): CPU cores getting maxed out by VCSServer on Repository Size re...https://issues.rhodecode.com/issues/56122020-04-08T18:57:58ZRenaud Lepage
<p>Please note that this happens on a RhodeCode CE instance, running the latest RhodeCode code, but running on a Virtual Private Server machine with fairly "restricted" specs (one virtual CPU, 2gb RAM). Weak by any metrics.</p>
<p>Condition: Using a freshly imported SVN repository that's not indexed or anything</p>
<p>Hitting "Show Repository Size" starts some kind of "runaway process", or possibly a "go through each commit in historical order", from the RhodeCode "Main Service" (community-1) to the VCS Server. This makes the two VCSServer workers max out the one virtual CPU my VPS instance has for some reason - likely because VCSServer does some big processing on each commit to get the size, but I can't be sure.</p>
<p>Setting prio to Low because I'm not a paying client.</p>
RhodeCode CE/EE - Bug #5575 (Resolved): Filtering username containing '-' does not work in Admin ...https://issues.rhodecode.com/issues/55752019-12-12T17:39:46ZBoris Basic
<p>Usernames containing '-' such as 'user-name' can't be filtered with the "usernale:" filter command.</p>
RhodeCode CE/EE - Bug #5558 (Resolved): Commit compare window covers texthttps://issues.rhodecode.com/issues/55582019-07-07T21:53:10ZCatalin Salgau
<p>Commit compare window covers text<br>
Seen on pre-pull-request commit or when hitting "compare origin on a fork repository" (and reaching this url, for example)<br>
<a href="https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1" class="external">https://code.rhodecode.com/rhodecode-enterprise-ce/compare/rev%40tip...rev%40tip?merge=1</a></p>
RhodeCode CE/EE - Feature #5536 (Resolved): Ability to disable server-side SSH key generationhttps://issues.rhodecode.com/issues/55362019-02-11T19:42:50ZCatalin Salgau
<p>Generating a private/public SSH key pair may be user-friendly, but shipping this from the server can pose security concerns.<br>
Please add a way to disable key generation and/or provide client client-side key generation(Web Crypto APIs are available in most modern browsers)<br>
Thanks</p>
Documentation - Bug #5439 (New): JIRA Integration description: Wrong sample linkhttps://issues.rhodecode.com/issues/54392018-02-14T14:25:34ZMalte Onnen
<p>The sample link described <a href="https://docs.rhodecode.com/RhodeCode-Enterprise/issue-trackers/issue-trackers.html#jira-integration" class="external">here</a> should rather be <br>
<a href="https://myissueserver.com/browse/${id}" class="external">https://myissueserver.com/browse/${id}</a><br>
than<br>
<a href="https://myissueserver.com/issue/${id}" class="external">https://myissueserver.com/issue/${id}</a></p>
RhodeCode Appenlight - Bug #5342 (New): Broken link [Applications Modify application]https://issues.rhodecode.com/issues/53422017-06-21T21:21:50ZBartłomiej Wołyńczyk
<p>Description:<br>
Link in applications setting is leading to main application page instead documentation.</p>
<p>"How to connect your application?<br>
Visit our developer documentation for step-by-step integration instructions."<br>
developer documentation ->> <a href="https://appenlight.rhodecode.com/" class="external">https://appenlight.rhodecode.com/</a><br>
instead ->> <a href="https://getappenlight.com/page/api/main.html" class="external">https://getappenlight.com/page/api/main.html</a> ??</p>
<p>Steps to reproduce:</p>
<ol>
<li>Go to Applications </li>
<li>Chosen Application -> Update</li>
<li>On Right Top there is link leading to developer documentation. </li>
</ol>
RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Bug #4155 (Resolved): Date of Last Change is not displayed correctlyhttps://issues.rhodecode.com/issues/41552016-08-07T11:17:09ZDmitry Konchalenkov [staff]dmitry@rhodecode.com
<p>Expected: <em>Last Change</em> should be the date of the latest commit. See screenshot.<br>
Actual: </p>
<ul>
<li>either <em>Last Change</em> doesn't use the date of the latest commit</li>
<li>or <em>Last Change</em> uses the time zone incorrectly</li>
</ul>
RhodeCode CE/EE - Bug #4154 (New): [ce, ee] user register via github captchahttps://issues.rhodecode.com/issues/41542016-08-05T22:51:47ZDaniel Ddaniel@rhodecode.com
<p>Found on code.rhodecode.com - sign up using github account - captcha is asked but not verified.</p>
RhodeCode CE/EE - Bug #4040 (New): [ce, ee] logout when logged out causes 403 Cross-site request ...https://issues.rhodecode.com/issues/40402016-06-22T21:09:03ZDaniel Ddaniel@rhodecode.com
<p>Reproduce:</p>
<ul>
<li>Login to rhodecode</li>
<li>Logout in another tab</li>
<li>Click logout in original tab</li>
</ul>
RhodeCode Appenlight - Feature #4017 (New): application logos need helphttps://issues.rhodecode.com/issues/40172016-06-14T11:52:12ZLisa Quatmannlisa@rhodecode.com
<p>see attached</p>
<p>surely we can make this prettier</p>
RhodeCode CE/EE - Bug #3615 (New): (OperationalError) too many SQL variables on admin journal pagehttps://issues.rhodecode.com/issues/36152016-05-06T11:44:17ZDaniel Ddaniel@rhodecode.com
<p>Steps to reproduce:</p>
<ul>
<li>use sqlite database</li>
<li>add over 1000 repos</li>
<li>open /_admin/journal</li>
</ul>
<p>OperationalError: (OperationalError) too many SQL variables u'SELECT count(*) AS count_1 \nFROM (SELECT user_logs.user_log_id AS user_logs_user_log_id, user_logs.user_id AS user_logs_user_id, user_logs.username AS user_logs_username, user_logs.repository_id AS user_logs_repository_id, user_logs.repository_name AS user_logs_repository_name, user_logs.user_ip AS user_logs_user_ip, user_logs.action AS user_logs_action, user_logs.action_date AS user_logs_action_date \nFROM user_logs \nWHERE user_logs.repository_id IN (?, ?, ?, ?, ?, ?, ?......) ORDER BY user_logs.action_date DESC) AS anon_1' (1,2,....1001 ids)</p>
<pre><code>File "/Users/dan/Projects/rc/rhodecode-enterprise-ce-dan/rhodecode/controllers/journal.py", line 262, in public_journal
c.journal_pager = Page(journal, page=p, items_per_page=20)
File "/nix/store/08jg8cv3mdsjdqa367b9gmilcmif46s3-python2.7-WebHelpers-1.3/lib/python2.7/site-packages/webhelpers/paginate.py", line 413, in __init__
self.item_count = len(self.collection)
</code></pre>
<p>The problem is in <code>rhodecode.controllers.journal.JournalController:_get_journal_data()</code></p>
<p>The query it generates has an IN which can fill up to the max limit for sqlite</p>
<p>Possible solutions:</p>
<ul>
<li>use a for loop</li>
<li>rewrite query to use joins instead</li>
</ul>
<p>Current workarounds:</p>
<ul>
<li>use mysql/postgresql</li>
</ul>