RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042017-05-30T16:11:23ZRhodeCode - issues
Redmine RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Feature #4232 (New): [ce, ee, pr, compare] redo diffs, support side by side dif...https://issues.rhodecode.com/issues/42322016-09-18T16:40:43ZDaniel Ddaniel@rhodecode.com
<p>One of the most requested features is side by side diffs for multiple files at the same time (eg. pull request & compare pages).</p>
<p>Currently we have side by side diffs implemented for a single files only using the javascript library mergely. This doesn't include inline comments and uses different syntax highlighting to the rest of Rhodecode. Copy paste of code also works differently between the pr page and the side/side view.</p>
<p>There is another javascript diff library: <a href="https://diff2html.xyz/demo" class="external">https://diff2html.xyz/demo</a>, which gives very good results, however integrating inline comments and context loading into this proved to be a lot of trouble, also the syntax highlighting doesn't support partial code blocks very well, eg:</p>
<pre><code>51 this is the end of a doc string
52 """
53 return True
</code></pre>
<p>will mark the <code>return True</code> part as a string.</p>
<p>Therefore the things we need in diffs are:</p>
<ul>
<li>Syntax highlighting based on the entire file, rather than the partial diff</li>
<li>Inline comments + all relevant functionality</li>
<li>Ajax file context loading (eg. click to load more lines of a file before/after the changed lines)</li>
<li>In the browser conversion between raw/unified/side diffs - using JS</li>
</ul>
<p>This will be exposed as a reusuable widget that can be used anywhere in Rhodecode, taking a diff reference as a sole argument.</p>
<p>The steps to create the diff are:</p>
<ol>
<li>Generate the diff chunks for each file</li>
<li>Get the old and new versions of the files, highlight using pygments</li>
<li>Use custom pygments renderer to generate the diff context:
<ol>
<li>Using the original highlighted file lines which will have proper syntax highlighting colors</li>
<li>Support both unified/sideside without modification</li>
<li>Use a table that is copypaste friendly</li>
<li>Add inline comments + functionality </li>
<li>Expose load more file lines context functionality markers</li>
</ol></li>
<li>Render this in the template</li>
<li>Apply javascript events lazily to avoid the overheads of adding events to every single element</li>
</ol>
<p>This will also require an endpoint to get the partial N-M lines context of a file @ revision via ajax</p>
RhodeCode CE/EE - Bug #4208 (New): [ce, ee] test errors get hidden by error pagehttps://issues.rhodecode.com/issues/42082016-08-30T18:42:32ZDaniel Ddaniel@rhodecode.com
<p>When running tests the traceback is excepted away by the error handler page, this makes it difficult to debug since eg</p>
<pre><code>app.get('/page_that_errors')
</code></pre>
<p>will return a 500 error page instead of a traceback.</p>
<p>OTOH making tests always raise errors will then break the page that checks if the pretty error page is working as it should.</p>
<p>Need to add a dynamic setting, eg settings['use_error_document'] = False - that can be turned on/off at will and will disable the pretty error page handler for running tests.</p>
RhodeCode CE/EE - Task #4197 (New): [ce, ee] get list of users with their permissions to a reposi...https://issues.rhodecode.com/issues/41972016-08-24T14:31:24ZDaniel Ddaniel@rhodecode.com
<p>Related to <a href="https://issues.rhodecode.com/issues/4150" class="external">https://issues.rhodecode.com/issues/4150</a></p>
<p>Need a way to get all users from a repository along with their permissions for that repo.</p>
<p>At the moment permissions are generated via a complex python object in rhodecode.lib.auth:AuthUser which calculates the tree for a single user, taking into account default user, repo settings (overriding globals or not), and usergroups.</p>
<p>Iterating over the entire list of users is much too slow, some preliminary benchmarks show that it will take 10seconds / 100users.</p>
<p>In order to do this quickly instead, we would have to generate permissions via sql - A simplish (not completely correct results) query shows it will take about 50ms on internal rhodecode db.</p>
<pre><code>
SELECT
users.username,
repositories.repo_name,
MIN(origin_sort || '-' || permission_name) as perm
FROM (
SELECT
'' as ug,
permissions.permission_name,
user_id,
repository_id,
'1-user' as origin_sort
FROM
repo_to_perm
JOIN
permissions ON
permissions.permission_id = repo_to_perm.permission_id
-- WHERE repository_id = 190
UNION ALL
SELECT
users_groups.users_group_name,
permissions.permission_name,
users_groups_members.user_id,
repository_id,
'2-usergroup-' || users_groups.users_group_name as origin_sort
FROM
users_group_repo_to_perm
JOIN
permissions ON
permissions.permission_id = users_group_repo_to_perm.permission_id
JOIN
users_groups_members
ON
users_groups_members.users_group_id = users_group_repo_to_perm.users_group_id
JOIN
users_groups
ON
users_group_repo_to_perm.users_group_id = users_groups.users_group_id
-- WHERE repository_id = 190
) tmp_user_and_usergroup_perms
JOIN users ON users.user_id = tmp_user_and_usergroup_perms.user_id
JOIN repositories ON repositories.repo_id = tmp_user_and_usergroup_perms.repository_id
GROUP BY users.username, repositories.repo_name
ORDER BY username, perm
;
</code></pre> RhodeCode CE/EE - Task #4179 (New): [ce, ee] refine perms summary listhttps://issues.rhodecode.com/issues/41792016-08-17T02:16:51ZDaniel Ddaniel@rhodecode.com
<p>Sort by name, otherwise it's hard to find repos when list is large.</p>
RhodeCode CE/EE - Task #4147 (New): [ce, ee, docs] Events documentationhttps://issues.rhodecode.com/issues/41472016-08-04T03:52:39ZDaniel Ddaniel@rhodecode.com
<p>We need to add documentation of the json structure that events emit. Would be a good idea to make this auto generated from dummy events so that there is no sync issue between docs/reality.</p>
RhodeCode CE/EE - Feature #4074 (New): Edit review commenthttps://issues.rhodecode.com/issues/40742016-07-06T16:50:33ZTamas Gemes
<p>Currently you can only create and delete your comments during a review.<br>
This is the same for in-code comments and global (commit or pull request) comments.</p>
<p>It would be nice to have an edit feature too.</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Feature #687 (New): [Integraton ]- Elastic search integrationhttps://issues.rhodecode.com/issues/6872015-01-12T11:07:47ZBrian Butlerbrian@rhodecode.comDocumentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>
Documentation - Feature #659 (New): Peer to Peer Failoverhttps://issues.rhodecode.com/issues/6592015-01-08T15:47:01ZBrian Butlerbrian@rhodecode.com
<p>doc this if we have</p>
Documentation - Feature #317 (New): Stylinghttps://issues.rhodecode.com/issues/3172014-11-12T09:44:42ZBrian Butlerbrian@rhodecode.com
<p>Create a Sphinx style for RhodeCode docs</p>