RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042023-12-07T08:05:26ZRhodeCode - issues
Redmine RhodeCode CE/EE - Task #5711 (Resolved): svn: make the SSL detection work better.https://issues.rhodecode.com/issues/57112023-12-07T08:05:26ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>as per discussion here: <a href="https://community.rhodecode.com/t/svn-cant-move-a-file-http-502-bad-gateway/535/13" class="external">https://community.rhodecode.com/t/svn-cant-move-a-file-http-502-bad-gateway/535/13</a></p>
<p>check if the downgrade header can be there always to support http+https traffic</p>
RhodeCode CE/EE - Task #5701 (Resolved): Default permissions cache purgehttps://issues.rhodecode.com/issues/57012023-11-06T07:17:38ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>It looks like the cache purging for global default permissions aren't pushed once the override function is set.</p>
<p>make sure the flush permissions caches once this is enable. Probably we need to rebuild the full set up permissions in order for this to work</p>
RhodeCode CE/EE - Task #5386 (Resolved): Increase security for Email Changehttps://issues.rhodecode.com/issues/53862017-09-13T10:34:51ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>We already require OLD password when changing the current user password, but email is another way to recover an account. If hacker is able to access open instance of RC he can trigger an email change and change the password after that.<br>
Proposed idea to fix this is:</p>
<ul>
<li>Make email a select field instead of text input</li>
<li>Inside the input we allow user to pick any of the addresses added via extra emails</li>
<li>In order to change an email user needs to add a new email from additional emails, this needs to require a password, and then he can select a new email from the entry.</li>
</ul>
<p>THis should force users to give current password to change the email</p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #4311 (Resolved): Diffs feedbackhttps://issues.rhodecode.com/issues/43112016-11-24T15:48:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Below some feedback items that i made</p>
RhodeCode CE/EE - Task #4288 (Resolved): [ce, ee] unify controllers that use diffshttps://issues.rhodecode.com/issues/42882016-10-19T08:19:57ZDaniel Ddaniel@rhodecode.com
<p>Currently diffs are being used in these controllers:</p>
<ol>
<li>files controller: eg <code>/repo/diff/somefile?diff1=commit1&diff2=commit2</code></li>
<li>compare controller: eg. <code>/repo/compare/tag@v4.2.1...tag@v4.2.0</code></li>
<li>changeset controller: eg. <code>/repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f</code></li>
<li>pullrequest controller: eg. <code>/repo/pull-request/332</code></li>
</ol>
<p>These controllers use about 80% duplicate code which can be moved to a common base</p>
<p>Also some controller have options such as increase/decrease context which are not implemented in other controllers.</p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Task #4251 (Feedback): [customer] Pull request with subreposhttps://issues.rhodecode.com/issues/42512016-09-29T13:41:00ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>While a lot of time passed since we’ve exchanged emails last time, let me share some details about the way we work at R and what kind of Rhodecode improvements would be useful for us. </p>
<ul>
<li>Most of our iOS/Mac product repositories are Mercurial </li>
<li>We extensively use Mercurial’s subrepositories for internal dependencies: our internal libraries are Mercurial or git repositories, which are added to product repository as a subrepo. </li>
<li>I like github flow: creating feature branches (bookmarks in Mercurial), opening pull request to master (default), code-reviewing this pull request and merging it after review is finished</li>
</ul>
<p>Unfortunately Rhodecode does not allow to create pull request for Mercurial repository in case it contains any subrepo, even if there were no changes in that sub-repositories. </p>
<p>So that’s the main reason why we can’t use github flow with Rhodecode and that’s the reason why we have to Crucible. </p>
<p>I’ve shared these details with team about a year ago : <a href="https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request" class="external">https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request</a></p>
<p>Currently Rhodecode is more like a repository storage for us and while post-commit reviews are possible they are rarely used. That’s why most people at R almost never see Rhodecode web interface. </p>
<p>Let me know if you need any more details or have any workaround that would still allow us to use pull requests. </p>
RhodeCode CE/EE - Task #4238 (Resolved): default reviewers updateshttps://issues.rhodecode.com/issues/42382016-09-22T12:45:15ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Some of my notes</p>
<ul>
<li>it would be good to SAVE the reasons for a reviewer, so it's clear to outsiders which roles other members have. It's good to know "WHO" is the author, who is form the team etc</li>
<li>it'd be good to have "exclude" author option so it's not a possibility that author gets picked to review his own PR</li>
</ul>
RhodeCode CE/EE - Task #4202 (Resolved): Polish the 503.html pagehttps://issues.rhodecode.com/issues/42022016-08-29T16:56:27ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>We have a custom page for NGINX if RhodeCode is down, under: <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/default/rhodecode/public/502.html</a></p>
<p>It is shown via such NGINX entry:</p>
<pre><code> ## custom 502 error page
error_page 502 /502.html;
location = /502.html {
root /path/to/.rccontrol/enterprise-1/static;
}
</code></pre>
<p>It looks very ugly, we should make it look nice and have some more usefull information.</p>
<p>We CANNOT use any variables, images etc. It needs to be PURE html (similar to email templates) but without variables.</p>
RhodeCode CE/EE - Task #4194 (Resolved): move svn http backend out of labs into a real VCS settingshttps://issues.rhodecode.com/issues/41942016-08-23T11:30:07ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>We think that SVN backend is stable enough, and shouldn't be labs settings. We should move it outside of labs into a dedicated SVN options under <code>_admin/settings/vcs</code></p>
RhodeCode CE/EE - Task #4181 (Resolved): Integrations: allow root repos only integrationshttps://issues.rhodecode.com/issues/41812016-08-18T16:09:31ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I realized that repo groups already allow to have really good control over integrations. I think last missing bit would be a flag that sets the global integrations to work for root level projects only. This would allow to create global catch all for all root level projects, + possible combinations of integrations on repo group level.</p>
<p>THen i could:</p>
<ul>
<li>set global slack integration for all our root projects which are the main ones</li>
<li>set slack integration for <code>u</code> usergroup which is our namespace for forks</li>
<li>skip <code>release</code> group which produces a lot of noise</li>
<li>add any other repo group that we have if we need to.</li>
</ul>
<p>THoughts ?</p>
RhodeCode CE/EE - Task #4180 (Resolved): integrations: possible limit the updates senthttps://issues.rhodecode.com/issues/41802016-08-17T09:42:46ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>based on the amount of comments in this ticket: <a href="https://issues.rhodecode.com/issues/4172" class="external">https://issues.rhodecode.com/issues/4172</a></p>
<p>I wonder, if maybe it's better to aggregate those, and send a list of referenced tickets instead of updating ticket on each commit pushed. In case of large pushes it would almost spam the issue tracker server. After i merged 5-6 commits i got 5-6 emails from redmine.</p>
RhodeCode CE/EE - Task #4153 (Resolved): Optimize readme fetching by changing the system of readm...https://issues.rhodecode.com/issues/41532016-08-05T01:49:06ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Mostly based on the task from customer, It seems the current readme search logic is slow, and fragile to errors. Repositories that don't have readme do very expensive checks for over 30 files.</p>
<p>The current logic iterates over generate patterns of files and tries to search for such file inside the repository. In GIT case with a lot of BINARY big files it's very slow to call get_node('unknonw_readme_path')<br>
IMHO the whole search for readme logic is flowed. Image there's no readme we have to iterate over 30-50 combinations to search for readme.</p>
<p>Customer reported that in his case opening summary page (in which renderer search is taking place) takes 30-50s !!</p>
<p>Plan to fix this is:</p>
<ul>
<li><p>add renderer to per-repo-settings. It will allow to define what renderer each repository uses. Probably need some changes how we fetch the global renderers.<br>
per repo renderer will allow to generate per-repo order of readmes.</p></li>
<li><p>added new option about readme generation to into global visual and per repo: visual, consisting of:<br>
<code>autodetect</code> (based on renderer try to auto-detect like currently)<br>
<code>none</code> (don't load any readmes),<br>
<code><list_of_patterns></code> List in order of picked renderer either global, or local</p></li>
</ul>
RhodeCode CE/EE - Task #3454 (Feedback): [ce/ee] visually differentiate the two editionshttps://issues.rhodecode.com/issues/34542016-04-07T15:38:27ZOliver Strobeloliver@rhodecode.com
<p>Currently we are only changing the footer to include Community vs. Enterprise differentiation.</p>
<p>Purpose: It should be possible to tell the difference in edition quickly when switching between CE/EE tabs.</p>
<p>Potential solutions:<br>
1) Add the edition name into the header after the logo on the top left<br>
2) Change the colour of the header between editions, eg.<br>
CE = dark grey<br>
EE = black</p>
<p>Thoughts?</p>