RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-04-15T20:04:39ZRhodeCode - issues
Redmine RhodeCode CE/EE - Feature #5615 (Resolved): Misleading message in PR diff view "File was deleted ...https://issues.rhodecode.com/issues/56152020-04-15T20:04:39ZOlivier Renaud
<p>I have a PR with an inline code comment. I updated the PR with a new commit that reverts the code that the comment was attached to. Now, the PR page correctly keeps the inline comment in a dedicated block at the end of the diffs. My problem is that the message that appears in this block is misleading.</p>
<p><img src="https://issues.rhodecode.com/attachments/download/3070/2020-04-15_19-56-40.png" alt="" loading="lazy" /></p>
<p>It says that the file was deleted, but it's not the case: there is just no change in this file anymore, in the complete diff.</p>
RhodeCode CE/EE - Bug #5610 (Resolved): Files navigation looses the at=<name> markerhttps://issues.rhodecode.com/issues/56102020-04-02T14:34:35ZDaniel Ddaniel@rhodecode.com
<p>During investigation of <a class="issue tracker-1 status-3 priority-2 priority-default" title="Bug: SVN navigation to trunk fails (Resolved)" href="https://issues.rhodecode.com/issues/5599">#5599</a> we also discovered that the ?at= GET marker that indicates current reference we're browsing is getting lost when navigating via tree/files. We'd need to fix this to preserve that marker especially for SVN</p>
RhodeCode CE/EE - Feature #5602 (Resolved): Copy full path only copies partialhttps://issues.rhodecode.com/issues/56022020-03-27T16:47:41ZLuke Mauldin
<p>When viewing a file (example: <a href="https://XXXX/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs" class="external">https://XXXX/playground/samplerepo/files/bb06dde8cb58aae32ffa52a788c37c58e816934f/Program.cs</a>) and clicking on the button to "copy full path", it only copies "Program.cs" instead of the full url. </p>
<p>Version: RhodeCode Enterprise 4.18.2 Community Edition </p>
RhodeCode CE/EE - Bug #5599 (Resolved): SVN navigation to trunk failshttps://issues.rhodecode.com/issues/55992020-03-27T16:23:49ZLuke Mauldin
<p>In an SVN repository navigation fails when trying to navigate to the version of the file on the trunk.</p>
<p>Scenario:</p>
<ul>
<li>Setup SVN repository with normal layout: branches, tags, trunk</li>
<li>Create a file trunk/test_4.txt and commit multiple changes to it</li>
<li>Navigate to view a non-HEAD revision (assume HEAD is revision 20, but view revision 18) - example: <a href="https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt" class="external">https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt</a></li>
<li>In the left hand side from the revision list choose 'trunk' and the URL generated link is wrong - <a href="https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt" class="external">https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt</a></li>
<li>If I manually edit the address to the following then it workshttps://etsgit.gvl.is.l-3com.com/playground/testrepo/files/20/trunk/test_4.txt: </li>
</ul>
<p>I have not been able to reproduce this with a Git repository.</p>
<p>Version: RhodeCode Enterprise 4.18.2 Community Edition </p>
RhodeCode CE/EE - Feature #5581 (Resolved): expose `send_email` option in the HTTP API, for `comm...https://issues.rhodecode.com/issues/55812020-01-14T16:51:34ZOlivier Renaud
<p>In the Python API, <code>CommentsModel.create</code> has a <code>send_email</code> argument, that controls whether mail notifications is sent to users.<br>
In the HTTP API (<code>comment_commit</code> and <code>comment_pull_request</code>), there is no such option. It is possible to add CC mails, but not to mute the notifications.</p>
<p>I am writing a bot that will act as a pull request reviewer. As each change of a PR status requires a comment (under review, approved, rejected), I would like to send mail notifications only for important events (rejection). I know my users, they will definitely complain if they receive too much emails from this bot!</p>
<p>The request is to add a <code>send_email</code> parameter to these two HTTP API methods. It is not clear how this new argument should play with the existing <code>extra_recipients</code> argument, though.</p>
RhodeCode CE/EE - Bug #5579 (Resolved): JS bug when a commit message can be parsed as a numberhttps://issues.rhodecode.com/issues/55792019-12-29T21:40:15ZOlivier Renaud
<p>Steps to reproduce:</p>
<ul>
<li>Push a commit in a feature branch, with the message "123"</li>
<li>Go to the Pull Request creation page, and select the branch in the "source" drop down.</li>
</ul>
<p>Javascript fails with "TypeError: rawMessage.split is not a function" in getTitleAndDescription (script.js:55503).<br>
The debugger shows that rawMessage is a number at this point, and not a string.</p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #4311 (Resolved): Diffs feedbackhttps://issues.rhodecode.com/issues/43112016-11-24T15:48:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Below some feedback items that i made</p>
RhodeCode CE/EE - Bug #4296 (Resolved): [ee] Can not create pull requests with reviewers.https://issues.rhodecode.com/issues/42962016-10-24T17:20:47ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i create a PR in CE it works but in EE it fails. I also get no error message.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Create a pr as admin user</li>
<li>Leave the default reviewer (admin itself) in place</li>
<li>Try to submit the PR</li>
<li>Error happens without error message.</li>
</ol>
<a name="Investigations-so-far"></a>
<h1 >Investigations so far<a href="#Investigations-so-far" class="wiki-anchor">¶</a></h1>
<p>The difference is in the data which is posted to the controller. In CE it works and the POST data looks like this:</p>
<pre><code>{u'review_members': [{u'reasons': [], 'user_id': u'2'}], 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', u'revisions': [u'7fecd3f02a2cc73ac03d267ab234cabbfbb5bf31', u'06c48b467036bba03305640d1fb7854632dce351'], 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<p>In EE it fails and the POST data looks like this:</p>
<pre><code>{'review_members': u'2', 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', 'revisions': u'06c48b467036bba03305640d1fb7854632dce351', 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<pre><code>2016-10-24 16:56:06.533 ERROR [rhodecode.controllers.pullrequests] Error creating pull request: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
Traceback (most recent call last):
File "/nix/store/l1rdgp35mnr58w3hww23l3h8q5zbcld7-python2.7-rhodecode-enterprise-ce-4.5.0/lib/python2.7/site-packages/rhodecode/controllers/pullrequests.py", line 411, in create
_form = PullRequestForm(repo.repo_id)().to_python(controls)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py", line 419, in to_python
value = tp(value, state)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py", line 153, in _to_python
new[name] = validator.to_python(value, state)
Invalid: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
</code></pre> RhodeCode CE/EE - Task #4288 (Resolved): [ce, ee] unify controllers that use diffshttps://issues.rhodecode.com/issues/42882016-10-19T08:19:57ZDaniel Ddaniel@rhodecode.com
<p>Currently diffs are being used in these controllers:</p>
<ol>
<li>files controller: eg <code>/repo/diff/somefile?diff1=commit1&diff2=commit2</code></li>
<li>compare controller: eg. <code>/repo/compare/tag@v4.2.1...tag@v4.2.0</code></li>
<li>changeset controller: eg. <code>/repo/changeset/7c7441cbf9af8c527310aac72fd8a67ea7dd908f</code></li>
<li>pullrequest controller: eg. <code>/repo/pull-request/332</code></li>
</ol>
<p>These controllers use about 80% duplicate code which can be moved to a common base</p>
<p>Also some controller have options such as increase/decrease context which are not implemented in other controllers.</p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Task #4251 (Feedback): [customer] Pull request with subreposhttps://issues.rhodecode.com/issues/42512016-09-29T13:41:00ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>While a lot of time passed since we’ve exchanged emails last time, let me share some details about the way we work at R and what kind of Rhodecode improvements would be useful for us. </p>
<ul>
<li>Most of our iOS/Mac product repositories are Mercurial </li>
<li>We extensively use Mercurial’s subrepositories for internal dependencies: our internal libraries are Mercurial or git repositories, which are added to product repository as a subrepo. </li>
<li>I like github flow: creating feature branches (bookmarks in Mercurial), opening pull request to master (default), code-reviewing this pull request and merging it after review is finished</li>
</ul>
<p>Unfortunately Rhodecode does not allow to create pull request for Mercurial repository in case it contains any subrepo, even if there were no changes in that sub-repositories. </p>
<p>So that’s the main reason why we can’t use github flow with Rhodecode and that’s the reason why we have to Crucible. </p>
<p>I’ve shared these details with team about a year ago : <a href="https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request" class="external">https://rhodecode.tenderapp.com/help/discussions/support-tickets/1234-unable-to-create-pull-request</a></p>
<p>Currently Rhodecode is more like a repository storage for us and while post-commit reviews are possible they are rarely used. That’s why most people at R almost never see Rhodecode web interface. </p>
<p>Let me know if you need any more details or have any workaround that would still allow us to use pull requests. </p>
RhodeCode CE/EE - Bug #4092 (Feedback): [ce, ee] Redmine/JIRA integrations - smart commitshttps://issues.rhodecode.com/issues/40922016-07-15T12:29:44ZDaniel Ddaniel@rhodecode.com
<p>For the redmine case there are 5 states for a ticket:</p>
<ul>
<li>new</li>
<li>in progress</li>
<li>resolved</li>
<li>feedback</li>
<li>closed'</li>
</ul>
<p>Commit messages should be able to auto close/resolve tickets using keywords such as <code>fixes #42</code></p>
<p>The thing to think about is that the user may want 'fixes #20' to set the redmine issue to any of 'resolved', 'feedback' or 'closed' - this should be set in the integration options.</p>
<p>Allowing custom multiple regex => state mappers per integration is the most powerful but might be overkill- making standard keywords might be better eg:</p>
<p>fixes => resolved<br>
closes => closed</p>
<p>Then again this might be no good for international users.</p>
RhodeCode CE/EE - Task #3454 (Feedback): [ce/ee] visually differentiate the two editionshttps://issues.rhodecode.com/issues/34542016-04-07T15:38:27ZOliver Strobeloliver@rhodecode.com
<p>Currently we are only changing the footer to include Community vs. Enterprise differentiation.</p>
<p>Purpose: It should be possible to tell the difference in edition quickly when switching between CE/EE tabs.</p>
<p>Potential solutions:<br>
1) Add the edition name into the header after the logo on the top left<br>
2) Change the colour of the header between editions, eg.<br>
CE = dark grey<br>
EE = black</p>
<p>Thoughts?</p>
RhodeCode CE/EE - Feature #2539 (Feedback): Recursive deletion of resourceshttps://issues.rhodecode.com/issues/25392015-08-25T18:11:48ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Ticket from support: <a href="https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db" class="external">https://rhodecode.tenderapp.com/help/discussions/problems/7125-rc-225-after-deleting-repo-groups-on-file-system-then-rescan-the-repo-groups-are-always-in-the-db</a></p>
<p>Use case:</p>
<ul>
<li>gemalto needs to often delete large repository groups, current system doesn't allow doing it from web interface</li>
<li>users need to delete manually each repo inside repo group and then delete the group itself</li>
</ul>
<p>Currently our system supports this operation in cleanup mode, so you can delete whole directory from the filesystem and run remap-and rescan. This is a workaround and should allow<br>
big cleanup, but it's far from being straightforward to do.</p>
<p>We need a consistent interface for deletion of resource that hold other resources. This should currently include two places</p>
<ul>
<li>user deletion (that hold repo groups/user groups/repositories)</li>
<li>repository group deletion (that hold other repositories)</li>
</ul>
<p>You can delete user or repository group in two ways, goind to admin > users or admin > repo groups and clicking delete.<br>
In case there are dependent objects, we should trigger a warning flash message, and redirect user to advanced settings section of user, or repo group. and allow them to do recursive delete.</p>
<p>There's already an interface for that in users advanced section, when you can select if you want to delete or transfer ownership of repositories or groups that user owns. <br>
We should re-use the logic, and make the same option available to deletion of repository groups. The user advanced section also needs some small improvements.</p>
<p>Recursive delete should have two options.</p>
<ul>
<li>delete resources</li>
<li>transfer ownership of resources to a different user in the system</li>
</ul>
<p>Currently part of that is implemented in user > settings > advanced where we have delete or detach option. <br>
Detach option unfortunetly picks the first super admin in the system which leads to<br>
odd results and you cannot control to whom you need to transfer the ownership.</p>