RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-04-02T14:34:35ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #5610 (Resolved): Files navigation looses the at=<name> markerhttps://issues.rhodecode.com/issues/56102020-04-02T14:34:35ZDaniel Ddaniel@rhodecode.com
<p>During investigation of <a class="issue tracker-1 status-3 priority-2 priority-default" title="Bug: SVN navigation to trunk fails (Resolved)" href="https://issues.rhodecode.com/issues/5599">#5599</a> we also discovered that the ?at= GET marker that indicates current reference we're browsing is getting lost when navigating via tree/files. We'd need to fix this to preserve that marker especially for SVN</p>
RhodeCode CE/EE - Bug #5599 (Resolved): SVN navigation to trunk failshttps://issues.rhodecode.com/issues/55992020-03-27T16:23:49ZLuke Mauldin
<p>In an SVN repository navigation fails when trying to navigate to the version of the file on the trunk.</p>
<p>Scenario:</p>
<ul>
<li>Setup SVN repository with normal layout: branches, tags, trunk</li>
<li>Create a file trunk/test_4.txt and commit multiple changes to it</li>
<li>Navigate to view a non-HEAD revision (assume HEAD is revision 20, but view revision 18) - example: <a href="https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt" class="external">https://XXXXX/playground/testrepo/files/18/trunk/test_4.txt</a></li>
<li>In the left hand side from the revision list choose 'trunk' and the URL generated link is wrong - <a href="https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt" class="external">https://etsgit.gvl.is.l-3com.com/playground/testrepo/files/trunk/test_4.txt@20/trunk/test_4.txt</a></li>
<li>If I manually edit the address to the following then it workshttps://etsgit.gvl.is.l-3com.com/playground/testrepo/files/20/trunk/test_4.txt: </li>
</ul>
<p>I have not been able to reproduce this with a Git repository.</p>
<p>Version: RhodeCode Enterprise 4.18.2 Community Edition </p>
RhodeCode CE/EE - Bug #5579 (Resolved): JS bug when a commit message can be parsed as a numberhttps://issues.rhodecode.com/issues/55792019-12-29T21:40:15ZOlivier Renaud
<p>Steps to reproduce:</p>
<ul>
<li>Push a commit in a feature branch, with the message "123"</li>
<li>Go to the Pull Request creation page, and select the branch in the "source" drop down.</li>
</ul>
<p>Javascript fails with "TypeError: rawMessage.split is not a function" in getTitleAndDescription (script.js:55503).<br>
The debugger shows that rawMessage is a number at this point, and not a string.</p>
RhodeCode CE/EE - Task #5326 (Resolved): Public usergroup profilehttps://issues.rhodecode.com/issues/53262017-05-30T16:11:23ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Somehow similar to user profile e.g <a href="https://code.rhodecode.com/_profiles/marcink" class="external">https://code.rhodecode.com/_profiles/marcink</a> but for usergroups.</p>
<ul>
<li>expose a view that shows an usergroup with members, really simple</li>
<li>the view checks usergroup permissions(view at least read required)</li>
<li>we need similar helper as for users which will expose a link to the usergroup profile</li>
</ul>
RhodeCode CE/EE - Task #5270 (New): Comments updateshttps://issues.rhodecode.com/issues/52702017-04-05T12:39:52ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>Think about emails sent out on on comments:</p>
<ul>
<li>maybe they shouldn’t be inside both </li>
<li>add more context (TODO resolution)</li>
<li>Maybe thread that would allow reading those ?</li>
</ul>
RhodeCode CE/EE - Bug #4296 (Resolved): [ee] Can not create pull requests with reviewers.https://issues.rhodecode.com/issues/42962016-10-24T17:20:47ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i create a PR in CE it works but in EE it fails. I also get no error message.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Create a pr as admin user</li>
<li>Leave the default reviewer (admin itself) in place</li>
<li>Try to submit the PR</li>
<li>Error happens without error message.</li>
</ol>
<a name="Investigations-so-far"></a>
<h1 >Investigations so far<a href="#Investigations-so-far" class="wiki-anchor">¶</a></h1>
<p>The difference is in the data which is posted to the controller. In CE it works and the POST data looks like this:</p>
<pre><code>{u'review_members': [{u'reasons': [], 'user_id': u'2'}], 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', u'revisions': [u'7fecd3f02a2cc73ac03d267ab234cabbfbb5bf31', u'06c48b467036bba03305640d1fb7854632dce351'], 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<p>In EE it fails and the POST data looks like this:</p>
<pre><code>{'review_members': u'2', 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', 'revisions': u'06c48b467036bba03305640d1fb7854632dce351', 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<pre><code>2016-10-24 16:56:06.533 ERROR [rhodecode.controllers.pullrequests] Error creating pull request: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
Traceback (most recent call last):
File "/nix/store/l1rdgp35mnr58w3hww23l3h8q5zbcld7-python2.7-rhodecode-enterprise-ce-4.5.0/lib/python2.7/site-packages/rhodecode/controllers/pullrequests.py", line 411, in create
_form = PullRequestForm(repo.repo_id)().to_python(controls)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py", line 419, in to_python
value = tp(value, state)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py", line 153, in _to_python
new[name] = validator.to_python(value, state)
Invalid: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
</code></pre> RhodeCode CE/EE - Task #4289 (New): [ce, ee] clean up pygments lexer functions + handlinghttps://issues.rhodecode.com/issues/42892016-10-21T14:40:28ZDaniel Ddaniel@rhodecode.com
<p>Currently there are a few lexer functions that seem duplicated/incoherent with each other. This seems to be also tied with the rc extensions which can define custom lexers/file extension mappings in example-ext.py:</p>
<pre><code>
# =============================================================================
# END OF UTILITY FUNCTIONS HERE
# =============================================================================
# Additional mappings that are not present in the pygments lexers
# used for building stats
# format is {'ext':['Names']} eg. {'py':['Python']} note: there can be
# more than one name for extension
# NOTE: that this will override any mappings in LANGUAGES_EXTENSIONS_MAP
# build by pygments
EXTRA_MAPPINGS = {}
# additional lexer definitions for custom files it's overrides pygments lexers,
# and uses defined name of lexer to colorize the files. Format is {'ext':
# 'lexer_name'} List of lexers can be printed running:
# >> python -c "import pprint;from pygments import lexers;
# pprint.pprint([(x[0], x[1]) for x in lexers.get_all_lexers()]);"
EXTRA_LEXERS = {}
</code></pre>
<p>Then there are the functions get_custom_lexer and the FileNode attributes <code>filenode.lexer</code> which don't seem to follow the same logic - the filenode lexer for example seems to prefer a lexer matching the filename instead of a defined custom lexer.</p>
<p>We should use a common base for getting a lexer - one that first returns custom lexer mappings (so that for example .html can be mapped to mako).</p>
<p>Extending on this it could be possible to make the file extension => lexer mapping a per repository setting, exposed via the ui, which would give the best usability in terms of letting each repo specify which lexer to prefer ... again for example <code>.html => mako</code> </p>
RhodeCode CE/EE - Task #4259 (Resolved): Events, create post-create-user eventhttps://issues.rhodecode.com/issues/42592016-10-03T20:51:03ZMarcin Kuzminski [CTO]marcin@rhodecode.com
<p>I think it'd be usefull to create post-create user event, and add it to webhook/slack/hipchat.</p>
<p>Use case is to create accounts in external systems via webook / notify via chat applications about new users.</p>
RhodeCode CE/EE - Feature #4074 (New): Edit review commenthttps://issues.rhodecode.com/issues/40742016-07-06T16:50:33ZTamas Gemes
<p>Currently you can only create and delete your comments during a review.<br>
This is the same for in-code comments and global (commit or pull request) comments.</p>
<p>It would be nice to have an edit feature too.</p>
Documentation - Task #3093 (New): [API] - update hg/git update pr API. Auto updates PR on pushhttps://issues.rhodecode.com/issues/30932016-01-21T15:30:21ZBrian Butlerbrian@rhodecode.comDocumentation - Task #3092 (New): [RCE, ini] - doc available settings + check tender with Gemalto...https://issues.rhodecode.com/issues/30922016-01-21T15:10:51ZBrian Butlerbrian@rhodecode.comDocumentation - Feature #687 (New): [Integraton ]- Elastic search integrationhttps://issues.rhodecode.com/issues/6872015-01-12T11:07:47ZBrian Butlerbrian@rhodecode.comDocumentation - Task #682 (New): Error Msg guidehttps://issues.rhodecode.com/issues/6822015-01-12T08:56:24ZBrian Butlerbrian@rhodecode.com
<p>We should have a guide that describes the messages, and the actions to take for each one</p>
Documentation - Feature #659 (New): Peer to Peer Failoverhttps://issues.rhodecode.com/issues/6592015-01-08T15:47:01ZBrian Butlerbrian@rhodecode.com
<p>doc this if we have</p>
Documentation - Feature #317 (New): Stylinghttps://issues.rhodecode.com/issues/3172014-11-12T09:44:42ZBrian Butlerbrian@rhodecode.com
<p>Create a Sphinx style for RhodeCode docs</p>