RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042016-10-24T17:20:47ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #4296 (Resolved): [ee] Can not create pull requests with reviewers.https://issues.rhodecode.com/issues/42962016-10-24T17:20:47ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i create a PR in CE it works but in EE it fails. I also get no error message.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Create a pr as admin user</li>
<li>Leave the default reviewer (admin itself) in place</li>
<li>Try to submit the PR</li>
<li>Error happens without error message.</li>
</ol>
<a name="Investigations-so-far"></a>
<h1 >Investigations so far<a href="#Investigations-so-far" class="wiki-anchor">¶</a></h1>
<p>The difference is in the data which is posted to the controller. In CE it works and the POST data looks like this:</p>
<pre><code>{u'review_members': [{u'reasons': [], 'user_id': u'2'}], 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', u'revisions': [u'7fecd3f02a2cc73ac03d267ab234cabbfbb5bf31', u'06c48b467036bba03305640d1fb7854632dce351'], 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<p>In EE it fails and the POST data looks like this:</p>
<pre><code>{'review_members': u'2', 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', 'revisions': u'06c48b467036bba03305640d1fb7854632dce351', 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<pre><code>2016-10-24 16:56:06.533 ERROR [rhodecode.controllers.pullrequests] Error creating pull request: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
Traceback (most recent call last):
File "/nix/store/l1rdgp35mnr58w3hww23l3h8q5zbcld7-python2.7-rhodecode-enterprise-ce-4.5.0/lib/python2.7/site-packages/rhodecode/controllers/pullrequests.py", line 411, in create
_form = PullRequestForm(repo.repo_id)().to_python(controls)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py", line 419, in to_python
value = tp(value, state)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py", line 153, in _to_python
new[name] = validator.to_python(value, state)
Invalid: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
</code></pre> RhodeCode CE/EE - Bug #4278 (Resolved): [admin] Clicking the save button in admin -> settings -> ...https://issues.rhodecode.com/issues/42782016-10-14T12:08:32ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i click the save buttton on the issue tracker settings page without having any pattern added and no pattern already in the list it leads to an exception.<br>
If i add a pattern or if there is at least one pattern already present it works fine.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Open the page <a href="http://localhost:5000/_admin/settings/issue-tracker" class="external">http://localhost:5000/_admin/settings/issue-tracker</a> (adapt to your host)</li>
<li>Make sure that no pattern is in the list and don't add one.</li>
<li>Click the save button</li>
<li>Exception happens</li>
</ol>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<p>2016-10-14 12:01:34.209 ERROR [rhodecode.lib.middleware.error_handling] 'NoneType' object has no attribute '<strong>getitem</strong>'<br>
Traceback (most recent call last):<br>
File "/Users/mb/work/ce/rhodecode/lib/middleware/error_handling.py", line 72, in handle_request<br>
response = request.get_response(self.app)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1320, in send<br>
application, catch_exc_info=False)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1284, in call_application<br>
app_iter = application(self.environ, start_response)<br>
File "/nix/store/nsdj1vmp0ir7hbgwb7sjb27cr8d8kplv-python2.7-Paste-2.0.2/lib/python2.7/site-packages/paste/registry.py", line 379, in <strong>call</strong><br>
app_iter = self.application(environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 103, in <strong>call</strong><br>
response = self.dispatch(controller, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 313, in dispatch<br>
return controller(environ, start_response)<br>
File "/Users/mb/work/ce/rhodecode/lib/base.py", line 502, in <strong>call</strong><br>
return WSGIController.<strong>call</strong>(self, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 214, in <strong>call</strong><br>
response = self.<u>dispatch_call()<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 164, in _dispatch_call<br>
response = self._inspect_call(func)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 107, in _inspect_call<br>
result = self._perform_call(func, args)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 57, in _perform_call<br>
return func(**args)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1334, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1143, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/controllers/admin/settings.py", line 400, in settings_issuetracker_save<br>
for uid in form['delete_patterns']:<br>
TypeError: 'NoneType' object has no attribute '</u><u>getitem</u>_'</p>
RhodeCode CE/EE - Bug #4277 (Resolved): [frontend] System info page does not work correctly in sa...https://issues.rhodecode.com/issues/42772016-10-13T13:04:34ZMartin Bornholdmartin@rhodecode.com
<p>I noticed that the system info page (<a href="http://localhost:5000/_admin/settings/system" class="external">http://localhost:5000/_admin/settings/system</a>) does not work correctly on safari. If i open it, the whole "System Info" container is empty.<br>
Looks like also the full text serach page is affected (<a href="http://localhost:5000/_admin/settings/search" class="external">http://localhost:5000/_admin/settings/search</a>)</p>
<p>Tested on:</p>
<ul>
<li>OSX 10.11.6 (15G31)</li>
<li>Safari Version 9.1.2 (11601.7.7)</li>
<li>RhodeCode CE <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/0dd9ca245933267ffef10fec800185c854a285ee" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/0dd9ca245933267ffef10fec800185c854a285ee</a></li>
</ul>
RhodeCode CE/EE - Bug #4276 (Resolved): System info page uses mercurial/git versions from RhodeCo...https://issues.rhodecode.com/issues/42762016-10-13T13:02:06ZMartin Bornholdmartin@rhodecode.com
<p>On the system info page (<a href="http://localhost:5000/_admin/settings/system" class="external">http://localhost:5000/_admin/settings/system</a>) we are displaying the versions of git, mercurial and subversion. Only in the git case we query the VCSServer to tell us which version it uses. In the case of mercurial and subversion we are using the packages which are available to RhodeCode if they are available. This is wrong because we want to display the versions which the VCSServer uses and not RhodeCode.</p>
<p>We should change this to query the VCSServer for all of them.</p>
RhodeCode CE/EE - Bug #4247 (Resolved): [vcs] Using current time as timestamp during archive crea...https://issues.rhodecode.com/issues/42472016-09-27T16:55:41ZMartin Bornholdmartin@rhodecode.com
<p>Our code uses the current time as modification timestamp when creating repository archives. This leads to different hash values (e.g. md5sum) of the created archive files although no code was changes. This is the reason why we had to chenge the hash of rhodecode-tools repository several times.</p>
RhodeCode CE/EE - Bug #4116 (New): [ee] Starting EE or running paster commands like setup-rhodeco...https://issues.rhodecode.com/issues/41162016-07-22T09:03:20ZMartin Bornholdmartin@rhodecode.com
<p>Running EE with pserve or paster commands like setup-rhodecode command works only if i set <code>export LC_ALL=en_US.UTF-8</code><br>
Steps to reproduce the error:</p>
<pre><code>export LC_ALL=''
paster setup-rhodecode --user=admin --email=admin@example.com --password=secret --api-key=9999999999999999999999999999999999999999 http_waitress.ini
</code></pre>
<p>or </p>
<pre><code>export LC_ALL=''
pserve http_waitress.ini
</code></pre> RhodeCode CE/EE - Bug #4109 (New): [files] The "switch to commit" widget is broken after using br...https://issues.rhodecode.com/issues/41092016-07-19T15:33:47ZMartin Bornholdmartin@rhodecode.com
<p>On the files page of a repository e.g. <a href="http://localhost:5000/ce/files/tip/" class="external">http://localhost:5000/ce/files/tip/</a> we have this "switch to commit" widget to switch to other tags/branches/etc. If works fine but if i browse to another page and use the browser back button it doesn't worn anymore.</p>
<p>Occurs at least in these browsers on OSX:</p>
<ul>
<li>Firefox 47.0.1</li>
<li>Safari Version 9.1.1 (11601.6.17)</li>
</ul>
<p>Steps to reproduce:</p>
<ol>
<li>Open the files page of a repository.</li>
<li>Open a file from the file list.</li>
<li>Use browser back button to go back to the files page.</li>
<li>Now the "switch to commit" widget doesn't work anymore.</li>
</ol>