RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042016-10-24T17:20:47ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #4296 (Resolved): [ee] Can not create pull requests with reviewers.https://issues.rhodecode.com/issues/42962016-10-24T17:20:47ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i create a PR in CE it works but in EE it fails. I also get no error message.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Create a pr as admin user</li>
<li>Leave the default reviewer (admin itself) in place</li>
<li>Try to submit the PR</li>
<li>Error happens without error message.</li>
</ol>
<a name="Investigations-so-far"></a>
<h1 >Investigations so far<a href="#Investigations-so-far" class="wiki-anchor">¶</a></h1>
<p>The difference is in the data which is posted to the controller. In CE it works and the POST data looks like this:</p>
<pre><code>{u'review_members': [{u'reasons': [], 'user_id': u'2'}], 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', u'revisions': [u'7fecd3f02a2cc73ac03d267ab234cabbfbb5bf31', u'06c48b467036bba03305640d1fb7854632dce351'], 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<p>In EE it fails and the POST data looks like this:</p>
<pre><code>{'review_members': u'2', 'target_repo': u'TestRepos/project', 'pullrequest_title': u'Default', 'source_repo': u'TestRepos/project-fork', 'target_ref': u'branch:default:89a6bb805daafd7fd64f398c20163fd393401f0a', 'user': u'', 'pullrequest_desc': u'- fork\r\n- fork\r\n', 'save': u'Submit Pull Request', 'revisions': u'06c48b467036bba03305640d1fb7854632dce351', 'source_ref': u'branch:default:06c48b467036bba03305640d1fb7854632dce351'}
</code></pre>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<pre><code>2016-10-24 16:56:06.533 ERROR [rhodecode.controllers.pullrequests] Error creating pull request: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
Traceback (most recent call last):
File "/nix/store/l1rdgp35mnr58w3hww23l3h8q5zbcld7-python2.7-rhodecode-enterprise-ce-4.5.0/lib/python2.7/site-packages/rhodecode/controllers/pullrequests.py", line 411, in create
_form = PullRequestForm(repo.repo_id)().to_python(controls)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/api.py", line 419, in to_python
value = tp(value, state)
File "/nix/store/b6lchaz3i9a7gv71hlh60qgnw5z6k63c-python2.7-FormEncode-1.2.4/lib/python2.7/site-packages/formencode/schema.py", line 153, in _to_python
new[name] = validator.to_python(value, state)
Invalid: review_members: Errors:
The input must be dict-like (not a <type 'unicode'>: u'2')
</code></pre> RhodeCode CE/EE - Bug #4278 (Resolved): [admin] Clicking the save button in admin -> settings -> ...https://issues.rhodecode.com/issues/42782016-10-14T12:08:32ZMartin Bornholdmartin@rhodecode.com
<a name="Description"></a>
<h1 >Description<a href="#Description" class="wiki-anchor">¶</a></h1>
<p>If i click the save buttton on the issue tracker settings page without having any pattern added and no pattern already in the list it leads to an exception.<br>
If i add a pattern or if there is at least one pattern already present it works fine.</p>
<a name="Steps-to-reproduce"></a>
<h1 >Steps to reproduce<a href="#Steps-to-reproduce" class="wiki-anchor">¶</a></h1>
<ol>
<li>Open the page <a href="http://localhost:5000/_admin/settings/issue-tracker" class="external">http://localhost:5000/_admin/settings/issue-tracker</a> (adapt to your host)</li>
<li>Make sure that no pattern is in the list and don't add one.</li>
<li>Click the save button</li>
<li>Exception happens</li>
</ol>
<a name="Traceback"></a>
<h1 >Traceback<a href="#Traceback" class="wiki-anchor">¶</a></h1>
<p>2016-10-14 12:01:34.209 ERROR [rhodecode.lib.middleware.error_handling] 'NoneType' object has no attribute '<strong>getitem</strong>'<br>
Traceback (most recent call last):<br>
File "/Users/mb/work/ce/rhodecode/lib/middleware/error_handling.py", line 72, in handle_request<br>
response = request.get_response(self.app)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1320, in send<br>
application, catch_exc_info=False)<br>
File "/nix/store/5z86vjf0azxh3qjsg5dnv5j6xbl0scgm-python2.7-WebOb-1.3.1/lib/python2.7/site-packages/webob/request.py", line 1284, in call_application<br>
app_iter = application(self.environ, start_response)<br>
File "/nix/store/nsdj1vmp0ir7hbgwb7sjb27cr8d8kplv-python2.7-Paste-2.0.2/lib/python2.7/site-packages/paste/registry.py", line 379, in <strong>call</strong><br>
app_iter = self.application(environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 103, in <strong>call</strong><br>
response = self.dispatch(controller, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/wsgiapp.py", line 313, in dispatch<br>
return controller(environ, start_response)<br>
File "/Users/mb/work/ce/rhodecode/lib/base.py", line 502, in <strong>call</strong><br>
return WSGIController.<strong>call</strong>(self, environ, start_response)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 214, in <strong>call</strong><br>
response = self.<u>dispatch_call()<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 164, in _dispatch_call<br>
response = self._inspect_call(func)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 107, in _inspect_call<br>
result = self._perform_call(func, args)<br>
File "/nix/store/bzzl9k49f51l3vjjl9fs1q116alpjxhp-python2.7-Pylons-1.0.1-patch1/lib/python2.7/site-packages/pylons/controllers/core.py", line 57, in _perform_call<br>
return func(**args)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1334, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1901, in local_wrapper<br>
return wrapper(func, *args, **kwds)<br>
File "/Users/mb/work/ce/rhodecode/lib/auth.py", line 1143, in __wrapper<br>
return func(*fargs, **fkwargs)<br>
File "/Users/mb/work/ce/rhodecode/controllers/admin/settings.py", line 400, in settings_issuetracker_save<br>
for uid in form['delete_patterns']:<br>
TypeError: 'NoneType' object has no attribute '</u><u>getitem</u>_'</p>
RhodeCode CE/EE - Bug #4277 (Resolved): [frontend] System info page does not work correctly in sa...https://issues.rhodecode.com/issues/42772016-10-13T13:04:34ZMartin Bornholdmartin@rhodecode.com
<p>I noticed that the system info page (<a href="http://localhost:5000/_admin/settings/system" class="external">http://localhost:5000/_admin/settings/system</a>) does not work correctly on safari. If i open it, the whole "System Info" container is empty.<br>
Looks like also the full text serach page is affected (<a href="http://localhost:5000/_admin/settings/search" class="external">http://localhost:5000/_admin/settings/search</a>)</p>
<p>Tested on:</p>
<ul>
<li>OSX 10.11.6 (15G31)</li>
<li>Safari Version 9.1.2 (11601.7.7)</li>
<li>RhodeCode CE <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/0dd9ca245933267ffef10fec800185c854a285ee" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/changeset/0dd9ca245933267ffef10fec800185c854a285ee</a></li>
</ul>
RhodeCode CE/EE - Bug #4276 (Resolved): System info page uses mercurial/git versions from RhodeCo...https://issues.rhodecode.com/issues/42762016-10-13T13:02:06ZMartin Bornholdmartin@rhodecode.com
<p>On the system info page (<a href="http://localhost:5000/_admin/settings/system" class="external">http://localhost:5000/_admin/settings/system</a>) we are displaying the versions of git, mercurial and subversion. Only in the git case we query the VCSServer to tell us which version it uses. In the case of mercurial and subversion we are using the packages which are available to RhodeCode if they are available. This is wrong because we want to display the versions which the VCSServer uses and not RhodeCode.</p>
<p>We should change this to query the VCSServer for all of them.</p>
RhodeCode CE/EE - Bug #4164 (Rejected): [api] Repository URL does not contain the port number.https://issues.rhodecode.com/issues/41642016-08-11T09:18:53ZMartin Bornholdmartin@rhodecode.com
<p>When running RhodeCode at <a href="http://localhost:5000" class="external">http://localhost:5000</a> the API call to <code>get_repos</code> returns repository URLs without the port number included.<br>
Maybe other API methods are also affected.</p>
RhodeCode CE/EE - Bug #4135 (Closed): [events] Events of type 'PullRequestEvent' are accessing th...https://issues.rhodecode.com/issues/41352016-07-27T18:19:09ZMartin Bornholdmartin@rhodecode.com
<p>When handling the PullRequestCreateEvent we are trying to lookup the commit ID's in the target repository. This will lead to a CommitDoesNotExist exception because the (new) commit ID's are only available in the source repository of the PR. A quick check showed that all pull request events are subclasses of the RepoEvent and are passing the target_repo to the RepoEvent constructor. If something later calls the _get_commits_as_dict() function with a commit ID from the source repository it will raise a CommitDoesNotExistError. So this bug could happen on every pull request related event.</p>
<p>Pointer: <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/8bb872ec7b8e41f464e6ddc811fc99170af56076/rhodecode/events/pullrequest.py#L32" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ce/files/8bb872ec7b8e41f464e6ddc811fc99170af56076/rhodecode/events/pullrequest.py#L32</a></p>
<p>Snippet from the server logs:</p>
<pre><code>2016-07-27 14:43:28.306 DEBUG [routes.middleware] Matched POST /u/martinb/rhodecode-enterprise-ce-fork/pull-request/new
2016-07-27 14:43:28.306 DEBUG [routes.middleware] Route path: '/{repo_name}/pull-request/new', defaults: {'action': u'create', 'controller': u'pullrequests'}
2016-07-27 14:43:28.306 DEBUG [routes.middleware] Match dict: {'action': u'create', 'repo_name': u'u/martinb/rhodecode-enterprise-ce-fork', 'controller': u'pullrequests'}
[ ... ] snip
2016-07-27 14:43:29.906 DEBUG [rhodecode.lib.vcs.backends] Creating instance of hg repository from /home/rhodecode/rhodecode/repositories/rhodecode-enterprise-ce
2016-07-27 14:43:29.906 DEBUG [rhodecode.lib.vcs.client_http] RepoMaker call on /home/rhodecode/rhodecode/repositories/rhodecode-enterprise-ce
2016-07-27 14:43:29.907 DEBUG [rhodecode.lib.vcs.client_http] Calling http://localhost:9900/hg@localrepository
2016-07-27 14:43:29.927 DEBUG [rhodecode.lib.vcs.client_http] Calling http://localhost:9900/hg@get_all_commit_ids
2016-07-27 14:43:29.934 DEBUG [rhodecode.lib.vcs.client_http] Calling http://localhost:9900/hg@lookup
2016-07-27 14:43:29.941 ERROR [root] 82fa7f5f67784ff207230436bad0fc83a4118ced
Traceback (most recent call last):
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/events/repo.py", line 67, in _commits_as_dict
cs = vcs_repo.get_changeset(commit_id)
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/lib/vcs/backends/base.py", line 528, in get_changeset
commit_id=commit_id, commit_idx=commit_idx, pre_load=pre_load)
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/lib/vcs/backends/hg/repository.py", line 447, in get_commit
raw_id, idx = self._remote.lookup(commit_id, both=True)
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/lib/vcs/client_http.py", line 105, in f
return self._call(name, *args, **kwargs)
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/lib/vcs/client_http.py", line 123, in _call_with_logging
return RemoteRepo._call(self, name, *args, **kwargs)
File "/nix/store/8419cz1447jjmlq68yli0kx2asr3nz0s-python2.7-rhodecode-enterprise-ce-4.3.0+20160726x120343x2f93a63710fc/lib/python2.7/site-packages/rhodecode/lib/vcs/exceptions.py", line 182, in wrapper
raise _EXCEPTION_MAP[kind](*e.args)
CommitDoesNotExistError: 82fa7f5f67784ff207230436bad0fc83a4118ced
2016-07-27 14:43:29.973 DEBUG [root] handling slack event for pullrequest-create
</code></pre> RhodeCode CE/EE - Bug #4116 (New): [ee] Starting EE or running paster commands like setup-rhodeco...https://issues.rhodecode.com/issues/41162016-07-22T09:03:20ZMartin Bornholdmartin@rhodecode.com
<p>Running EE with pserve or paster commands like setup-rhodecode command works only if i set <code>export LC_ALL=en_US.UTF-8</code><br>
Steps to reproduce the error:</p>
<pre><code>export LC_ALL=''
paster setup-rhodecode --user=admin --email=admin@example.com --password=secret --api-key=9999999999999999999999999999999999999999 http_waitress.ini
</code></pre>
<p>or </p>
<pre><code>export LC_ALL=''
pserve http_waitress.ini
</code></pre> RhodeCode CE/EE - Feature #4113 (Closed): [tests] Add ability to discover available repositories.https://issues.rhodecode.com/issues/41132016-07-21T15:45:55ZMartin Bornholdmartin@rhodecode.com
<p>Currently the tests are relying on the default vcs test repositories like <code>test_vcs_svn</code>. If the tests are able to auto discover which repositories are available and use them for testing it will simplify setting up the correct environment to run the tests.</p>
RhodeCode CE/EE - Bug #4109 (New): [files] The "switch to commit" widget is broken after using br...https://issues.rhodecode.com/issues/41092016-07-19T15:33:47ZMartin Bornholdmartin@rhodecode.com
<p>On the files page of a repository e.g. <a href="http://localhost:5000/ce/files/tip/" class="external">http://localhost:5000/ce/files/tip/</a> we have this "switch to commit" widget to switch to other tags/branches/etc. If works fine but if i browse to another page and use the browser back button it doesn't worn anymore.</p>
<p>Occurs at least in these browsers on OSX:</p>
<ul>
<li>Firefox 47.0.1</li>
<li>Safari Version 9.1.1 (11601.6.17)</li>
</ul>
<p>Steps to reproduce:</p>
<ol>
<li>Open the files page of a repository.</li>
<li>Open a file from the file list.</li>
<li>Use browser back button to go back to the files page.</li>
<li>Now the "switch to commit" widget doesn't work anymore.</li>
</ol>
RhodeCode CE/EE - Feature #4098 (Closed): [tests] Add svn support to locust performance testhttps://issues.rhodecode.com/issues/40982016-07-18T08:50:52ZMartin Bornholdmartin@rhodecode.com
<p>The current implementation is limited to the hg backend.</p>
<p>Goal:</p>
<ul>
<li>Performance tests are able to execute svn operations (clone/commit)</li>
</ul>
RhodeCode CE/EE - Feature #4097 (Closed): [test] Add git support to locust performance testhttps://issues.rhodecode.com/issues/40972016-07-18T08:49:13ZMartin Bornholdmartin@rhodecode.com
<p>The current implementation is limited to the hg backend.</p>
<p>Goal:</p>
<ul>
<li>Performance tests are able to execute git operations (clone/push/pull)</li>
</ul>
RhodeCode CE/EE - Feature #4096 (Closed): [test] Extend locust performance tests to add commitshttps://issues.rhodecode.com/issues/40962016-07-18T08:47:07ZMartin Bornholdmartin@rhodecode.com
<p>The current implementation executes the pull/push commands without adding new commits to the repository. Would be great if the tests are also adding commits prior to pushing to the repository.</p>
<p>Goal:</p>
<ul>
<li>Add a method that creates commits in the local repository.</li>
</ul>
RhodeCode CE/EE - Task #4095 (Closed): [tests] Move locust based performance tests to ac-tests re...https://issues.rhodecode.com/issues/40952016-07-18T08:42:19ZMartin Bornholdmartin@rhodecode.com
<p>Currently we have at least two test which are based on locust that are living at CE/rhodecode/tests/load/. It has nothin in common with the application and is executed outside of the application context. Therefore we should remove it from the CE repo and add it to the ac-tests repository.</p>
RhodeCode CE/EE - Feature #4094 (Closed): [tests] Improve repository operations performance test.https://issues.rhodecode.com/issues/40942016-07-18T08:38:15ZMartin Bornholdmartin@rhodecode.com
<p>We have a first implementation of a performance test that executes multiple repository operations (push/pull/clone) to stress our system. It it based on the locust library <a href="http://locust.io" class="external">http://locust.io</a> . Current implementation is limited to the mercurial backend and should be extended to also support git and svn operations. The code is located at <a href="https://internal-code.rhodecode.com/rhodecode-enterprise-ac-tests/files/tip/loadtest" class="external">https://internal-code.rhodecode.com/rhodecode-enterprise-ac-tests/files/tip/loadtest</a></p>
<p>Improvement Goals</p>
<ul>
<li>Move the code from CE repo to AC-Tests</li>
<li>Add support for SVN</li>
<li>Add support for GIT</li>
<li>Refactor code to split out common code. Maybe a common base class for git/svn/hg?</li>
<li>Add support for adding commits to the repositories</li>
<li>Make running the tests as simple as possible</li>
</ul>
RhodeCode CE/EE - Bug #4010 (Closed): [ce] Check that HTTPS fixup middleware wraps also pyramid v...https://issues.rhodecode.com/issues/40102016-06-10T12:45:29ZMartin Bornholdmartin@rhodecode.com
<p>MarcinK reported that the redirect after logging in via the quick login box points him from HTTPS -> HTTP.<br>
Normally the HTTPS fixup middleware should handle this.</p>
<p>We shortly migrated the login view from pylons to pyramid. Maybe the middleware only wraps pylons views and not pyramid views.</p>