RhodeCode - issues: Issueshttps://issues.rhodecode.com/https://issues.rhodecode.com/favicon.ico?16960560042020-04-02T14:34:35ZRhodeCode - issues
Redmine RhodeCode CE/EE - Bug #5610 (Resolved): Files navigation looses the at=<name> markerhttps://issues.rhodecode.com/issues/56102020-04-02T14:34:35ZDaniel Ddaniel@rhodecode.com
<p>During investigation of <a class="issue tracker-1 status-3 priority-2 priority-default" title="Bug: SVN navigation to trunk fails (Resolved)" href="https://issues.rhodecode.com/issues/5599">#5599</a> we also discovered that the ?at= GET marker that indicates current reference we're browsing is getting lost when navigating via tree/files. We'd need to fix this to preserve that marker especially for SVN</p>
RhodeCode CE/EE - Bug #4268 (Resolved): [ee] default reviewers from changed lines is returning wr...https://issues.rhodecode.com/issues/42682016-10-06T14:18:07ZDaniel Ddaniel@rhodecode.com
<p>When getting default reviewers from authors of changed lines, not all the hunks are being processed, just the first one, meaning the changed lines are wrong (too low)</p>
RhodeCode CE/EE - Bug #4256 (New): [ce, ee, ux] Source code highlight colors conflict with red/gr...https://issues.rhodecode.com/issues/42562016-10-03T05:00:14ZDaniel Ddaniel@rhodecode.com
<p>The CSS for pygments uses some green and red text which conflict with green/red blocks we use in diffs - have to change these to something else. </p>
RhodeCode CE/EE - Bug #4208 (New): [ce, ee] test errors get hidden by error pagehttps://issues.rhodecode.com/issues/42082016-08-30T18:42:32ZDaniel Ddaniel@rhodecode.com
<p>When running tests the traceback is excepted away by the error handler page, this makes it difficult to debug since eg</p>
<pre><code>app.get('/page_that_errors')
</code></pre>
<p>will return a 500 error page instead of a traceback.</p>
<p>OTOH making tests always raise errors will then break the page that checks if the pretty error page is working as it should.</p>
<p>Need to add a dynamic setting, eg settings['use_error_document'] = False - that can be turned on/off at will and will disable the pretty error page handler for running tests.</p>
RhodeCode CE/EE - Bug #4173 (Resolved): [ce, ee] mysql recycle pool timeout not workinghttps://issues.rhodecode.com/issues/41732016-08-12T16:41:27ZDaniel Ddaniel@rhodecode.com
<p>Replication:</p>
<ul>
<li>new config using mysql database</li>
<li>set mysql's wait_timeout to 6</li>
<li><code>threads = 1</code> in ini</li>
<li><code>sqlalchemy.db1.pool_recycle = 3</code> in ini</li>
<li>git push a repo (no changes need, just a push)</li>
<li>wait 7 seconds</li>
<li>git push again</li>
<li>get - <code>OperationalError: (OperationalError) (2006, 'MySQL server has gone away)</code></li>
</ul>
<p>This will also break subsequent requests with <code>StatementError: Can't reconnect until invalid transaction is rolled back</code></p>
RhodeCode CE/EE - Bug #4154 (New): [ce, ee] user register via github captchahttps://issues.rhodecode.com/issues/41542016-08-05T22:51:47ZDaniel Ddaniel@rhodecode.com
<p>Found on code.rhodecode.com - sign up using github account - captcha is asked but not verified.</p>
RhodeCode CE/EE - Bug #4121 (Resolved): [ce, ee] server announcement has extra marginhttps://issues.rhodecode.com/issues/41212016-07-25T00:12:12ZDaniel Ddaniel@rhodecode.com
<p>Steps to reproduce:</p>
<ul>
<li>goto /_admin/settings/global</li>
<li>pick 'server announcement' in Custom Header Code</li>
<li>save</li>
<li>there white space at top of page before the announcement</li>
</ul>
<p>The announcement script injects an which has a 40px margin-top.</p>
<p>We could inline style="margin-top: 0" in the script code - or refactor .alert boxes to avoid having a defined margin.</p>
RhodeCode CE/EE - Bug #4110 (In Progress): [ce, ee] repos can be named _admin, _statichttps://issues.rhodecode.com/issues/41102016-07-20T13:34:37ZDaniel Ddaniel@rhodecode.com
<p>There is a bug where repo name can have the name '_admin' this is because ADMIN_PREFIX which is used for checking the repo name had a slash prefixed to it making the check not work.</p>
<p>Must fix the bug and make this check more robust.</p>
RhodeCode CE/EE - Bug #4091 (Resolved): [ce, ee] Redmine integration blocks for 30 seconds if red...https://issues.rhodecode.com/issues/40912016-07-15T08:59:15ZDaniel Ddaniel@rhodecode.com
<p>This is a problem when not running celery - ie. sync mode, should lower the timeout to something smaller.</p>
RhodeCode CE/EE - Bug #4040 (New): [ce, ee] logout when logged out causes 403 Cross-site request ...https://issues.rhodecode.com/issues/40402016-06-22T21:09:03ZDaniel Ddaniel@rhodecode.com
<p>Reproduce:</p>
<ul>
<li>Login to rhodecode</li>
<li>Logout in another tab</li>
<li>Click logout in original tab</li>
</ul>
RhodeCode CE/EE - Bug #3971 (Resolved): [ce, vcs] Merge requests/Pull requests failing due to reb...https://issues.rhodecode.com/issues/39712016-06-02T12:22:19ZDaniel Ddaniel@rhodecode.com
<p>There is a problem with pull requests that sometimes say they are okay for merging but fail once the pull request is completed and the merge/rebase actually takes place.</p>
<p>I can't manage to reproduce this locally, and the problem seems intermittent. Apparently after trying a few times the merge may go through, which might point to a caching problem.</p>
<p>It seems the <em>real</em> merge is failing because it tries to create a new head in the repo, or 'no rebase in progress': </p>
<p><a href="https://ae.rhodecode.com/ui/report/593/17604" class="external">https://ae.rhodecode.com/ui/report/593/17604</a></p>
<pre><code> File rhodecode/controllers/pullrequests.py, line 659 in show
c.pull_request)
File rhodecode/model/pull_request.py, line 871 in merge_status
resp = self._try_merge(pull_request)
File rhodecode/model/pull_request.py, line 920 in _try_merge
pull_request, target_vcs, target_ref)
File rhodecode/model/pull_request.py, line 949 in _refresh_merge_state
workspace_id, dry_run=True)
File rhodecode/lib/vcs/backends/base.py, line 410 in merge
source_ref, message, user_name, user_email, dry_run=dry_run)
user_email user@email.com
message sample_message
source_ref
0 u'book'
1 u'elasticsearch-indexer'
2 u'072565c887d78ce373e6673a8568f7fe720abc4b'
shadow_repository_path /home/rhodecode/rhodecode/repositories/.__shadow_rhodecode-tools-ce_pr-2254
user_name user name
File rhodecode/lib/vcs/backends/hg/repository.py, line 686 in _merge_repo
log.exception('Failure when doing local merge on hg shadow repo')
shadow_repo <MercurialRepository at /home/rhodecode/rhodecode/repositories/.__shadow_rhodecode-tools-ce_pr-2254>
merge_failure_reason 0
e RepositoryError('no rebase in progress',)
</code></pre>
<p><a href="https://ae.rhodecode.com/ui/logs?resource=9&request_id=d40cf9ced8cb4b7ba620e2fc20f9d58a" class="external">https://ae.rhodecode.com/ui/logs?resource=9&request_id=d40cf9ced8cb4b7ba620e2fc20f9d58a</a></p>
<pre><code> Failure when doing local push on hg shadow repo
Traceback (most recent call last):
File "/nix/store/d7nhcy7xnmmisn6ck0sh5r874g9bdq8d-python2.7-rhodecode-enterprise-ce-4.1.0+20160601x133047xebb9963becd3/lib/python2.7/site-packages/rhodecode/lib/vcs/backends/hg/repository.py", line 711, in _merge_repo
enable_hooks=True)
File "/nix/store/d7nhcy7xnmmisn6ck0sh5r874g9bdq8d-python2.7-rhodecode-enterprise-ce-4.1.0+20160601x133047xebb9963becd3/lib/python2.7/site-packages/rhodecode/lib/vcs/backends/hg/repository.py", line 578, in _local_push
push_branches=push_branches)
File "/nix/store/d7nhcy7xnmmisn6ck0sh5r874g9bdq8d-python2.7-rhodecode-enterprise-ce-4.1.0+20160601x133047xebb9963becd3/lib/python2.7/site-packages/rhodecode/lib/vcs/client_http.py", line 102, in f
return self._call(name, *args, **kwargs)
File "/nix/store/d7nhcy7xnmmisn6ck0sh5r874g9bdq8d-python2.7-rhodecode-enterprise-ce-4.1.0+20160601x133047xebb9963becd3/lib/python2.7/site-packages/rhodecode/lib/vcs/client_http.py", line 120, in _call_with_logging
return RemoteRepo._call(self, name, *args, **kwargs)
File "/nix/store/d7nhcy7xnmmisn6ck0sh5r874g9bdq8d-python2.7-rhodecode-enterprise-ce-4.1.0+20160601x133047xebb9963becd3/lib/python2.7/site-packages/rhodecode/lib/vcs/exceptions.py", line 182, in wrapper
raise _EXCEPTION_MAP[kind](*e.args)
RepositoryError: push creates new remote head aee444655256!
</code></pre> RhodeCode CE/EE - Bug #3963 (New): [ce] Getting a newly added repo via remap/rescan via api gives...https://issues.rhodecode.com/issues/39632016-05-27T05:02:18ZDaniel Ddaniel@rhodecode.com
<p>Steps to reproduce:</p>
<ul>
<li>Add a repository to the repo directory</li>
<li>Do a Remap/Rescan</li>
<li>Try get repo_data via api</li>
<li>The last changeset is reported as 00000000000000000</li>
</ul>
<p>Workaround</p>
<ul>
<li>Open the repo change log in Rhodecode loads the data</li>
</ul>
<p>Possible fix:</p>
<ul>
<li>Clear cache and do an update on repo when it is remapped</li>
</ul>
RhodeCode CE/EE - Bug #3956 (New): [ce] - svn commit with all 'None' properties (author, message,...https://issues.rhodecode.com/issues/39562016-05-23T17:22:52ZDaniel Ddaniel@rhodecode.com
<p>It's commit 287 in the libpri repo <code>svn checkout http://svn.asterisk.org/svn/libpri/branches/1.4 libpri</code></p>
<p>Should investigate why/how this happens.</p>
RhodeCode CE/EE - Bug #3922 (New): svn backend returns different diff to git/hg backendshttps://issues.rhodecode.com/issues/39222016-05-11T14:29:02ZDaniel Ddaniel@rhodecode.com
<p>In vcsserver calling <code>a_vcs_backend.diff(rev1='same', rev2='same', path1='samefile', path2='samefile').raw_data</code></p>
<p>returns for SVN:</p>
<pre><code>Index: samefile
===================================================================
diff --git a/samefile b/samefile
--- a/samefile\t(revision 2)
+++ b/samefile\t(revision 2)
</code></pre>
<p>and empty string for both git / hg</p>
<p>Not sure what the correct thing to do is here, empty string makes sense but maybe not when a path has been given in?</p>
RhodeCode CE/EE - Bug #3615 (New): (OperationalError) too many SQL variables on admin journal pagehttps://issues.rhodecode.com/issues/36152016-05-06T11:44:17ZDaniel Ddaniel@rhodecode.com
<p>Steps to reproduce:</p>
<ul>
<li>use sqlite database</li>
<li>add over 1000 repos</li>
<li>open /_admin/journal</li>
</ul>
<p>OperationalError: (OperationalError) too many SQL variables u'SELECT count(*) AS count_1 \nFROM (SELECT user_logs.user_log_id AS user_logs_user_log_id, user_logs.user_id AS user_logs_user_id, user_logs.username AS user_logs_username, user_logs.repository_id AS user_logs_repository_id, user_logs.repository_name AS user_logs_repository_name, user_logs.user_ip AS user_logs_user_ip, user_logs.action AS user_logs_action, user_logs.action_date AS user_logs_action_date \nFROM user_logs \nWHERE user_logs.repository_id IN (?, ?, ?, ?, ?, ?, ?......) ORDER BY user_logs.action_date DESC) AS anon_1' (1,2,....1001 ids)</p>
<pre><code>File "/Users/dan/Projects/rc/rhodecode-enterprise-ce-dan/rhodecode/controllers/journal.py", line 262, in public_journal
c.journal_pager = Page(journal, page=p, items_per_page=20)
File "/nix/store/08jg8cv3mdsjdqa367b9gmilcmif46s3-python2.7-WebHelpers-1.3/lib/python2.7/site-packages/webhelpers/paginate.py", line 413, in __init__
self.item_count = len(self.collection)
</code></pre>
<p>The problem is in <code>rhodecode.controllers.journal.JournalController:_get_journal_data()</code></p>
<p>The query it generates has an IN which can fill up to the max limit for sqlite</p>
<p>Possible solutions:</p>
<ul>
<li>use a for loop</li>
<li>rewrite query to use joins instead</li>
</ul>
<p>Current workarounds:</p>
<ul>
<li>use mysql/postgresql</li>
</ul>